From: Alexander Graf <agraf@suse.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 3/3] ARM: EXYNOS5250: Register architected timers
Date: Thu, 21 Mar 2013 16:40:55 +0100 [thread overview]
Message-ID: <FA105342-1A3A-41E5-87B2-31E9802AD31D@suse.de> (raw)
In-Reply-To: <51421FDA.8070507@cogentembedded.com>
On 14.03.2013, at 20:07, Sergei Shtylyov wrote:
> Hello.
>
> On 14-03-2013 4:59, Alexander Graf wrote:
>
>> When running on an exynos 5250 SoC, we don't initialize the architected
>> timers. The chip however supports architected timers.
>
>> When we don't initialize them, KVM will try to access them and run into
>> NULL pointer dereferences attempting to do so.
>
>> This patch is really more of a hack than a real fix, but does get me
>> working with KVM on Arndale.
>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>> ---
>> arch/arm/mach-exynos/mct.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>
>> diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c
>> index c9d6650..eefb8af 100644
>> --- a/arch/arm/mach-exynos/mct.c
>> +++ b/arch/arm/mach-exynos/mct.c
>> @@ -482,4 +482,8 @@ void __init exynos4_timer_init(void)
>> exynos4_timer_resources();
>> exynos4_clocksource_init();
>> exynos4_clockevent_init();
>> +
>> + if (soc_is_exynos5250()) {
>> + arch_timer_of_register();
>> + }
>
> {} not needed here. scripts/checkpatch.pl should probabl;y warn about it.
Yeah, I'd leave it to whoever wants to apply this patch to remove the braces :). IMHO it's not worth it to respin just for this.
Alex
next prev parent reply other threads:[~2013-03-21 15:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 0:58 [PATCH 0/3] ARM: EXYNOS5250: Enable KVM support Alexander Graf
2013-03-14 0:59 ` [PATCH 1/3] ARM: EXYNOS5250: dts: Declare the gic as a15 compatible Alexander Graf
2013-03-14 0:59 ` [PATCH 2/3] ARM: EXYNOS5250: dts: Add architected timer nodes Alexander Graf
2013-03-14 0:59 ` [PATCH 3/3] ARM: EXYNOS5250: Register architected timers Alexander Graf
2013-03-14 3:26 ` [kvmarm] " Christoffer Dall
2013-03-14 19:07 ` Sergei Shtylyov
2013-03-21 15:40 ` Alexander Graf [this message]
2013-04-02 10:44 ` Kukjin Kim
2013-04-02 11:45 ` Alexander Graf
2013-04-03 4:56 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA105342-1A3A-41E5-87B2-31E9802AD31D@suse.de \
--to=agraf@suse.de \
--cc=kgene.kim@samsung.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).