* [PATCH] KVM: duplicate code
@ 2022-09-16 3:26 liujing
2022-09-16 17:27 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: liujing @ 2022-09-16 3:26 UTC (permalink / raw)
To: seanjc, pbonzini, tglx
Cc: mingo, bp, dave.hansen, x86, hpa, kvm, linux-kernel, liujing
in "static int FNAME(walk_addr_generic)" function,
there is an explanation that uses two to's, which is redundant code
Signed-off-by: liujing <liujing@cmss.chinamobile.com>
---
arch/x86/kvm/mmu/paging_tmpl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/mmu/paging_tmpl.h b/arch/x86/kvm/mmu/paging_tmpl.h
index 39e0205e7300..5ab5f94dcb6f 100644
--- a/arch/x86/kvm/mmu/paging_tmpl.h
+++ b/arch/x86/kvm/mmu/paging_tmpl.h
@@ -472,7 +472,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
#if PTTYPE == PTTYPE_EPT
/*
- * Use PFERR_RSVD_MASK in error_code to to tell if EPT
+ * Use PFERR_RSVD_MASK in error_code to tell if EPT
* misconfiguration requires to be injected. The detection is
* done by is_rsvd_bits_set() above.
*
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: duplicate code
2022-09-16 3:26 [PATCH] KVM: duplicate code liujing
@ 2022-09-16 17:27 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2022-09-16 17:27 UTC (permalink / raw)
To: liujing
Cc: pbonzini, tglx, mingo, bp, dave.hansen, x86, hpa, kvm, linux-kernel
"KVM: x86/mmu:" for the scope.
And explicitly state what the patch does, not what the symptom is, especially since
"duplicate" can be an adjective, noun, or a verb depending on context. And as an
almost nit, state that it's a comment so that it's obvious from the shortlog that
the patch should have no functional impact.
On Thu, Sep 15, 2022, liujing wrote:
> in "static int FNAME(walk_addr_generic)" function,
> there is an explanation that uses two to's, which is redundant code
Again, explicitly state what the patch actually does.
All that said, a patch has already been submitted for this[*]. No need to send a
v2, I'll grab the previous patch.
Thanks!
[*] https://lore.kernel.org/all/20220831125217.12313-1-yuanjilin@cdjrlc.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-16 17:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 3:26 [PATCH] KVM: duplicate code liujing
2022-09-16 17:27 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).