* [PATCH] KVM: VMX: remove duplicated segment cache clear
@ 2020-01-21 15:15 Miaohe Lin
2020-01-21 9:14 ` Vitaly Kuznetsov
2020-01-21 12:17 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Miaohe Lin @ 2020-01-21 15:15 UTC (permalink / raw)
To: pbonzini, rkrcmar, sean.j.christopherson, vkuznets, wanpengli,
jmattson, joro, tglx, mingo, bp, hpa
Cc: linmiaohe, kvm, linux-kernel, x86
vmx_set_segment() clears segment cache unconditionally, so we should not
clear it again by calling vmx_segment_cache_clear().
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
arch/x86/kvm/vmx/vmx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index b5a0c2e05825..b32236e6b513 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu)
vmx->rmode.vm86_active = 0;
- vmx_segment_cache_clear(vmx);
-
vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR);
flags = vmcs_readl(GUEST_RFLAGS);
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: VMX: remove duplicated segment cache clear
2020-01-21 15:15 [PATCH] KVM: VMX: remove duplicated segment cache clear Miaohe Lin
@ 2020-01-21 9:14 ` Vitaly Kuznetsov
2020-01-21 12:17 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Vitaly Kuznetsov @ 2020-01-21 9:14 UTC (permalink / raw)
To: Miaohe Lin
Cc: linmiaohe, kvm, linux-kernel, x86, pbonzini,
sean.j.christopherson, wanpengli, jmattson, joro, tglx, mingo,
bp, hpa
Miaohe Lin <linmiaohe@huawei.com> writes:
> vmx_set_segment() clears segment cache unconditionally, so we should not
> clear it again by calling vmx_segment_cache_clear().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index b5a0c2e05825..b32236e6b513 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu)
>
> vmx->rmode.vm86_active = 0;
>
> - vmx_segment_cache_clear(vmx);
> -
> vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR);
>
> flags = vmcs_readl(GUEST_RFLAGS);
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: VMX: remove duplicated segment cache clear
2020-01-21 15:15 [PATCH] KVM: VMX: remove duplicated segment cache clear Miaohe Lin
2020-01-21 9:14 ` Vitaly Kuznetsov
@ 2020-01-21 12:17 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-01-21 12:17 UTC (permalink / raw)
To: Miaohe Lin, rkrcmar, sean.j.christopherson, vkuznets, wanpengli,
jmattson, joro, tglx, mingo, bp, hpa
Cc: kvm, linux-kernel, x86
On 21/01/20 16:15, Miaohe Lin wrote:
> vmx_set_segment() clears segment cache unconditionally, so we should not
> clear it again by calling vmx_segment_cache_clear().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index b5a0c2e05825..b32236e6b513 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -2688,8 +2688,6 @@ static void enter_pmode(struct kvm_vcpu *vcpu)
>
> vmx->rmode.vm86_active = 0;
>
> - vmx_segment_cache_clear(vmx);
> -
> vmx_set_segment(vcpu, &vmx->rmode.segs[VCPU_SREG_TR], VCPU_SREG_TR);
>
> flags = vmcs_readl(GUEST_RFLAGS);
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-21 12:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 15:15 [PATCH] KVM: VMX: remove duplicated segment cache clear Miaohe Lin
2020-01-21 9:14 ` Vitaly Kuznetsov
2020-01-21 12:17 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).