kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shaokun Zhang <zhangshaokun@hisilicon.com>
To: Marc Zyngier <maz@kernel.org>, Zhu Lingshan <lingshan.zhu@intel.com>
Cc: <jasowang@redhat.com>, <mst@redhat.com>,
	<alex.williamson@redhat.com>, <kvm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<kvmarm@lists.cs.columbia.edu>, <cohuck@redhat.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "irqbypass: do not start cons/prod when failed connect"
Date: Mon, 10 May 2021 09:12:22 +0800	[thread overview]
Message-ID: <cfb68374-a7bf-1eb4-86cf-77c57f7fe9e5@hisilicon.com> (raw)
In-Reply-To: <8735uxvajh.wl-maz@kernel.org>

Hi Marc,

On 2021/5/8 17:29, Marc Zyngier wrote:
> On Sat, 08 May 2021 08:11:52 +0100,
> Zhu Lingshan <lingshan.zhu@intel.com> wrote:
>>
>> This reverts commit a979a6aa009f3c99689432e0cdb5402a4463fb88.
>>
>> The reverted commit may cause VM freeze on arm64 platform.
>> Because on arm64 platform, stop a consumer will suspend the VM,
>> the VM will freeze without a start consumer
> 
> It also unconditionally calls del_consumer on the producer, which
> isn't exactly expected.
> 
>>
>> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> 
> Reported-by: Shaokun Zhang <zhangshaokun@hisilicon.com>

Thanks for the tag, it works with this patch, So:
Tested-by: Shaokun Zhang <zhangshaokun@hisilicon.com>

I shall invite you to have a drink for the quick debug.
Anyway, thank you again.

Shaokun

> Suggested-by: Marc Zyngier <maz@kernel.org>
> Acked-by: Marc Zyngier <maz@kernel.org>
> Fixes: a979a6aa009f ("irqbypass: do not start cons/prod when failed connect")
> Link: https://lore.kernel.org/r/3a2c66d6-6ca0-8478-d24b-61e8e3241b20@hisilicon.com
> Cc: stable@vger.kernel.org
> 
> Thanks,
> 
> 	M.
> 

  parent reply	other threads:[~2021-05-10  1:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  7:11 [PATCH] Revert "irqbypass: do not start cons/prod when failed connect" Zhu Lingshan
2021-05-08  7:22 ` Greg KH
2021-05-08  9:29 ` Marc Zyngier
2021-05-09 17:04   ` Auger Eric
2021-05-10  1:12   ` Shaokun Zhang [this message]
2021-05-10  7:39     ` Marc Zyngier
2021-05-10  2:43 ` Jason Wang
2021-05-10  3:00   ` Zhu, Lingshan
2021-05-10  4:34     ` Jason Wang
2021-05-10  7:09       ` Zhu, Lingshan
2021-05-10  8:32         ` Zhu, Lingshan
2021-05-10 10:00           ` Marc Zyngier
2021-05-10 10:37             ` Zhu, Lingshan
2021-05-10 11:01 ` Marc Zyngier
2021-05-11  8:48 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfb68374-a7bf-1eb4-86cf-77c57f7fe9e5@hisilicon.com \
    --to=zhangshaokun@hisilicon.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=lingshan.zhu@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maz@kernel.org \
    --cc=mst@redhat.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).