From: Gavin Shan <gshan@redhat.com>
To: Florian Weimer <fweimer@redhat.com>
Cc: shan.gavin@gmail.com, kvm@vger.kernel.org, maz@kernel.org,
linux-kernel@vger.kernel.org, andrew.jones@linux.dev,
mathieu.desnoyers@efficios.com, yihyu@redhat.com,
linux-kselftest@vger.kernel.org, pbonzini@redhat.com,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35
Date: Tue, 9 Aug 2022 18:45:26 +1000 [thread overview]
Message-ID: <7844e3fa-e49e-de75-e424-e82d3a023dd6@redhat.com> (raw)
In-Reply-To: <8735e6ncxw.fsf@oldenburg.str.redhat.com>
Hi Florian,
On 8/9/22 4:33 PM, Florian Weimer wrote:
>> diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c
>> index a54d4d05a058..acb1bf1f06b3 100644
>> --- a/tools/testing/selftests/kvm/rseq_test.c
>> +++ b/tools/testing/selftests/kvm/rseq_test.c
>> @@ -9,6 +9,7 @@
>> #include <string.h>
>> #include <signal.h>
>> #include <syscall.h>
>> +#include <dlfcn.h>
>> #include <sys/ioctl.h>
>> #include <sys/sysinfo.h>
>> #include <asm/barrier.h>
>
> I'm surprised that there isn't a Makefile update to link with -ldl
> (still required for glibc 2.33 and earlier).
>
In next revision, I will add '-ldl' into tools/testing/selftests/kvm/Makefile.
>> @@ -36,6 +37,8 @@ static __thread volatile struct rseq __rseq = {
>> */
>> #define NR_TASK_MIGRATIONS 100000
>>
>> +static bool __rseq_ownership;
>> +static volatile struct rseq *__rseq_info;
>> static pthread_t migration_thread;
>> static cpu_set_t possible_mask;
>> static int min_cpu, max_cpu;
>> @@ -49,11 +52,33 @@ static void guest_code(void)
>> GUEST_SYNC(0);
>> }
>>
>> +static void sys_rseq_ownership(void)
>> +{
>> + long *offset;
>> + unsigned int *size, *flags;
>> +
>> + offset = dlsym(RTLD_NEXT, "__rseq_offset");
>> + size = dlsym(RTLD_NEXT, "__rseq_size");
>> + flags = dlsym(RTLD_NEXT, "__rseq_flags");
>> +
>> + if (offset && size && *size && flags) {
>> + __rseq_ownership = false;
>> + __rseq_info = (struct rseq *)((uintptr_t)__builtin_thread_pointer() +
>> + *offset);
>
> __builtin_thread_pointer doesn't work on all architectures/GCC versions.
> Is this a problem for selftests?
>
It's a problem as the test case is running on all architectures. I think I
need introduce our own __builtin_thread_pointer() for where it's not
supported: (1) PowerPC (2) x86 without GCC 11
Please let me know if I still have missed cases where __buitin_thread_pointer()
isn't supported?
Thanks,
Gavin
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-08-09 6:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 6:06 [PATCH 0/2] kvm/selftests: Two rseq_test fixes Gavin Shan
2022-08-09 6:06 ` [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35 Gavin Shan
2022-08-09 6:33 ` Florian Weimer
2022-08-09 8:45 ` Gavin Shan [this message]
2022-08-09 7:16 ` Florian Weimer
2022-08-09 9:27 ` Gavin Shan
2022-08-09 12:21 ` Mathieu Desnoyers
2022-08-09 13:44 ` Mathieu Desnoyers
2022-08-09 21:38 ` Sean Christopherson
2022-08-10 0:37 ` Gavin Shan
2022-08-10 12:29 ` Mathieu Desnoyers
2022-08-10 12:35 ` Paolo Bonzini
2022-08-10 12:13 ` Mathieu Desnoyers
2022-08-10 23:52 ` Gavin Shan
2022-08-10 9:14 ` Paolo Bonzini
2022-08-10 9:59 ` Gavin Shan
2022-08-10 12:17 ` Mathieu Desnoyers
2022-08-10 12:19 ` Paolo Bonzini
2022-08-10 23:34 ` Gavin Shan
2022-08-09 6:06 ` [PATCH 2/2] KVM: selftests: Use getcpu() instead of sched_getcpu() in rseq_test Gavin Shan
2022-08-09 6:35 ` Florian Weimer
2022-08-09 7:17 ` Florian Weimer
2022-08-09 8:46 ` Gavin Shan
2022-08-09 20:53 ` Sean Christopherson
2022-08-10 0:45 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7844e3fa-e49e-de75-e424-e82d3a023dd6@redhat.com \
--to=gshan@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=fweimer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=yihyu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).