From: Florian Weimer <fweimer@redhat.com>
To: Gavin Shan <gshan@redhat.com>
Cc: shan.gavin@gmail.com, kvm@vger.kernel.org, maz@kernel.org,
linux-kernel@vger.kernel.org, andrew.jones@linux.dev,
mathieu.desnoyers@efficios.com, yihyu@redhat.com,
linux-kselftest@vger.kernel.org, pbonzini@redhat.com,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 2/2] KVM: selftests: Use getcpu() instead of sched_getcpu() in rseq_test
Date: Tue, 09 Aug 2022 09:17:01 +0200 [thread overview]
Message-ID: <87mtcdnaxe.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87y1vxncv1.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Tue, 09 Aug 2022 08:35:14 +0200")
* Florian Weimer:
> * Gavin Shan:
>
>> sched_getcpu() is glibc dependent and it can simply return the CPU
>> ID from the registered rseq information, as Florian Weimer pointed.
>> In this case, it's pointless to compare the return value from
>> sched_getcpu() and that fetched from the registered rseq information.
>>
>> Fix the issue by replacing sched_getcpu() with getcpu(), as Florian
>> suggested. The comments are modified accordingly.
>
> Note that getcpu was added in glibc 2.29, so perhaps you need to perform
> a direct system call?
One more thing: syscall(__NR_getcpu) also has the advantage that it
wouldn't have to be changed again if node IDs become available via rseq
and getcpu is implemented using that.
Thanks,
Florian
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-08-09 10:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 6:06 [PATCH 0/2] kvm/selftests: Two rseq_test fixes Gavin Shan
2022-08-09 6:06 ` [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35 Gavin Shan
2022-08-09 6:33 ` Florian Weimer
2022-08-09 8:45 ` Gavin Shan
2022-08-09 7:16 ` Florian Weimer
2022-08-09 9:27 ` Gavin Shan
2022-08-09 12:21 ` Mathieu Desnoyers
2022-08-09 13:44 ` Mathieu Desnoyers
2022-08-09 21:38 ` Sean Christopherson
2022-08-10 0:37 ` Gavin Shan
2022-08-10 12:29 ` Mathieu Desnoyers
2022-08-10 12:35 ` Paolo Bonzini
2022-08-10 12:13 ` Mathieu Desnoyers
2022-08-10 23:52 ` Gavin Shan
2022-08-10 9:14 ` Paolo Bonzini
2022-08-10 9:59 ` Gavin Shan
2022-08-10 12:17 ` Mathieu Desnoyers
2022-08-10 12:19 ` Paolo Bonzini
2022-08-10 23:34 ` Gavin Shan
2022-08-09 6:06 ` [PATCH 2/2] KVM: selftests: Use getcpu() instead of sched_getcpu() in rseq_test Gavin Shan
2022-08-09 6:35 ` Florian Weimer
2022-08-09 7:17 ` Florian Weimer [this message]
2022-08-09 8:46 ` Gavin Shan
2022-08-09 20:53 ` Sean Christopherson
2022-08-10 0:45 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtcdnaxe.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=shan.gavin@gmail.com \
--cc=yihyu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).