From: Paolo Bonzini <pbonzini@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Gavin Shan <gshan@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
shan gavin <shan.gavin@gmail.com>, KVM list <kvm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
andrew jones <andrew.jones@linux.dev>, yihyu <yihyu@redhat.com>,
linux-kselftest <linux-kselftest@vger.kernel.org>,
maz <maz@kernel.org>, shuah <shuah@kernel.org>,
kvmarm <kvmarm@lists.cs.columbia.edu>
Subject: Re: [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35
Date: Wed, 10 Aug 2022 14:35:55 +0200 [thread overview]
Message-ID: <c95aec97-6fbd-dca5-6aa6-b8242d5a379a@redhat.com> (raw)
In-Reply-To: <1316061904.375.1660134559269.JavaMail.zimbra@efficios.com>
On 8/10/22 14:29, Mathieu Desnoyers wrote:
>> - By design, selftests/rseq and selftests/kvm are parallel. It's going to
>> introduce
>> unnecessary dependency for selftests/kvm to use selftests/rseq/librseq.so. To
>> me,
>> it makes the maintainability even harder.
> In terms of build system, yes, selftests/rseq and selftests/kvm are side-by-side,
> and I agree it is odd to have a cross-dependency.
>
> That's where moving rseq.c to tools/lib/ makes sense.
>
>> - What selftests/kvm needs is rseq-thread-pointer.h, which accounts for ~5% of
>> functionalities, provided by selftests/rseq/librseq.so.
> I've never seen this type of argument used to prevent using a library before, except
> on extremely memory-constrained devices, which is not our target here.
I agree.
To me, the main argument against moving librseq to tools/lib is a
variant of the build-system argument, namely that recursive Make
sucks[1] and selftests/kvm right now does not use tools/lib. So, for a
single-file library, it may be simply not worth the hassle.
On the other hand, if "somebody else" does the work, I would have no
problem with having selftests/kvm depend on tools/lib, not at all.
Thanks,
Paolo
[1] Kbuild is a marvel that makes it work, but it works because there
are no such cross-subdirectory dependencies and anyway
tools/testing/selftests does not use Kbuild.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-08-10 12:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 6:06 [PATCH 0/2] kvm/selftests: Two rseq_test fixes Gavin Shan
2022-08-09 6:06 ` [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35 Gavin Shan
2022-08-09 6:33 ` Florian Weimer
2022-08-09 8:45 ` Gavin Shan
2022-08-09 7:16 ` Florian Weimer
2022-08-09 9:27 ` Gavin Shan
2022-08-09 12:21 ` Mathieu Desnoyers
2022-08-09 13:44 ` Mathieu Desnoyers
2022-08-09 21:38 ` Sean Christopherson
2022-08-10 0:37 ` Gavin Shan
2022-08-10 12:29 ` Mathieu Desnoyers
2022-08-10 12:35 ` Paolo Bonzini [this message]
2022-08-10 12:13 ` Mathieu Desnoyers
2022-08-10 23:52 ` Gavin Shan
2022-08-10 9:14 ` Paolo Bonzini
2022-08-10 9:59 ` Gavin Shan
2022-08-10 12:17 ` Mathieu Desnoyers
2022-08-10 12:19 ` Paolo Bonzini
2022-08-10 23:34 ` Gavin Shan
2022-08-09 6:06 ` [PATCH 2/2] KVM: selftests: Use getcpu() instead of sched_getcpu() in rseq_test Gavin Shan
2022-08-09 6:35 ` Florian Weimer
2022-08-09 7:17 ` Florian Weimer
2022-08-09 8:46 ` Gavin Shan
2022-08-09 20:53 ` Sean Christopherson
2022-08-10 0:45 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c95aec97-6fbd-dca5-6aa6-b8242d5a379a@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=fweimer@redhat.com \
--cc=gshan@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=maz@kernel.org \
--cc=shan.gavin@gmail.com \
--cc=shuah@kernel.org \
--cc=yihyu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).