* [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" [not found] <20211212180527.1641362-1-AjitKumar.Pandey@amd.com> @ 2021-12-12 18:05 ` Ajit Kumar Pandey 2021-12-17 18:06 ` Rafael J. Wysocki 2021-12-12 18:05 ` [PATCH v5 3/5] ACPI: APD: Add a fmw property clk-name Ajit Kumar Pandey 1 sibling, 1 reply; 5+ messages in thread From: Ajit Kumar Pandey @ 2021-12-12 18:05 UTC (permalink / raw) To: sboyd, linux-clk Cc: Vijendar.Mukunda, Alexander.Deucher, Basavaraj.Hiregoudar, Sunil-kumar.Dommati, Mario.Limonciello, Ajit Kumar Pandey, Rafael J. Wysocki, Len Brown, open list:ACPI, open list Initially "is-rv" device property is added for 48MHz fixed clock support on Raven or RV architecture. It's unused now as we moved to pci device_id based selection to extend such support on other architectures. This change removed unused code from acpi driver. Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com> --- drivers/acpi/acpi_apd.c | 3 --- include/linux/platform_data/clk-fch.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 6e02448d15d9..6913e9712852 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data *pdata) if (ret < 0) return -ENOENT; - if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj)) - clk_data->is_rv = obj->integer.value; - list_for_each_entry(rentry, &resource_list, node) { clk_data->base = devm_ioremap(&adev->dev, rentry->res->start, resource_size(rentry->res)); diff --git a/include/linux/platform_data/clk-fch.h b/include/linux/platform_data/clk-fch.h index b9f682459f08..850ca776156d 100644 --- a/include/linux/platform_data/clk-fch.h +++ b/include/linux/platform_data/clk-fch.h @@ -12,7 +12,6 @@ struct fch_clk_data { void __iomem *base; - u32 is_rv; }; #endif /* __CLK_FCH_H */ -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" 2021-12-12 18:05 ` [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" Ajit Kumar Pandey @ 2021-12-17 18:06 ` Rafael J. Wysocki 2021-12-17 18:19 ` Limonciello, Mario 0 siblings, 1 reply; 5+ messages in thread From: Rafael J. Wysocki @ 2021-12-17 18:06 UTC (permalink / raw) To: Ajit Kumar Pandey Cc: Stephen Boyd, linux-clk, Vijendar.Mukunda, Alex Deucher, Basavaraj.Hiregoudar, Sunil-kumar.Dommati, Mario Limonciello, Rafael J. Wysocki, Len Brown, open list:ACPI, open list On Sun, Dec 12, 2021 at 7:06 PM Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> wrote: > > Initially "is-rv" device property is added for 48MHz fixed clock > support on Raven or RV architecture. It's unused now as we moved > to pci device_id based selection to extend such support on other > architectures. This change removed unused code from acpi driver. > > Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> > Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com> Does this or the next patch depend on the rest of the series, or can I simply apply them both? > --- > drivers/acpi/acpi_apd.c | 3 --- > include/linux/platform_data/clk-fch.h | 1 - > 2 files changed, 4 deletions(-) > > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c > index 6e02448d15d9..6913e9712852 100644 > --- a/drivers/acpi/acpi_apd.c > +++ b/drivers/acpi/acpi_apd.c > @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data *pdata) > if (ret < 0) > return -ENOENT; > > - if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj)) > - clk_data->is_rv = obj->integer.value; > - > list_for_each_entry(rentry, &resource_list, node) { > clk_data->base = devm_ioremap(&adev->dev, rentry->res->start, > resource_size(rentry->res)); > diff --git a/include/linux/platform_data/clk-fch.h b/include/linux/platform_data/clk-fch.h > index b9f682459f08..850ca776156d 100644 > --- a/include/linux/platform_data/clk-fch.h > +++ b/include/linux/platform_data/clk-fch.h > @@ -12,7 +12,6 @@ > > struct fch_clk_data { > void __iomem *base; > - u32 is_rv; > }; > > #endif /* __CLK_FCH_H */ > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" 2021-12-17 18:06 ` Rafael J. Wysocki @ 2021-12-17 18:19 ` Limonciello, Mario 2021-12-17 18:23 ` Rafael J. Wysocki 0 siblings, 1 reply; 5+ messages in thread From: Limonciello, Mario @ 2021-12-17 18:19 UTC (permalink / raw) To: Rafael J. Wysocki, Pandey, Ajit Kumar Cc: Stephen Boyd, linux-clk, Mukunda, Vijendar, Deucher, Alexander, Hiregoudar, Basavaraj, Dommati, Sunil-kumar, Len Brown, open list:ACPI, open list [Public] > -----Original Message----- > From: Rafael J. Wysocki <rafael@kernel.org> > Sent: Friday, December 17, 2021 12:07 > To: Pandey, Ajit Kumar <AjitKumar.Pandey@amd.com> > Cc: Stephen Boyd <sboyd@kernel.org>; linux-clk <linux-clk@vger.kernel.org>; > Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, Alexander > <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj > <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil- > kumar.Dommati@amd.com>; Limonciello, Mario > <Mario.Limonciello@amd.com>; Rafael J. Wysocki <rafael@kernel.org>; Len > Brown <lenb@kernel.org>; open list:ACPI <linux-acpi@vger.kernel.org>; open > list <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device > property "is-rv" > > On Sun, Dec 12, 2021 at 7:06 PM Ajit Kumar Pandey > <AjitKumar.Pandey@amd.com> wrote: > > > > Initially "is-rv" device property is added for 48MHz fixed clock > > support on Raven or RV architecture. It's unused now as we moved > > to pci device_id based selection to extend such support on other > > architectures. This change removed unused code from acpi driver. > > > > Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> > > Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com> > > Does this or the next patch depend on the rest of the series, or can I > simply apply them both? There are (intentional) dependencies within this series on the order. It would be better for the whole series to come through one tree. > > > --- > > drivers/acpi/acpi_apd.c | 3 --- > > include/linux/platform_data/clk-fch.h | 1 - > > 2 files changed, 4 deletions(-) > > > > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c > > index 6e02448d15d9..6913e9712852 100644 > > --- a/drivers/acpi/acpi_apd.c > > +++ b/drivers/acpi/acpi_apd.c > > @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data > *pdata) > > if (ret < 0) > > return -ENOENT; > > > > - if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj)) > > - clk_data->is_rv = obj->integer.value; > > - > > list_for_each_entry(rentry, &resource_list, node) { > > clk_data->base = devm_ioremap(&adev->dev, rentry->res->start, > > resource_size(rentry->res)); > > diff --git a/include/linux/platform_data/clk-fch.h > b/include/linux/platform_data/clk-fch.h > > index b9f682459f08..850ca776156d 100644 > > --- a/include/linux/platform_data/clk-fch.h > > +++ b/include/linux/platform_data/clk-fch.h > > @@ -12,7 +12,6 @@ > > > > struct fch_clk_data { > > void __iomem *base; > > - u32 is_rv; > > }; > > > > #endif /* __CLK_FCH_H */ > > -- > > 2.25.1 > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" 2021-12-17 18:19 ` Limonciello, Mario @ 2021-12-17 18:23 ` Rafael J. Wysocki 0 siblings, 0 replies; 5+ messages in thread From: Rafael J. Wysocki @ 2021-12-17 18:23 UTC (permalink / raw) To: Limonciello, Mario Cc: Rafael J. Wysocki, Pandey, Ajit Kumar, Stephen Boyd, linux-clk, Mukunda, Vijendar, Deucher, Alexander, Hiregoudar, Basavaraj, Dommati, Sunil-kumar, Len Brown, open list:ACPI, open list On Fri, Dec 17, 2021 at 7:19 PM Limonciello, Mario <Mario.Limonciello@amd.com> wrote: > > [Public] > > > -----Original Message----- > > From: Rafael J. Wysocki <rafael@kernel.org> > > Sent: Friday, December 17, 2021 12:07 > > To: Pandey, Ajit Kumar <AjitKumar.Pandey@amd.com> > > Cc: Stephen Boyd <sboyd@kernel.org>; linux-clk <linux-clk@vger.kernel.org>; > > Mukunda, Vijendar <Vijendar.Mukunda@amd.com>; Deucher, Alexander > > <Alexander.Deucher@amd.com>; Hiregoudar, Basavaraj > > <Basavaraj.Hiregoudar@amd.com>; Dommati, Sunil-kumar <Sunil- > > kumar.Dommati@amd.com>; Limonciello, Mario > > <Mario.Limonciello@amd.com>; Rafael J. Wysocki <rafael@kernel.org>; Len > > Brown <lenb@kernel.org>; open list:ACPI <linux-acpi@vger.kernel.org>; open > > list <linux-kernel@vger.kernel.org> > > Subject: Re: [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device > > property "is-rv" > > > > On Sun, Dec 12, 2021 at 7:06 PM Ajit Kumar Pandey > > <AjitKumar.Pandey@amd.com> wrote: > > > > > > Initially "is-rv" device property is added for 48MHz fixed clock > > > support on Raven or RV architecture. It's unused now as we moved > > > to pci device_id based selection to extend such support on other > > > architectures. This change removed unused code from acpi driver. > > > > > > Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> > > > Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com> > > > > Does this or the next patch depend on the rest of the series, or can I > > simply apply them both? > > There are (intentional) dependencies within this series on the order. It > would be better for the whole series to come through one tree. So please route these two along with the rest of the series and I don't think you need my ACKs for this. > > > > > > --- > > > drivers/acpi/acpi_apd.c | 3 --- > > > include/linux/platform_data/clk-fch.h | 1 - > > > 2 files changed, 4 deletions(-) > > > > > > diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c > > > index 6e02448d15d9..6913e9712852 100644 > > > --- a/drivers/acpi/acpi_apd.c > > > +++ b/drivers/acpi/acpi_apd.c > > > @@ -87,9 +87,6 @@ static int fch_misc_setup(struct apd_private_data > > *pdata) > > > if (ret < 0) > > > return -ENOENT; > > > > > > - if (!acpi_dev_get_property(adev, "is-rv", ACPI_TYPE_INTEGER, &obj)) > > > - clk_data->is_rv = obj->integer.value; > > > - > > > list_for_each_entry(rentry, &resource_list, node) { > > > clk_data->base = devm_ioremap(&adev->dev, rentry->res->start, > > > resource_size(rentry->res)); > > > diff --git a/include/linux/platform_data/clk-fch.h > > b/include/linux/platform_data/clk-fch.h > > > index b9f682459f08..850ca776156d 100644 > > > --- a/include/linux/platform_data/clk-fch.h > > > +++ b/include/linux/platform_data/clk-fch.h > > > @@ -12,7 +12,6 @@ > > > > > > struct fch_clk_data { > > > void __iomem *base; > > > - u32 is_rv; > > > }; > > > > > > #endif /* __CLK_FCH_H */ > > > -- > > > 2.25.1 > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v5 3/5] ACPI: APD: Add a fmw property clk-name [not found] <20211212180527.1641362-1-AjitKumar.Pandey@amd.com> 2021-12-12 18:05 ` [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" Ajit Kumar Pandey @ 2021-12-12 18:05 ` Ajit Kumar Pandey 1 sibling, 0 replies; 5+ messages in thread From: Ajit Kumar Pandey @ 2021-12-12 18:05 UTC (permalink / raw) To: sboyd, linux-clk Cc: Vijendar.Mukunda, Alexander.Deucher, Basavaraj.Hiregoudar, Sunil-kumar.Dommati, Mario.Limonciello, Ajit Kumar Pandey, Rafael J. Wysocki, Len Brown, open list:ACPI, open list Add a new device property to fetch clk-name from firmware. Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com> Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com> --- drivers/acpi/acpi_apd.c | 10 ++++++++++ include/linux/platform_data/clk-fch.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 6913e9712852..2b958b426b03 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -87,6 +87,16 @@ static int fch_misc_setup(struct apd_private_data *pdata) if (ret < 0) return -ENOENT; + if (!acpi_dev_get_property(adev, "clk-name", ACPI_TYPE_STRING, &obj)) { + clk_data->name = devm_kzalloc(&adev->dev, obj->string.length, + GFP_KERNEL); + + strcpy(clk_data->name, obj->string.pointer); + } else { + /* Set default name to mclk if entry missing in firmware */ + clk_data->name = "mclk"; + } + list_for_each_entry(rentry, &resource_list, node) { clk_data->base = devm_ioremap(&adev->dev, rentry->res->start, resource_size(rentry->res)); diff --git a/include/linux/platform_data/clk-fch.h b/include/linux/platform_data/clk-fch.h index 850ca776156d..11a2a23fd9b2 100644 --- a/include/linux/platform_data/clk-fch.h +++ b/include/linux/platform_data/clk-fch.h @@ -12,6 +12,7 @@ struct fch_clk_data { void __iomem *base; + char *name; }; #endif /* __CLK_FCH_H */ -- 2.25.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-17 18:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20211212180527.1641362-1-AjitKumar.Pandey@amd.com>
2021-12-12 18:05 ` [PATCH v5 2/5] drivers: acpi: acpi_apd: Remove unused device property "is-rv" Ajit Kumar Pandey
2021-12-17 18:06 ` Rafael J. Wysocki
2021-12-17 18:19 ` Limonciello, Mario
2021-12-17 18:23 ` Rafael J. Wysocki
2021-12-12 18:05 ` [PATCH v5 3/5] ACPI: APD: Add a fmw property clk-name Ajit Kumar Pandey
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).