* Re: [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types
[not found] ` <20200505111810.65586-2-malattia@linux.it>
@ 2020-05-05 12:27 ` Andy Shevchenko
2020-05-09 9:15 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2020-05-05 12:27 UTC (permalink / raw)
To: Mattia Dongili, Schmauss, Erik, ACPI Devel Maling List,
Rafael J. Wysocki
Cc: Darren Hart, Andy Shevchenko, Platform Driver,
Dominik Mierzejewski, William Bader
+Cc ACPI(CA) people
On Tue, May 5, 2020 at 1:16 PM <malattia@linux.it> wrote:
> After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> objects for ASL create_field() operator") ACPICA creates buffers even
> when new fields are small enough to fit into an integer.
> Many SNC calls counted on the old behaviour.
Rafael, Erik, is it correct behaviour from ACPICA p.o.v. nowadays or
should be fixed rather there?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types
2020-05-05 12:27 ` [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types Andy Shevchenko
@ 2020-05-09 9:15 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-05-09 9:15 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Mattia Dongili, Schmauss, Erik, ACPI Devel Maling List,
Rafael J. Wysocki, Darren Hart, Andy Shevchenko, Platform Driver,
Dominik Mierzejewski, William Bader
On Tuesday, May 5, 2020 2:27:15 PM CEST Andy Shevchenko wrote:
> +Cc ACPI(CA) people
>
> On Tue, May 5, 2020 at 1:16 PM <malattia@linux.it> wrote:
> > After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> > objects for ASL create_field() operator") ACPICA creates buffers even
> > when new fields are small enough to fit into an integer.
>
> > Many SNC calls counted on the old behaviour.
>
> Rafael, Erik, is it correct behaviour from ACPICA p.o.v. nowadays or
> should be fixed rather there?
The new behavior is correct and it is needed to avoid other failures elsewhere.
Unfortunately, all of the call sites assuming that the conversion will happen
need to be fixed.
Cheers!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-09 9:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200505111810.65586-1-malattia@linux.it>
[not found] ` <20200505111810.65586-2-malattia@linux.it>
2020-05-05 12:27 ` [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types Andy Shevchenko
2020-05-09 9:15 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).