* [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration
@ 2022-09-11 9:45 Gaosheng Cui
2022-09-13 22:41 ` Bjorn Helgaas
0 siblings, 1 reply; 4+ messages in thread
From: Gaosheng Cui @ 2022-09-11 9:45 UTC (permalink / raw)
To: rafael.j.wysocki, bjorn.helgaas, rene.herman, len.brown, cuigaosheng1
Cc: linux-acpi
pnpid32_to_pnpid() has been removed since
commit 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"),
so remove it.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/pnp/pnpbios/pnpbios.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h
index 2ce739ff9c1a..f3302006842e 100644
--- a/drivers/pnp/pnpbios/pnpbios.h
+++ b/drivers/pnp/pnpbios/pnpbios.h
@@ -153,7 +153,6 @@ extern int pnpbios_dont_use_current_config;
extern int pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node * node);
extern int pnpbios_read_resources_from_node(struct pnp_dev *dev, struct pnp_bios_node *node);
extern int pnpbios_write_resources_to_node(struct pnp_dev *dev, struct pnp_bios_node *node);
-extern void pnpid32_to_pnpid(u32 id, char *str);
extern void pnpbios_print_status(const char * module, u16 status);
extern void pnpbios_calls_init(union pnp_bios_install_struct * header);
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration
2022-09-11 9:45 [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration Gaosheng Cui
@ 2022-09-13 22:41 ` Bjorn Helgaas
2022-09-14 1:41 ` cuigaosheng
2022-09-24 16:08 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Bjorn Helgaas @ 2022-09-13 22:41 UTC (permalink / raw)
To: Gaosheng Cui
Cc: rafael.j.wysocki, bjorn.helgaas, rene.herman, len.brown, linux-acpi
On Sun, Sep 11, 2022 at 05:45:35PM +0800, Gaosheng Cui wrote:
> pnpid32_to_pnpid() has been removed since
> commit 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"),
> so remove it.
Woof, I guess I messed that up, sorry :(
I would word the commit log as:
All uses of pnpid32_to_pnpid() were removed by 25eb846189d2 ("PNP:
add pnp_eisa_id_to_string()"), so remove the declaration, too.
Regardless,
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> drivers/pnp/pnpbios/pnpbios.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h
> index 2ce739ff9c1a..f3302006842e 100644
> --- a/drivers/pnp/pnpbios/pnpbios.h
> +++ b/drivers/pnp/pnpbios/pnpbios.h
> @@ -153,7 +153,6 @@ extern int pnpbios_dont_use_current_config;
> extern int pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node * node);
> extern int pnpbios_read_resources_from_node(struct pnp_dev *dev, struct pnp_bios_node *node);
> extern int pnpbios_write_resources_to_node(struct pnp_dev *dev, struct pnp_bios_node *node);
> -extern void pnpid32_to_pnpid(u32 id, char *str);
>
> extern void pnpbios_print_status(const char * module, u16 status);
> extern void pnpbios_calls_init(union pnp_bios_install_struct * header);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration
2022-09-13 22:41 ` Bjorn Helgaas
@ 2022-09-14 1:41 ` cuigaosheng
2022-09-24 16:08 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: cuigaosheng @ 2022-09-14 1:41 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: rafael.j.wysocki, bjorn.helgaas, rene.herman, len.brown, linux-acpi
> I would word the commit log as:
>
> All uses of pnpid32_to_pnpid() were removed by 25eb846189d2 ("PNP:
> add pnp_eisa_id_to_string()"), so remove the declaration, too.
>
> Regardless,
>
> Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Thanks for taking the time to review this patch, I have made a patch v2 and submitted it.
link: https://patchwork.kernel.org/project/linux-acpi/patch/20220914013317.1135178-1-cuigaosheng1@huawei.com/
在 2022/9/14 6:41, Bjorn Helgaas 写道:
> On Sun, Sep 11, 2022 at 05:45:35PM +0800, Gaosheng Cui wrote:
>> pnpid32_to_pnpid() has been removed since
>> commit 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"),
>> so remove it.
> Woof, I guess I messed that up, sorry :(
>
> I would word the commit log as:
>
> All uses of pnpid32_to_pnpid() were removed by 25eb846189d2 ("PNP:
> add pnp_eisa_id_to_string()"), so remove the declaration, too.
>
> Regardless,
>
> Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
>
>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
>> ---
>> drivers/pnp/pnpbios/pnpbios.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h
>> index 2ce739ff9c1a..f3302006842e 100644
>> --- a/drivers/pnp/pnpbios/pnpbios.h
>> +++ b/drivers/pnp/pnpbios/pnpbios.h
>> @@ -153,7 +153,6 @@ extern int pnpbios_dont_use_current_config;
>> extern int pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node * node);
>> extern int pnpbios_read_resources_from_node(struct pnp_dev *dev, struct pnp_bios_node *node);
>> extern int pnpbios_write_resources_to_node(struct pnp_dev *dev, struct pnp_bios_node *node);
>> -extern void pnpid32_to_pnpid(u32 id, char *str);
>>
>> extern void pnpbios_print_status(const char * module, u16 status);
>> extern void pnpbios_calls_init(union pnp_bios_install_struct * header);
>> --
>> 2.25.1
>>
> .
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration
2022-09-13 22:41 ` Bjorn Helgaas
2022-09-14 1:41 ` cuigaosheng
@ 2022-09-24 16:08 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2022-09-24 16:08 UTC (permalink / raw)
To: Bjorn Helgaas, Gaosheng Cui
Cc: Rafael Wysocki, bjorn.helgaas, rene.herman, Len Brown,
ACPI Devel Maling List
On Wed, Sep 14, 2022 at 12:41 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> On Sun, Sep 11, 2022 at 05:45:35PM +0800, Gaosheng Cui wrote:
> > pnpid32_to_pnpid() has been removed since
> > commit 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"),
> > so remove it.
>
> Woof, I guess I messed that up, sorry :(
>
> I would word the commit log as:
>
> All uses of pnpid32_to_pnpid() were removed by 25eb846189d2 ("PNP:
> add pnp_eisa_id_to_string()"), so remove the declaration, too.
>
> Regardless,
>
> Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Applied as 6.1 material, thanks!
> > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> > ---
> > drivers/pnp/pnpbios/pnpbios.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h
> > index 2ce739ff9c1a..f3302006842e 100644
> > --- a/drivers/pnp/pnpbios/pnpbios.h
> > +++ b/drivers/pnp/pnpbios/pnpbios.h
> > @@ -153,7 +153,6 @@ extern int pnpbios_dont_use_current_config;
> > extern int pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node * node);
> > extern int pnpbios_read_resources_from_node(struct pnp_dev *dev, struct pnp_bios_node *node);
> > extern int pnpbios_write_resources_to_node(struct pnp_dev *dev, struct pnp_bios_node *node);
> > -extern void pnpid32_to_pnpid(u32 id, char *str);
> >
> > extern void pnpbios_print_status(const char * module, u16 status);
> > extern void pnpbios_calls_init(union pnp_bios_install_struct * header);
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-24 16:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-11 9:45 [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration Gaosheng Cui
2022-09-13 22:41 ` Bjorn Helgaas
2022-09-14 1:41 ` cuigaosheng
2022-09-24 16:08 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).