* [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
@ 2019-03-04 10:49 Neil Armstrong
2019-03-05 22:02 ` Martin Blumenstingl
2019-03-20 10:35 ` Philipp Zabel
0 siblings, 2 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-03-04 10:49 UTC (permalink / raw)
To: p.zabel
Cc: devicetree, linux-amlogic, linux-kernel, linux-arm-kernel,
Neil Armstrong
The G12A Documentation lacked these 2 reset lines, but they are present and
used for each USB 2 PHYs.
Add them to the dt-bindings for the upcoming USB support.
Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
index 8063e8314eef..6d487c5eba2c 100644
--- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
+++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
@@ -51,7 +51,10 @@
#define RESET_SD_EMMC_A 44
#define RESET_SD_EMMC_B 45
#define RESET_SD_EMMC_C 46
-/* 47-60 */
+/* 47 */
+#define RESET_USB_PHY20 48
+#define RESET_USB_PHY21 49
+/* 50-60 */
#define RESET_AUDIO_CODEC 61
/* 62-63 */
/* RESET2 */
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
2019-03-04 10:49 [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets Neil Armstrong
@ 2019-03-05 22:02 ` Martin Blumenstingl
2019-03-07 12:23 ` Neil Armstrong
2019-03-20 10:35 ` Philipp Zabel
1 sibling, 1 reply; 6+ messages in thread
From: Martin Blumenstingl @ 2019-03-05 22:02 UTC (permalink / raw)
To: Neil Armstrong
Cc: linux-arm-kernel, devicetree, linux-kernel, p.zabel, linux-amlogic
On Mon, Mar 4, 2019 at 11:49 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> The G12A Documentation lacked these 2 reset lines, but they are present and
> used for each USB 2 PHYs.
>
> Add them to the dt-bindings for the upcoming USB support.
>
> Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> index 8063e8314eef..6d487c5eba2c 100644
> --- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> +++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> @@ -51,7 +51,10 @@
> #define RESET_SD_EMMC_A 44
> #define RESET_SD_EMMC_B 45
> #define RESET_SD_EMMC_C 46
> -/* 47-60 */
> +/* 47 */
> +#define RESET_USB_PHY20 48
> +#define RESET_USB_PHY21 49
because it's always hard to look up, here's the reference to that
information Amlogic's buildroot kernel
(buildroot_openlinux_kernel_4.9_fbdev_20180706):
kernel/aml-4.9/drivers/amlogic/usb/phy/phy-aml-new-usb2-v2.c uses:
writel((val | (0x3 << 16)), (void __iomem *) ((unsigned
long)phy->reset_regs + (0x21 * 4 - 0x8)));
this translates to:
- (0x21 * 4 - 0x8) = RESET1 register / reset line ID 32 and above
(reset line 0 is at "0x20 * 4 - 0x08")
- bits 16 and 17 = add 32 to that gives us reset IDs 48 and 49
Regards
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
2019-03-05 22:02 ` Martin Blumenstingl
@ 2019-03-07 12:23 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2019-03-07 12:23 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: linux-arm-kernel, devicetree, linux-kernel, p.zabel, linux-amlogic
On 05/03/2019 23:02, Martin Blumenstingl wrote:
> On Mon, Mar 4, 2019 at 11:49 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> The G12A Documentation lacked these 2 reset lines, but they are present and
>> used for each USB 2 PHYs.
>>
>> Add them to the dt-bindings for the upcoming USB support.
>>
>> Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>> ---
>> include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> index 8063e8314eef..6d487c5eba2c 100644
>> --- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> +++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> @@ -51,7 +51,10 @@
>> #define RESET_SD_EMMC_A 44
>> #define RESET_SD_EMMC_B 45
>> #define RESET_SD_EMMC_C 46
>> -/* 47-60 */
>> +/* 47 */
>> +#define RESET_USB_PHY20 48
>> +#define RESET_USB_PHY21 49
> because it's always hard to look up, here's the reference to that
> information Amlogic's buildroot kernel
> (buildroot_openlinux_kernel_4.9_fbdev_20180706):
> kernel/aml-4.9/drivers/amlogic/usb/phy/phy-aml-new-usb2-v2.c uses:
> writel((val | (0x3 << 16)), (void __iomem *) ((unsigned
> long)phy->reset_regs + (0x21 * 4 - 0x8)));
>
> this translates to:
> - (0x21 * 4 - 0x8) = RESET1 register / reset line ID 32 and above
> (reset line 0 is at "0x20 * 4 - 0x08")
> - bits 16 and 17 = add 32 to that gives us reset IDs 48 and 49
Exactly, thanks for pointing this !
Neil
>
>
> Regards
> Martin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
2019-03-04 10:49 [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets Neil Armstrong
2019-03-05 22:02 ` Martin Blumenstingl
@ 2019-03-20 10:35 ` Philipp Zabel
2019-03-22 22:53 ` Kevin Hilman
1 sibling, 1 reply; 6+ messages in thread
From: Philipp Zabel @ 2019-03-20 10:35 UTC (permalink / raw)
To: Neil Armstrong; +Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
On Mon, 2019-03-04 at 11:49 +0100, Neil Armstrong wrote:
> The G12A Documentation lacked these 2 reset lines, but they are present and
> used for each USB 2 PHYs.
>
> Add them to the dt-bindings for the upcoming USB support.
>
> Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> index 8063e8314eef..6d487c5eba2c 100644
> --- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> +++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
> @@ -51,7 +51,10 @@
> #define RESET_SD_EMMC_A 44
> #define RESET_SD_EMMC_B 45
> #define RESET_SD_EMMC_C 46
> -/* 47-60 */
> +/* 47 */
> +#define RESET_USB_PHY20 48
> +#define RESET_USB_PHY21 49
> +/* 50-60 */
> #define RESET_AUDIO_CODEC 61
> /* 62-63 */
> /* RESET2 */
Thank you, applied to reset/fixes with Martin's review tag.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
2019-03-20 10:35 ` Philipp Zabel
@ 2019-03-22 22:53 ` Kevin Hilman
2019-03-26 11:33 ` Philipp Zabel
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2019-03-22 22:53 UTC (permalink / raw)
To: Philipp Zabel, Neil Armstrong
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
Hi Philip,
Philipp Zabel <p.zabel@pengutronix.de> writes:
> On Mon, 2019-03-04 at 11:49 +0100, Neil Armstrong wrote:
>> The G12A Documentation lacked these 2 reset lines, but they are present and
>> used for each USB 2 PHYs.
>>
>> Add them to the dt-bindings for the upcoming USB support.
>>
>> Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> include/dt-bindings/reset/amlogic,meson-g12a-reset.h | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> index 8063e8314eef..6d487c5eba2c 100644
>> --- a/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> +++ b/include/dt-bindings/reset/amlogic,meson-g12a-reset.h
>> @@ -51,7 +51,10 @@
>> #define RESET_SD_EMMC_A 44
>> #define RESET_SD_EMMC_B 45
>> #define RESET_SD_EMMC_C 46
>> -/* 47-60 */
>> +/* 47 */
>> +#define RESET_USB_PHY20 48
>> +#define RESET_USB_PHY21 49
>> +/* 50-60 */
>> #define RESET_AUDIO_CODEC 61
>> /* 62-63 */
>> /* RESET2 */
>
> Thank you, applied to reset/fixes with Martin's review tag.
Could ou make a immtable tag for this in your tree? This is needed for
some upcoming DT users we'd like to queue for the next cycle.
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets
2019-03-22 22:53 ` Kevin Hilman
@ 2019-03-26 11:33 ` Philipp Zabel
0 siblings, 0 replies; 6+ messages in thread
From: Philipp Zabel @ 2019-03-26 11:33 UTC (permalink / raw)
To: Kevin Hilman, Neil Armstrong
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
Hi Kevin,
On Fri, 2019-03-22 at 15:53 -0700, Kevin Hilman wrote:
[...]
> Could ou make a immtable tag for this in your tree? This is needed for
> some upcoming DT users we'd like to queue for the next cycle.
I have just sent a reset/fixes pull request including this patch.
Once that gets merged, you can either wait for the next -rc that
includes it or pull in
git://git.pengutronix.de/pza/linux reset/meson-g12a
which is just the first patch of the two.
regards
Philipp
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-26 11:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 10:49 [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets Neil Armstrong
2019-03-05 22:02 ` Martin Blumenstingl
2019-03-07 12:23 ` Neil Armstrong
2019-03-20 10:35 ` Philipp Zabel
2019-03-22 22:53 ` Kevin Hilman
2019-03-26 11:33 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).