* [RFC PATCH 0/2] add support for videostrong KII Pro
@ 2019-11-15 16:50 Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box Mohammad Rasim
0 siblings, 2 replies; 7+ messages in thread
From: Mohammad Rasim @ 2019-11-15 16:50 UTC (permalink / raw)
To: Kevin Hilman, linux-amlogic, Neil Armstrong; +Cc: Mohammad Rasim
Mohammad Rasim (2):
Add entry for BCM4335A0 UART bluetooth
Add support for Videostrong KII Pro tv box
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-gxbb-KII-Pro.dts | 25 +++++++++++++++++++
drivers/bluetooth/btbcm.c | 1 +
drivers/bluetooth/hci_bcm.c | 1 +
4 files changed, 28 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
--
2.23.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth
2019-11-15 16:50 [RFC PATCH 0/2] add support for videostrong KII Pro Mohammad Rasim
@ 2019-11-15 16:50 ` Mohammad Rasim
2019-11-16 9:43 ` Andreas Färber
2019-11-15 16:50 ` [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box Mohammad Rasim
1 sibling, 1 reply; 7+ messages in thread
From: Mohammad Rasim @ 2019-11-15 16:50 UTC (permalink / raw)
To: Kevin Hilman, linux-amlogic, Neil Armstrong, linux-bluetooth,
Johan Hedberg, Marcel Holtmann
Cc: Mohammad Rasim
Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
---
drivers/bluetooth/btbcm.c | 1 +
drivers/bluetooth/hci_bcm.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 2d2e6d862068..22464bf8cda3 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -339,6 +339,7 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
{ 0x220e, "BCM20702A1" }, /* 001.002.014 */
{ 0x4217, "BCM4329B1" }, /* 002.002.023 */
{ 0x6106, "BCM4359C0" }, /* 003.001.006 */
+ { 0x4106, "BCM4335A0" }, /* 002.001.006 */
{ }
};
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 7646636f2d18..7b4bb5dbea1d 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1422,6 +1422,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm4345c5" },
{ .compatible = "brcm,bcm4330-bt" },
{ .compatible = "brcm,bcm43438-bt" },
+ { .compatible = "brcm,bcm4335A0" },
{ },
};
MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
--
2.23.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box
2019-11-15 16:50 [RFC PATCH 0/2] add support for videostrong KII Pro Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
@ 2019-11-15 16:50 ` Mohammad Rasim
2019-11-16 9:53 ` Andreas Färber
1 sibling, 1 reply; 7+ messages in thread
From: Mohammad Rasim @ 2019-11-15 16:50 UTC (permalink / raw)
To: Kevin Hilman, linux-amlogic, Neil Armstrong, Rob Herring, devicetree
Cc: Mohammad Rasim
This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design
Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
---
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-gxbb-KII-Pro.dts | 25 +++++++++++++++++++
2 files changed, 26 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 84afecba9ec0..1d72e93691f2 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -11,6 +11,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-p200.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-p201.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-KII-Pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-meta.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-telos.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
new file mode 100644
index 000000000000..e79d75bfa8dd
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p201.dts"
+
+/ {
+ compatible = "Videostrong,KII-Pro","amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+ model = "Videostrong KII Pro";
+
+
+};
+
+&uart_A {
+ status = "okay";
+ pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+ pinctrl-names = "default";
+ uart-has-rtscts;
+ bluetooth {
+ compatible = "brcm,bcm4335A0";
+ shutdown-gpios = <&gpio GPIOX_20 GPIO_ACTIVE_HIGH>;
+ };
+};
--
2.23.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth
2019-11-15 16:50 ` [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
@ 2019-11-16 9:43 ` Andreas Färber
2019-11-18 17:35 ` Mohammad Rasim
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2019-11-16 9:43 UTC (permalink / raw)
To: Mohammad Rasim, Kevin Hilman, linux-amlogic, Neil Armstrong,
linux-bluetooth, Johan Hedberg, Marcel Holtmann
Am 15.11.19 um 17:50 schrieb Mohammad Rasim:
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
Lacking a commit description. Please add a sentence.
> ---
> drivers/bluetooth/btbcm.c | 1 +
> drivers/bluetooth/hci_bcm.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 2d2e6d862068..22464bf8cda3 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -339,6 +339,7 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
> { 0x220e, "BCM20702A1" }, /* 001.002.014 */
> { 0x4217, "BCM4329B1" }, /* 002.002.023 */
> { 0x6106, "BCM4359C0" }, /* 003.001.006 */
> + { 0x4106, "BCM4335A0" }, /* 002.001.006 */
> { }
> };
Beyond this patch: There appears to be no order in this table at all?
Not alphabetically, not numerically, not by comment.
>
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index 7646636f2d18..7b4bb5dbea1d 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1422,6 +1422,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
> { .compatible = "brcm,bcm4345c5" },
> { .compatible = "brcm,bcm4330-bt" },
> { .compatible = "brcm,bcm43438-bt" },
> + { .compatible = "brcm,bcm4335A0" },
You can't use compatible strings without defining the binding first. Why
do you need it? If you do, use lowercase names.
> { },
> };
> MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box
2019-11-15 16:50 ` [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box Mohammad Rasim
@ 2019-11-16 9:53 ` Andreas Färber
2019-11-16 10:28 ` Martin Blumenstingl
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2019-11-16 9:53 UTC (permalink / raw)
To: Mohammad Rasim
Cc: Kevin Hilman, devicetree, Neil Armstrong, Rob Herring, linux-amlogic
Am 15.11.19 um 17:50 schrieb Mohammad Rasim:
> This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design
>
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../boot/dts/amlogic/meson-gxbb-KII-Pro.dts | 25 +++++++++++++++++++
> 2 files changed, 26 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 84afecba9ec0..1d72e93691f2 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -11,6 +11,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-p200.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-p201.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-KII-Pro.dtb
Lowercase: -kii-pro.dtb
And please sort alphabetically.
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-pro.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-meta.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-vega-s95-telos.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
> new file mode 100644
> index 000000000000..e79d75bfa8dd
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-KII-Pro.dts
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + */
What is this? :) You may want to add a copyright here.
> +
> +/dts-v1/;
> +
> +#include "meson-gxbb-p201.dts"
This is rather unusual, normally you would include the SoC's .dtsi, not
another board.
> +
> +/ {
> + compatible = "Videostrong,KII-Pro","amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
This is not a valid vendor prefix (undefined, should be lowercase), same
for the compatible string, which should be lowercase as all others.
Please run ./scripts/checkpatch.pl, which would warn you of such issues.
Also a space missing after comma.
> + model = "Videostrong KII Pro";
Here you can spell it the original way, like you did.
> +
> +
> +};
> +
> +&uart_A {
> + status = "okay";
> + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
> + pinctrl-names = "default";
> + uart-has-rtscts;
Leave an empty line here for spacing.
> + bluetooth {
> + compatible = "brcm,bcm4335A0";
> + shutdown-gpios = <&gpio GPIOX_20 GPIO_ACTIVE_HIGH>;
> + };
> +};
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box
2019-11-16 9:53 ` Andreas Färber
@ 2019-11-16 10:28 ` Martin Blumenstingl
0 siblings, 0 replies; 7+ messages in thread
From: Martin Blumenstingl @ 2019-11-16 10:28 UTC (permalink / raw)
To: Mohammad Rasim
Cc: devicetree, Neil Armstrong, Kevin Hilman, Rob Herring,
linux-amlogic, Andreas Färber
Hi Mohammad,
On Sat, Nov 16, 2019 at 10:53 AM Andreas Färber <afaerber@suse.de> wrote:
[...]
> > +
> > +/dts-v1/;
> > +
> > +#include "meson-gxbb-p201.dts"
>
> This is rather unusual, normally you would include the SoC's .dtsi, not
> another board.
you may even get another benefit from this:
we don't know the Ethernet PHY setup on the P201 board (because nobody
has an actual P201 board) so we don't use interrupts etc.
however, since you do have a access to your KII Pro you can do better
than P201 and define the Ethernet bits similar to Odroid-C2 for
example: [0]
if you board doesn't use a Realtek RTL8211F PHY then please also
update the comment in the Ethmac node
testing the PHY interrupt (which means less polling -> your CPU has
more time to do other things) is easy:
* cat /proc/interrupts
* unplug and re-plug the Ethernet cable
* cat /proc/interrupts again and check the Ethernet PHY interrupt
(should be +2 compared to the first invocation)
Martin
[0] https://github.com/torvalds/linux/blob/f9717178b9be9477877d4c3776c61ff56d854ddf/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts#L122
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth
2019-11-16 9:43 ` Andreas Färber
@ 2019-11-18 17:35 ` Mohammad Rasim
0 siblings, 0 replies; 7+ messages in thread
From: Mohammad Rasim @ 2019-11-18 17:35 UTC (permalink / raw)
To: Andreas Färber
Cc: Johan Hedberg, Neil Armstrong, Kevin Hilman, Marcel Holtmann,
linux-bluetooth, linux-amlogic
On 19/11/16 10:43AM, Andreas Färber wrote:
> Am 15.11.19 um 17:50 schrieb Mohammad Rasim:
> > Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
>
> Lacking a commit description. Please add a sentence.
>
> > ---
> > drivers/bluetooth/btbcm.c | 1 +
> > drivers/bluetooth/hci_bcm.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> > index 2d2e6d862068..22464bf8cda3 100644
> > --- a/drivers/bluetooth/btbcm.c
> > +++ b/drivers/bluetooth/btbcm.c
> > @@ -339,6 +339,7 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
> > { 0x220e, "BCM20702A1" }, /* 001.002.014 */
> > { 0x4217, "BCM4329B1" }, /* 002.002.023 */
> > { 0x6106, "BCM4359C0" }, /* 003.001.006 */
> > + { 0x4106, "BCM4335A0" }, /* 002.001.006 */
> > { }
> > };
>
> Beyond this patch: There appears to be no order in this table at all?
> Not alphabetically, not numerically, not by comment.
>
> >
> > diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> > index 7646636f2d18..7b4bb5dbea1d 100644
> > --- a/drivers/bluetooth/hci_bcm.c
> > +++ b/drivers/bluetooth/hci_bcm.c
> > @@ -1422,6 +1422,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
> > { .compatible = "brcm,bcm4345c5" },
> > { .compatible = "brcm,bcm4330-bt" },
> > { .compatible = "brcm,bcm43438-bt" },
> > + { .compatible = "brcm,bcm4335A0" },
>
> You can't use compatible strings without defining the binding first. Why
> do you need it? If you do, use lowercase names.
>
I don't really need it per se, I can use any compatible (i've used bcm43438-bt before) but I thought I'd add a compatible so that the device dts can describe the exact model of the module, if that is ok I will update the broadcom-bluetooth.txt binding in the next version
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
>
> Regards,
> Andreas
>
> --
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer
> HRB 36809 (AG Nürnberg)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-18 17:35 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 16:50 [RFC PATCH 0/2] add support for videostrong KII Pro Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 1/2] Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
2019-11-16 9:43 ` Andreas Färber
2019-11-18 17:35 ` Mohammad Rasim
2019-11-15 16:50 ` [RFC PATCH 2/2] Add support for Videostrong KII Pro tv box Mohammad Rasim
2019-11-16 9:53 ` Andreas Färber
2019-11-16 10:28 ` Martin Blumenstingl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).