* [PATCH v4 0/3] add support for videostrong KII Pro
@ 2019-11-30 19:53 Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong Mohammad Rasim
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Mohammad Rasim @ 2019-11-30 19:53 UTC (permalink / raw)
To: linux-amlogic, Kevin Hilman, Neil Armstrong, Martin Blumenstingl
Cc: Mohammad Rasim
This patchset adds support for the Videostrong KII Pro tv box which is
based on the gxbb-p201 reference design.
Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver
Changes since RFC v1:
- add commit description to the cover letter
- update bluetooth bindings
- use lowercase name for the dts filename,vendor prefix and compatible
- add copyrights to the new files
- include "meson-gxbb-p20x.dtsi" instead of "meson-gxbb-p201.dts"
Changes since RFC v2:
- Fix styling issues
Changes since v1:
- add leds node to the device tree
- add gpio-keys-polled node to the device tree
Changes since v2:
- use phy-handle to describe the phy
- The blutooth compatible is now merged,change the commit message
accordingly
Changes since v3:
- fix typo in the binding commit message
- add device bindings to arm/amlogic.yaml
- remove deprecated "label" property from the gpio-leds node
- rename button@0 to button-reset
- add the device specs to the dts commit message
Mohammad Rasim (3):
dt-bindings: Add vendor prefix for Videostrong
dt-bindings: arm: amlogic: add Videostrong KII Pro bindings
arm64: dts: meson-gxbb: add support for Videostrong KII Pro
.../devicetree/bindings/arm/amlogic.yaml | 1 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-gxbb-kii-pro.dts | 78 +++++++++++++++++++
4 files changed, 82 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
--
2.24.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong
2019-11-30 19:53 [PATCH v4 0/3] add support for videostrong KII Pro Mohammad Rasim
@ 2019-11-30 19:53 ` Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings Mohammad Rasim
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Mohammad Rasim @ 2019-11-30 19:53 UTC (permalink / raw)
To: devicetree, linux-amlogic, Rob Herring, Kevin Hilman,
Neil Armstrong, Martin Blumenstingl
Cc: Mark Rutland, Mohammad Rasim
Videostrong Technology Co., Ltd., A manufacturer of Android Players & STB
(Android with DVB Hybrid box & DVB-T2/S2/C/ISDB-T/DTMB-TH/ATSC) as well as
HD media players.
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index fd6fa07c45b8..a6c83d70aa74 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1008,6 +1008,8 @@ patternProperties:
description: Variscite Ltd.
"^via,.*":
description: VIA Technologies, Inc.
+ "^videostrong,.*":
+ description: Videostrong Technology Co., Ltd.
"^virtio,.*":
description: Virtual I/O Device Specification, developed by the OASIS consortium
"^vishay,.*":
--
2.24.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings
2019-11-30 19:53 [PATCH v4 0/3] add support for videostrong KII Pro Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong Mohammad Rasim
@ 2019-11-30 19:53 ` Mohammad Rasim
2019-12-01 22:20 ` Martin Blumenstingl
2019-11-30 19:53 ` [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-12-09 22:31 ` [PATCH v4 0/3] add support for videostrong " Kevin Hilman
3 siblings, 1 reply; 9+ messages in thread
From: Mohammad Rasim @ 2019-11-30 19:53 UTC (permalink / raw)
To: devicetree, linux-amlogic, Rob Herring, Kevin Hilman,
Neil Armstrong, Martin Blumenstingl
Cc: Mark Rutland, Mohammad Rasim
Add the compatible for the Amlogic gxbb(s905) based kii pro
Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
---
Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
index 99015cef8bb1..8c97b8867e2f 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.yaml
+++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
@@ -59,6 +59,7 @@ properties:
- friendlyarm,nanopi-k2
- hardkernel,odroid-c2
- nexbox,a95x
+ - videostrong,kii-pro
- wetek,hub
- wetek,play2
- const: amlogic,meson-gxbb
--
2.24.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
2019-11-30 19:53 [PATCH v4 0/3] add support for videostrong KII Pro Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings Mohammad Rasim
@ 2019-11-30 19:53 ` Mohammad Rasim
2019-12-01 22:21 ` Martin Blumenstingl
2019-12-09 22:31 ` [PATCH v4 0/3] add support for videostrong " Kevin Hilman
3 siblings, 1 reply; 9+ messages in thread
From: Mohammad Rasim @ 2019-11-30 19:53 UTC (permalink / raw)
To: devicetree, linux-amlogic, Rob Herring, Kevin Hilman,
Neil Armstrong, Martin Blumenstingl
Cc: Mark Rutland, Mohammad Rasim
This patch adds support for the Videostrong KII Pro tv box which is
based on the gxbb-p201 reference design
Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
---
arch/arm64/boot/dts/amlogic/Makefile | 1 +
.../boot/dts/amlogic/meson-gxbb-kii-pro.dts | 78 +++++++++++++++++++
2 files changed, 79 insertions(+)
create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index 84afecba9ec0..a795a170dcab 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
new file mode 100644
index 000000000000..2f1f829450a2
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2019 Mohammad Rasim <mohammad.rasim96@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "meson-gxbb-p20x.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+/ {
+ compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb";
+ model = "Videostrong KII Pro";
+
+ leds {
+ compatible = "gpio-leds";
+ status {
+ gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ color = <LED_COLOR_ID_RED>;
+ function = LED_FUNCTION_STATUS;
+ };
+ };
+
+ gpio-keys-polled {
+ compatible = "gpio-keys-polled";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ poll-interval = <20>;
+
+ button-reset {
+ label = "reset";
+ linux,code = <KEY_POWER>;
+ gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+};
+
+
+
+&uart_A {
+ status = "okay";
+ pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
+ pinctrl-names = "default";
+ uart-has-rtscts;
+
+ bluetooth {
+ compatible = "brcm,bcm4335a0";
+ };
+};
+
+
+
+ðmac {
+ status = "okay";
+ pinctrl-0 = <ð_rmii_pins>;
+ pinctrl-names = "default";
+
+ phy-handle = <ð_phy0>;
+ phy-mode = "rmii";
+
+ mdio {
+ compatible = "snps,dwmac-mdio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ eth_phy0: ethernet-phy@0 {
+ /* IC Plus IP101GR (0x02430c54) */
+ reg = <0>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <10000>;
+ reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>;
+ };
+ };
+};
--
2.24.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings
2019-11-30 19:53 ` [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings Mohammad Rasim
@ 2019-12-01 22:20 ` Martin Blumenstingl
0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2019-12-01 22:20 UTC (permalink / raw)
To: Mohammad Rasim
Cc: Mark Rutland, devicetree, Neil Armstrong, Kevin Hilman,
Rob Herring, linux-amlogic
On Sat, Nov 30, 2019 at 8:53 PM Mohammad Rasim
<mohammad.rasim96@gmail.com> wrote:
>
> Add the compatible for the Amlogic gxbb(s905) based kii pro
>
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
2019-11-30 19:53 ` [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
@ 2019-12-01 22:21 ` Martin Blumenstingl
2019-12-02 8:02 ` Mohammad Rasim
0 siblings, 1 reply; 9+ messages in thread
From: Martin Blumenstingl @ 2019-12-01 22:21 UTC (permalink / raw)
To: Mohammad Rasim
Cc: Mark Rutland, devicetree, Neil Armstrong, Kevin Hilman,
Rob Herring, linux-amlogic
[...]
> + leds {
> + compatible = "gpio-leds";
> + status {
> + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_STATUS;
why is LED_FUNCTION_STATUS not enclosed in <> like color above?
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
2019-12-01 22:21 ` Martin Blumenstingl
@ 2019-12-02 8:02 ` Mohammad Rasim
2019-12-03 20:58 ` Martin Blumenstingl
0 siblings, 1 reply; 9+ messages in thread
From: Mohammad Rasim @ 2019-12-02 8:02 UTC (permalink / raw)
To: Martin Blumenstingl
Cc: Mark Rutland, devicetree, Neil Armstrong, Kevin Hilman,
Rob Herring, linux-amlogic
On 19/12/01 11:21PM, Martin Blumenstingl wrote:
> [...]
> > + leds {
> > + compatible = "gpio-leds";
> > + status {
> > + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> > + default-state = "off";
> > + color = <LED_COLOR_ID_RED>;
> > + function = LED_FUNCTION_STATUS;
> why is LED_FUNCTION_STATUS not enclosed in <> like color above?
>
Well, the examples in the documentation enclose the color and don't
enclose function
https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140
Regards
>
> Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro
2019-12-02 8:02 ` Mohammad Rasim
@ 2019-12-03 20:58 ` Martin Blumenstingl
0 siblings, 0 replies; 9+ messages in thread
From: Martin Blumenstingl @ 2019-12-03 20:58 UTC (permalink / raw)
To: Mohammad Rasim
Cc: Mark Rutland, devicetree, Neil Armstrong, Kevin Hilman,
Rob Herring, linux-amlogic
On Mon, Dec 2, 2019 at 9:02 AM Mohammad Rasim
<mohammad.rasim96@gmail.com> wrote:
>
> On 19/12/01 11:21PM, Martin Blumenstingl wrote:
> > [...]
> > > + leds {
> > > + compatible = "gpio-leds";
> > > + status {
> > > + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> > > + default-state = "off";
> > > + color = <LED_COLOR_ID_RED>;
> > > + function = LED_FUNCTION_STATUS;
> > why is LED_FUNCTION_STATUS not enclosed in <> like color above?
> >
> Well, the examples in the documentation enclose the color and don't
> enclose function
> https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140
sorry for the noise, only now I realize that the LED_FUNCTION_*s are
string definitions and not numeric values
in this case all is fine
I learnt something new today ;)
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 0/3] add support for videostrong KII Pro
2019-11-30 19:53 [PATCH v4 0/3] add support for videostrong KII Pro Mohammad Rasim
` (2 preceding siblings ...)
2019-11-30 19:53 ` [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
@ 2019-12-09 22:31 ` Kevin Hilman
3 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2019-12-09 22:31 UTC (permalink / raw)
To: Mohammad Rasim, linux-amlogic, Neil Armstrong, Martin Blumenstingl
Cc: Mohammad Rasim
Hi Mohammad,
Mohammad Rasim <mohammad.rasim96@gmail.com> writes:
> This patchset adds support for the Videostrong KII Pro tv box which is
> based on the gxbb-p201 reference design.
>
> Device specifications:
> - SOC: Amlogic S905
> - RAM: 2GB DDR3
> - Storage: 16GB
> - Connectivity:
> - 10/100M Ethernet (IC Plus IP101GR)
> - 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
> - Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
> - Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
> - Audio out: HDMI, AV (stereo audio) and optical S/PDIF
> - Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
> - Ports:
> - x1 micro SD card slot up to 32GB
> - 4x USB 2.0 host ports
> - Misc:
> - Power button and LED, IR receiver
Series queued for v5.6.
Thanks for adding a new board upstream!
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-12-09 22:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-30 19:53 [PATCH v4 0/3] add support for videostrong KII Pro Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Videostrong Mohammad Rasim
2019-11-30 19:53 ` [PATCH v4 2/3] dt-bindings: arm: amlogic: add Videostrong KII Pro bindings Mohammad Rasim
2019-12-01 22:20 ` Martin Blumenstingl
2019-11-30 19:53 ` [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-12-01 22:21 ` Martin Blumenstingl
2019-12-02 8:02 ` Mohammad Rasim
2019-12-03 20:58 ` Martin Blumenstingl
2019-12-09 22:31 ` [PATCH v4 0/3] add support for videostrong " Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).