* [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning
@ 2019-01-13 15:30 Anand Moon
2019-01-13 15:30 ` [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning Anand Moon
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Anand Moon @ 2019-01-13 15:30 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Martin Blumenstingl, Kevin Hilman, Rob Herring, Neil Armstrong,
Jerome Brunet
Override the dr_mode from "host" to "peripheral" for dwc2
usb_phy0->usb0 initilization of OTG Micro-B type.
Changes fix the below warning for phy poweron failed --> -22
Changes fix the initialization of c9000000.usb phy
[ 1.203900] phy phy-c0000000.phy.0: USB ID detect failed!
[ 1.208048] phy phy-c0000000.phy.0: phy poweron failed --> -22
[ 1.213877] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
[ 1.222953] Modules linked in:
[ 1.225976] CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.0.0-rc1-xc2ml #3
[ 1.232872] Hardware name: Hardkernel ODROID-C2 (DT)
[ 1.237794] Workqueue: events deferred_probe_work_func
[ 1.242878] pstate: 80000005 (Nzcv daif -PAN -UAO)
[ 1.247623] pc : _regulator_put.part.11+0xf0/0xf8
[ 1.252280] lr : regulator_put+0x34/0x48
[ 1.256159] sp : ffff00001176bb00
[ 1.259437] x29: ffff00001176bb00 x28: 0000000000000000
[ 1.264698] x27: ffff80007f31beb8 x26: ffff000010eeb7e0
[ 1.269959] x25: 0000000000000000 x24: 0000000000000009
[ 1.275220] x23: ffff00001176bbc8 x22: ffff80007ed9d500
[ 1.280482] x21: ffff0000111bd6c8 x20: ffff80007ed9d700
[ 1.285743] x19: ffff80007ed9d700 x18: 000000000000006f
[ 1.291004] x17: 0000000000000000 x16: 0000000000000000
[ 1.296265] x15: 0000000000000400 x14: 0000000000000400
[ 1.301527] x13: ff00000000000000 x12: ffffffffffffffff
[ 1.306788] x11: 0000000000000038 x10: 0000000000000040
[ 1.312049] x9 : ffff0000111d58b0 x8 : ffff0000111d58a8
[ 1.317310] x7 : ffff80007ed9db00 x6 : ffff80007ec21b00
[ 1.322571] x5 : ffff80007f400248 x4 : ffff80007fba9b00
[ 1.327833] x3 : ffff0000112d9eb8 x2 : ffff80007ec21b00
[ 1.333094] x1 : 0000000000000000 x0 : 0000000000000001
[ 1.338356] Call trace:
[ 1.340773] _regulator_put.part.11+0xf0/0xf8
[ 1.345085] regulator_put+0x34/0x48
[ 1.348621] regulator_bulk_free+0x30/0x50
[ 1.352675] devm_regulator_bulk_release+0x18/0x20
[ 1.357421] release_nodes+0x1b0/0x220
[ 1.361127] devres_release_all+0x34/0x50
[ 1.365094] really_probe+0xec/0x290
[ 1.368630] driver_probe_device+0x54/0xe8
[ 1.372684] __device_attach_driver+0xb8/0xe8
[ 1.376997] bus_for_each_drv+0x78/0xc8
[ 1.380792] __device_attach+0xd4/0x130
[ 1.384587] device_initial_probe+0x10/0x18
[ 1.388727] bus_probe_device+0x90/0x98
[ 1.392522] deferred_probe_work_func+0x6c/0xa0
[ 1.397010] process_one_work+0x1e0/0x318
[ 1.400975] worker_thread+0x228/0x428
[ 1.404684] kthread+0x124/0x128
[ 1.407876] ret_from_fork+0x10/0x18
[ 1.411410] ---[ end trace de5fd1b262c1f56a ]---
[ 1.416055] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
[ 1.425123] Modules linked in:
[ 1.428144] CPU: 1 PID: 44 Comm: kworker/1:1 Tainted: GW 5.0.0-rc1-xc2ml #3
[ 1.436422] Hardware name: Hardkernel ODROID-C2 (DT)
[ 1.441340] Workqueue: events deferred_probe_work_func
Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
Tested-by: Kevin Hilman <khilman@baylibre.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Rebased on Kevin's amlogic/v5.0/fixes branch
Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
- Split the patch into two part
- Fix the commit message
- Added Tested by Kevin Hilman
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 1cc9dc68ef00..25a36d117183 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -302,6 +302,7 @@
&usb0 {
status = "okay";
+ dr_mode = "peripheral";
};
&usb1 {
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning
2019-01-13 15:30 [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Anand Moon
@ 2019-01-13 15:30 ` Anand Moon
2019-01-14 16:17 ` Neil Armstrong
2019-01-14 16:22 ` Kevin Hilman
2019-01-14 16:17 ` [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Neil Armstrong
2019-01-17 21:14 ` Kevin Hilman
2 siblings, 2 replies; 8+ messages in thread
From: Anand Moon @ 2019-01-13 15:30 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Martin Blumenstingl, Kevin Hilman, Rob Herring, Neil Armstrong,
Jerome Brunet
Add missing vin-supply node 5.0V regulator setting to power
to usb ports, changes help fix the usb reset warning.
[ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2
Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
Tested-by: Kevin Hilman <khilman@baylibre.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Rebased on Kevin's amlogic/v5.0/fixes branch
Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
- Split the patch into two part: new patch
- Fix the commit message
- Added Tested by Kevin Hilman
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 25a36d117183..a947b46bfaa8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -28,6 +28,13 @@
reg = <0x0 0x0 0x0 0x80000000>;
};
+ p5v0: regulator-p5v0 {
+ compatible = "regulator-fixed";
+ regulator-name = "P5V0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ };
+
usb_otg_pwr: regulator-usb-pwrs {
compatible = "regulator-fixed";
@@ -36,6 +43,8 @@
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
+ vin-supply = <&p5v0>;
+
gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning
2019-01-13 15:30 ` [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning Anand Moon
@ 2019-01-14 16:17 ` Neil Armstrong
2019-01-14 16:22 ` Kevin Hilman
1 sibling, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2019-01-14 16:17 UTC (permalink / raw)
To: Anand Moon, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Martin Blumenstingl, Kevin Hilman, Rob Herring, Jerome Brunet
Hi Anand,
On 13/01/2019 16:30, Anand Moon wrote:
> Add missing vin-supply node 5.0V regulator setting to power
> to usb ports, changes help fix the usb reset warning.
>
> [ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2
>
> Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Rebased on Kevin's amlogic/v5.0/fixes branch
> Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
> - Split the patch into two part: new patch
> - Fix the commit message
> - Added Tested by Kevin Hilman
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 25a36d117183..a947b46bfaa8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -28,6 +28,13 @@
> reg = <0x0 0x0 0x0 0x80000000>;
> };
>
> + p5v0: regulator-p5v0 {
> + compatible = "regulator-fixed";
> + regulator-name = "P5V0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> usb_otg_pwr: regulator-usb-pwrs {
> compatible = "regulator-fixed";
>
> @@ -36,6 +43,8 @@
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
>
> + vin-supply = <&p5v0>;
> +
> gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
> enable-active-high;
> };
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
PS: Please add a cover-letter next time !
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning
2019-01-13 15:30 [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Anand Moon
2019-01-13 15:30 ` [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning Anand Moon
@ 2019-01-14 16:17 ` Neil Armstrong
2019-01-17 21:14 ` Kevin Hilman
2 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2019-01-14 16:17 UTC (permalink / raw)
To: Anand Moon, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Martin Blumenstingl, Kevin Hilman, Rob Herring, Jerome Brunet
Hi Anand,
On 13/01/2019 16:30, Anand Moon wrote:
> Override the dr_mode from "host" to "peripheral" for dwc2
> usb_phy0->usb0 initilization of OTG Micro-B type.
> Changes fix the below warning for phy poweron failed --> -22
>
> Changes fix the initialization of c9000000.usb phy
>
> [ 1.203900] phy phy-c0000000.phy.0: USB ID detect failed!
> [ 1.208048] phy phy-c0000000.phy.0: phy poweron failed --> -22
> [ 1.213877] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
> [ 1.222953] Modules linked in:
> [ 1.225976] CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.0.0-rc1-xc2ml #3
> [ 1.232872] Hardware name: Hardkernel ODROID-C2 (DT)
> [ 1.237794] Workqueue: events deferred_probe_work_func
> [ 1.242878] pstate: 80000005 (Nzcv daif -PAN -UAO)
> [ 1.247623] pc : _regulator_put.part.11+0xf0/0xf8
> [ 1.252280] lr : regulator_put+0x34/0x48
> [ 1.256159] sp : ffff00001176bb00
> [ 1.259437] x29: ffff00001176bb00 x28: 0000000000000000
> [ 1.264698] x27: ffff80007f31beb8 x26: ffff000010eeb7e0
> [ 1.269959] x25: 0000000000000000 x24: 0000000000000009
> [ 1.275220] x23: ffff00001176bbc8 x22: ffff80007ed9d500
> [ 1.280482] x21: ffff0000111bd6c8 x20: ffff80007ed9d700
> [ 1.285743] x19: ffff80007ed9d700 x18: 000000000000006f
> [ 1.291004] x17: 0000000000000000 x16: 0000000000000000
> [ 1.296265] x15: 0000000000000400 x14: 0000000000000400
> [ 1.301527] x13: ff00000000000000 x12: ffffffffffffffff
> [ 1.306788] x11: 0000000000000038 x10: 0000000000000040
> [ 1.312049] x9 : ffff0000111d58b0 x8 : ffff0000111d58a8
> [ 1.317310] x7 : ffff80007ed9db00 x6 : ffff80007ec21b00
> [ 1.322571] x5 : ffff80007f400248 x4 : ffff80007fba9b00
> [ 1.327833] x3 : ffff0000112d9eb8 x2 : ffff80007ec21b00
> [ 1.333094] x1 : 0000000000000000 x0 : 0000000000000001
> [ 1.338356] Call trace:
> [ 1.340773] _regulator_put.part.11+0xf0/0xf8
> [ 1.345085] regulator_put+0x34/0x48
> [ 1.348621] regulator_bulk_free+0x30/0x50
> [ 1.352675] devm_regulator_bulk_release+0x18/0x20
> [ 1.357421] release_nodes+0x1b0/0x220
> [ 1.361127] devres_release_all+0x34/0x50
> [ 1.365094] really_probe+0xec/0x290
> [ 1.368630] driver_probe_device+0x54/0xe8
> [ 1.372684] __device_attach_driver+0xb8/0xe8
> [ 1.376997] bus_for_each_drv+0x78/0xc8
> [ 1.380792] __device_attach+0xd4/0x130
> [ 1.384587] device_initial_probe+0x10/0x18
> [ 1.388727] bus_probe_device+0x90/0x98
> [ 1.392522] deferred_probe_work_func+0x6c/0xa0
> [ 1.397010] process_one_work+0x1e0/0x318
> [ 1.400975] worker_thread+0x228/0x428
> [ 1.404684] kthread+0x124/0x128
> [ 1.407876] ret_from_fork+0x10/0x18
> [ 1.411410] ---[ end trace de5fd1b262c1f56a ]---
> [ 1.416055] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
> [ 1.425123] Modules linked in:
> [ 1.428144] CPU: 1 PID: 44 Comm: kworker/1:1 Tainted: GW 5.0.0-rc1-xc2ml #3
> [ 1.436422] Hardware name: Hardkernel ODROID-C2 (DT)
> [ 1.441340] Workqueue: events deferred_probe_work_func
>
> Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Rebased on Kevin's amlogic/v5.0/fixes branch
> Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
> - Split the patch into two part
> - Fix the commit message
> - Added Tested by Kevin Hilman
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..25a36d117183 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -302,6 +302,7 @@
>
> &usb0 {
> status = "okay";
> + dr_mode = "peripheral";
> };
>
> &usb1 {
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
PS: Please add a cover-letter next time !
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning
2019-01-13 15:30 ` [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning Anand Moon
2019-01-14 16:17 ` Neil Armstrong
@ 2019-01-14 16:22 ` Kevin Hilman
2019-01-14 17:19 ` Anand Moon
1 sibling, 1 reply; 8+ messages in thread
From: Kevin Hilman @ 2019-01-14 16:22 UTC (permalink / raw)
To: Anand Moon, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Martin Blumenstingl, Neil Armstrong, Rob Herring, Jerome Brunet
Hi Anand,
Anand Moon <linux.amoon@gmail.com> writes:
> Add missing vin-supply node 5.0V regulator setting to power
> to usb ports, changes help fix the usb reset warning.
>
> [ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> [ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2
>
> Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Rebased on Kevin's amlogic/v5.0/fixes branch
> Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
> - Split the patch into two part: new patch
> - Fix the commit message
> - Added Tested by Kevin Hilman
Queued as fixes for v5.0-rc (branch: v5.0/fixes) with Neil's reviewed-by tags.
Thanks for breaking up into two patches, and as Neil said, please add a
cover letter to multi-patch series in the future.
Thanks,
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning
2019-01-14 16:22 ` Kevin Hilman
@ 2019-01-14 17:19 ` Anand Moon
0 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2019-01-14 17:19 UTC (permalink / raw)
To: Kevin Hilman
Cc: devicetree, Neil Armstrong, Martin Blumenstingl, Linux Kernel,
Rob Herring, linux-amlogic, linux-arm-kernel, Jerome Brunet
Hi Kevin / Neil
On Mon, 14 Jan 2019 at 21:52, Kevin Hilman <khilman@baylibre.com> wrote:
>
> Hi Anand,
>
> Anand Moon <linux.amoon@gmail.com> writes:
>
> > Add missing vin-supply node 5.0V regulator setting to power
> > to usb ports, changes help fix the usb reset warning.
> >
> > [ 795.380156] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> > [ 798.356073] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> > [ 801.331999] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> > [ 804.307919] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> > [ 807.283844] usb 1-1.2: reset high-speed USB device number 3 using dwc2
> >
> > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
> > Tested-by: Kevin Hilman <khilman@baylibre.com>
> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Cc: Jerome Brunet <jbrunet@baylibre.com>
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > Rebased on Kevin's amlogic/v5.0/fixes branch
> > Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
> > - Split the patch into two part: new patch
> > - Fix the commit message
> > - Added Tested by Kevin Hilman
>
> Queued as fixes for v5.0-rc (branch: v5.0/fixes) with Neil's reviewed-by tags.
>
> Thanks for breaking up into two patches, and as Neil said, please add a
> cover letter to multi-patch series in the future.
>
> Thanks,
>
> Kevin
Ok will follow the protocol next time I send some patches.
Best Regards
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning
2019-01-13 15:30 [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Anand Moon
2019-01-13 15:30 ` [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning Anand Moon
2019-01-14 16:17 ` [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Neil Armstrong
@ 2019-01-17 21:14 ` Kevin Hilman
2019-01-20 18:45 ` Anand Moon
2 siblings, 1 reply; 8+ messages in thread
From: Kevin Hilman @ 2019-01-17 21:14 UTC (permalink / raw)
To: Anand Moon, devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
Cc: Martin Blumenstingl, Neil Armstrong, Rob Herring, Jerome Brunet
Hi Anand,
Anand Moon <linux.amoon@gmail.com> writes:
> Override the dr_mode from "host" to "peripheral" for dwc2
> usb_phy0->usb0 initilization of OTG Micro-B type.
> Changes fix the below warning for phy poweron failed --> -22
>
> Changes fix the initialization of c9000000.usb phy
>
> [ 1.203900] phy phy-c0000000.phy.0: USB ID detect failed!
> [ 1.208048] phy phy-c0000000.phy.0: phy poweron failed --> -22
> [ 1.213877] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
> [ 1.222953] Modules linked in:
> [ 1.225976] CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.0.0-rc1-xc2ml #3
> [ 1.232872] Hardware name: Hardkernel ODROID-C2 (DT)
> [ 1.237794] Workqueue: events deferred_probe_work_func
> [ 1.242878] pstate: 80000005 (Nzcv daif -PAN -UAO)
> [ 1.247623] pc : _regulator_put.part.11+0xf0/0xf8
> [ 1.252280] lr : regulator_put+0x34/0x48
> [ 1.256159] sp : ffff00001176bb00
> [ 1.259437] x29: ffff00001176bb00 x28: 0000000000000000
> [ 1.264698] x27: ffff80007f31beb8 x26: ffff000010eeb7e0
> [ 1.269959] x25: 0000000000000000 x24: 0000000000000009
> [ 1.275220] x23: ffff00001176bbc8 x22: ffff80007ed9d500
> [ 1.280482] x21: ffff0000111bd6c8 x20: ffff80007ed9d700
> [ 1.285743] x19: ffff80007ed9d700 x18: 000000000000006f
> [ 1.291004] x17: 0000000000000000 x16: 0000000000000000
> [ 1.296265] x15: 0000000000000400 x14: 0000000000000400
> [ 1.301527] x13: ff00000000000000 x12: ffffffffffffffff
> [ 1.306788] x11: 0000000000000038 x10: 0000000000000040
> [ 1.312049] x9 : ffff0000111d58b0 x8 : ffff0000111d58a8
> [ 1.317310] x7 : ffff80007ed9db00 x6 : ffff80007ec21b00
> [ 1.322571] x5 : ffff80007f400248 x4 : ffff80007fba9b00
> [ 1.327833] x3 : ffff0000112d9eb8 x2 : ffff80007ec21b00
> [ 1.333094] x1 : 0000000000000000 x0 : 0000000000000001
> [ 1.338356] Call trace:
> [ 1.340773] _regulator_put.part.11+0xf0/0xf8
> [ 1.345085] regulator_put+0x34/0x48
> [ 1.348621] regulator_bulk_free+0x30/0x50
> [ 1.352675] devm_regulator_bulk_release+0x18/0x20
> [ 1.357421] release_nodes+0x1b0/0x220
> [ 1.361127] devres_release_all+0x34/0x50
> [ 1.365094] really_probe+0xec/0x290
> [ 1.368630] driver_probe_device+0x54/0xe8
> [ 1.372684] __device_attach_driver+0xb8/0xe8
> [ 1.376997] bus_for_each_drv+0x78/0xc8
> [ 1.380792] __device_attach+0xd4/0x130
> [ 1.384587] device_initial_probe+0x10/0x18
> [ 1.388727] bus_probe_device+0x90/0x98
> [ 1.392522] deferred_probe_work_func+0x6c/0xa0
> [ 1.397010] process_one_work+0x1e0/0x318
> [ 1.400975] worker_thread+0x228/0x428
> [ 1.404684] kthread+0x124/0x128
> [ 1.407876] ret_from_fork+0x10/0x18
> [ 1.411410] ---[ end trace de5fd1b262c1f56a ]---
> [ 1.416055] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
> [ 1.425123] Modules linked in:
> [ 1.428144] CPU: 1 PID: 44 Comm: kworker/1:1 Tainted: GW 5.0.0-rc1-xc2ml #3
> [ 1.436422] Hardware name: Hardkernel ODROID-C2 (DT)
> [ 1.441340] Workqueue: events deferred_probe_work_func
>
> Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
Minor nit: the shortlog should be in double quotes.
I fixed it up manually, so nothing you need to do, but just for future
reference.
This was found by some automated checking recently added to the
linux-next tree.
Kevin
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Rebased on Kevin's amlogic/v5.0/fixes branch
> Changes from patch v1 [0] https://lore.kernel.org/patchwork/patch/1031243/
> - Split the patch into two part
> - Fix the commit message
> - Added Tested by Kevin Hilman
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..25a36d117183 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -302,6 +302,7 @@
>
> &usb0 {
> status = "okay";
> + dr_mode = "peripheral";
> };
>
> &usb1 {
> --
> 2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning
2019-01-17 21:14 ` Kevin Hilman
@ 2019-01-20 18:45 ` Anand Moon
0 siblings, 0 replies; 8+ messages in thread
From: Anand Moon @ 2019-01-20 18:45 UTC (permalink / raw)
To: Kevin Hilman
Cc: devicetree, Neil Armstrong, Martin Blumenstingl, Linux Kernel,
Rob Herring, linux-amlogic, linux-arm-kernel, Jerome Brunet
Hi Kevin / Martin,
On Fri, 18 Jan 2019 at 02:44, Kevin Hilman <khilman@baylibre.com> wrote:
>
> Hi Anand,
>
> Anand Moon <linux.amoon@gmail.com> writes:
>
> > Override the dr_mode from "host" to "peripheral" for dwc2
> > usb_phy0->usb0 initilization of OTG Micro-B type.
> > Changes fix the below warning for phy poweron failed --> -22
> >
> > Changes fix the initialization of c9000000.usb phy
> >
> > [ 1.203900] phy phy-c0000000.phy.0: USB ID detect failed!
> > [ 1.208048] phy phy-c0000000.phy.0: phy poweron failed --> -22
> > [ 1.213877] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
> > [ 1.222953] Modules linked in:
> > [ 1.225976] CPU: 1 PID: 44 Comm: kworker/1:1 Not tainted 5.0.0-rc1-xc2ml #3
> > [ 1.232872] Hardware name: Hardkernel ODROID-C2 (DT)
> > [ 1.237794] Workqueue: events deferred_probe_work_func
> > [ 1.242878] pstate: 80000005 (Nzcv daif -PAN -UAO)
> > [ 1.247623] pc : _regulator_put.part.11+0xf0/0xf8
> > [ 1.252280] lr : regulator_put+0x34/0x48
> > [ 1.256159] sp : ffff00001176bb00
> > [ 1.259437] x29: ffff00001176bb00 x28: 0000000000000000
> > [ 1.264698] x27: ffff80007f31beb8 x26: ffff000010eeb7e0
> > [ 1.269959] x25: 0000000000000000 x24: 0000000000000009
> > [ 1.275220] x23: ffff00001176bbc8 x22: ffff80007ed9d500
> > [ 1.280482] x21: ffff0000111bd6c8 x20: ffff80007ed9d700
> > [ 1.285743] x19: ffff80007ed9d700 x18: 000000000000006f
> > [ 1.291004] x17: 0000000000000000 x16: 0000000000000000
> > [ 1.296265] x15: 0000000000000400 x14: 0000000000000400
> > [ 1.301527] x13: ff00000000000000 x12: ffffffffffffffff
> > [ 1.306788] x11: 0000000000000038 x10: 0000000000000040
> > [ 1.312049] x9 : ffff0000111d58b0 x8 : ffff0000111d58a8
> > [ 1.317310] x7 : ffff80007ed9db00 x6 : ffff80007ec21b00
> > [ 1.322571] x5 : ffff80007f400248 x4 : ffff80007fba9b00
> > [ 1.327833] x3 : ffff0000112d9eb8 x2 : ffff80007ec21b00
> > [ 1.333094] x1 : 0000000000000000 x0 : 0000000000000001
> > [ 1.338356] Call trace:
> > [ 1.340773] _regulator_put.part.11+0xf0/0xf8
> > [ 1.345085] regulator_put+0x34/0x48
> > [ 1.348621] regulator_bulk_free+0x30/0x50
> > [ 1.352675] devm_regulator_bulk_release+0x18/0x20
> > [ 1.357421] release_nodes+0x1b0/0x220
> > [ 1.361127] devres_release_all+0x34/0x50
> > [ 1.365094] really_probe+0xec/0x290
> > [ 1.368630] driver_probe_device+0x54/0xe8
> > [ 1.372684] __device_attach_driver+0xb8/0xe8
> > [ 1.376997] bus_for_each_drv+0x78/0xc8
> > [ 1.380792] __device_attach+0xd4/0x130
> > [ 1.384587] device_initial_probe+0x10/0x18
> > [ 1.388727] bus_probe_device+0x90/0x98
> > [ 1.392522] deferred_probe_work_func+0x6c/0xa0
> > [ 1.397010] process_one_work+0x1e0/0x318
> > [ 1.400975] worker_thread+0x228/0x428
> > [ 1.404684] kthread+0x124/0x128
> > [ 1.407876] ret_from_fork+0x10/0x18
> > [ 1.411410] ---[ end trace de5fd1b262c1f56a ]---
> > [ 1.416055] WARNING: CPU: 1 PID: 44 at drivers/regulator/core.c:2054 _regulator_put.part.11+0xf0/0xf8
> > [ 1.425123] Modules linked in:
> > [ 1.428144] CPU: 1 PID: 44 Comm: kworker/1:1 Tainted: GW 5.0.0-rc1-xc2ml #3
> > [ 1.436422] Hardware name: Hardkernel ODROID-C2 (DT)
> > [ 1.441340] Workqueue: events deferred_probe_work_func
> >
> > Fixes: 5a0803bd5ae (ARM64: dts: meson-gxbb-odroidc2: Enable USB Nodes)
>
> Minor nit: the shortlog should be in double quotes.
>
> I fixed it up manually, so nothing you need to do, but just for future
> reference.
>
> This was found by some automated checking recently added to the
> linux-next tree.
>
> Kevin
>
Thanks: I will follow the protocol next time.
As pointed my Martin on Odroid C1+ my patch do not fix complete issue.
[0] https://patchwork.kernel.org/patch/10761371/
[1] https://patchwork.kernel.org/patch/10761375/
Both of my patch seem to be wrong and if possible please so drop them
from linux-next and your fix tagged.
I will try to find proper fix proper to the issue.
Quick phy driver and dts changes enable *Bus 01.Port 1* and *Bus 02.Port 1*
[alarm@archl-c2m ~]$ lsusb -t
/: Bus 02.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M
|__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M
|__ Port 1: Dev 5, If 0, Class=Mass Storage, Driver=usb-storage, 480M
|__ Port 2: Dev 3, If 0, Class=Video, Driver=uvcvideo, 480M
|__ Port 2: Dev 3, If 1, Class=Video, Driver=uvcvideo, 480M
|__ Port 2: Dev 3, If 2, Class=Audio, Driver=, 480M
|__ Port 2: Dev 3, If 3, Class=Audio, Driver=, 480M
|__ Port 3: Dev 4, If 0, Class=Vendor Specific Class, Driver=, 480M
/: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=dwc2/1p, 480M
Need to fix the vbus setting for both the bus ports, which I am looking into.
Best Regards
-Anand
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-01-20 18:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 15:30 [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Anand Moon
2019-01-13 15:30 ` [PatchV2 2/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy reset warning Anand Moon
2019-01-14 16:17 ` Neil Armstrong
2019-01-14 16:22 ` Kevin Hilman
2019-01-14 17:19 ` Anand Moon
2019-01-14 16:17 ` [PatchV2 1/2] ARM64: dts: meson-gxbb-odroidc2: Fix usb phy regulator power failed warning Neil Armstrong
2019-01-17 21:14 ` Kevin Hilman
2019-01-20 18:45 ` Anand Moon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).