From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: dalias@libc.org, fweimer@redhat.com, bernd@petrovitsch.priv.at,
glaubitz@physik.fu-berlin.de, Andrew Lutomirski <luto@kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org, Peter Anvin <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
bp@alien8.de, vapier@gentoo.org, hjl.tools@gmail.com,
x32@buildd.debian.org, Arnd Bergmann <arnd@arndb.de>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>
Subject: Re: Can we drop upstream Linux x32 support?
Date: Fri, 14 Dec 2018 12:13:01 -0800 [thread overview]
Message-ID: <CAHk-=wj0ejxYVV1xPfNX5YD6ZakRoSx+wQR==rFoj4J4SzLWhg@mail.gmail.com> (raw)
In-Reply-To: <EC1F028D-4382-41D6-B539-A9662FD53820@amacapital.net>
On Fri, Dec 14, 2018 at 10:58 AM Andy Lutomirski <luto@amacapital.net> wrote:
>
> Does anyone know *why* Linux’s x32 has __kernel_long_t defined as long long?
It *needs* to be long long, since the headers are used for builds in
user mode using ILP32.
Since __kernel_long_t is a 64-bit (the _kernel_ is not ILP32), you
need to use "long long" when building in ILP32.
Obviously, it could be something like
#ifdef __KERNEL__
typedef long __kernel_long_t;
#else
typedef long long __kernel_long_t;
#endif
or similar to make it more obvious what's going on.
Or we could encourage all the uapi header files to always just use
explicit sizing like __u64, but some of the structures really end up
being "kernel long size" for sad historical reasons. Not lovely, but
there we are..
Linus
next prev parent reply other threads:[~2018-12-14 20:13 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 1:23 Can we drop upstream Linux x32 support? Andy Lutomirski
2018-12-11 1:40 ` Linus Torvalds
2018-12-11 2:22 ` hpa
2018-12-11 8:16 ` Florian Weimer
2018-12-11 21:53 ` Thorsten Glaser
2018-12-11 23:22 ` Andy Lutomirski
2018-12-11 23:35 ` Thorsten Glaser
2018-12-11 23:55 ` Arnd Bergmann
2018-12-12 2:24 ` Andy Lutomirski
2018-12-12 2:33 ` Thorsten Glaser
2018-12-12 9:04 ` Arnd Bergmann
2018-12-12 18:14 ` Joseph Myers
2018-12-12 18:50 ` Ivan Ivanov
2018-12-12 19:12 ` Andy Lutomirski
2018-12-12 19:18 ` Ivan Ivanov
2018-12-12 16:39 ` Andy Lutomirski
2018-12-12 16:52 ` Rich Felker
2018-12-12 18:03 ` Andy Lutomirski
2018-12-13 12:40 ` Catalin Marinas
2018-12-13 15:57 ` Rich Felker
2018-12-13 16:04 ` Florian Weimer
2018-12-13 16:28 ` Rich Felker
2018-12-14 11:42 ` Florian Weimer
2018-12-14 16:13 ` Rich Felker
2018-12-13 18:42 ` Joseph Myers
2018-12-15 4:53 ` Thorsten Glaser
2018-12-11 23:38 ` Rich Felker
2018-12-11 23:40 ` Maciej W. Rozycki
2018-12-13 14:38 ` Olof Johansson
2018-12-13 15:46 ` Lance Richardson
2018-12-13 16:11 ` Richard Purdie
2018-12-11 3:14 ` H.J. Lu
2018-12-11 5:35 ` Andy Lutomirski
2018-12-11 9:02 ` Arnd Bergmann
2018-12-11 11:32 ` Catalin Marinas
2018-12-11 11:37 ` Florian Weimer
2018-12-11 11:52 ` Catalin Marinas
2018-12-11 5:46 ` Christian Brauner
2018-12-11 10:29 ` John Paul Adrian Glaubitz
2018-12-11 10:37 ` Florian Weimer
2018-12-11 10:44 ` John Paul Adrian Glaubitz
2018-12-11 21:59 ` Thorsten Glaser
2018-12-11 23:33 ` Rich Felker
2018-12-13 5:03 ` Kevin Easton
2018-12-13 9:05 ` Richard Weinberger
2018-12-13 12:12 ` Kevin Easton
2018-12-14 14:38 ` David Laight
2018-12-14 15:17 ` Richard Weinberger
2018-12-13 16:02 ` Rich Felker
2018-12-14 14:13 ` Bernd Petrovitsch
2018-12-14 16:17 ` Rich Felker
2018-12-14 16:29 ` Bernd Petrovitsch
2018-12-14 16:38 ` Florian Weimer
2018-12-14 16:55 ` Rich Felker
2018-12-14 18:58 ` Andy Lutomirski
2018-12-14 19:59 ` Lance Richardson
2018-12-14 20:13 ` Linus Torvalds [this message]
2018-12-14 21:27 ` Andy Lutomirski
2018-12-14 21:16 ` Thomas Schöbel-Theuer
2018-12-14 21:24 ` Andy Lutomirski
2018-12-14 21:41 ` Thomas Schöbel-Theuer
2018-12-15 7:41 ` Thomas Schoebel-Theuer
2018-12-15 15:30 ` Andy Lutomirski
2019-01-09 12:41 ` Florian Weimer
2019-01-09 16:02 ` Rich Felker
2019-01-22 13:34 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wj0ejxYVV1xPfNX5YD6ZakRoSx+wQR==rFoj4J4SzLWhg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bernd@petrovitsch.priv.at \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=fweimer@redhat.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=vapier@gentoo.org \
--cc=will.deacon@arm.com \
--cc=x32@buildd.debian.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).