From: Alex Ghiti <alex@ghiti.fr>
To: LEROY Christophe <christophe.leroy@c-s.fr>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
davem@davemloft.net, linuxppc-dev@lists.ozlabs.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
paul.burton@mips.com, ralf@linux-mips.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
tony.luck@intel.com, linux-arm-kernel@lists.infradead.org,
tglx@linutronix.de, arnd@arndb.de, fenghua.yu@intel.com,
jhogan@kernel.org, catalin.marinas@arm.com, mingo@redhat.com,
linux@armlinux.org.uk, x86@kernel.org, deller@gmx.de,
ysato@users.sourceforge.jp, linux-arch@vger.kernel.org,
sparclinux@vger.kernel.org, hpa@zytor.com, paulus@samba.org,
jejb@parisc-linux.org, will.deacon@arm.com,
linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org,
dalias@libc.org, linux-mips@linux-mips.org,
Michal Hocko <mhocko@kernel.org>,
Michael
Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives
Date: Thu, 26 Jul 2018 16:46:20 +0000 [thread overview]
Message-ID: <58887adf-1852-4291-08aa-a1dd2007326b@ghiti.fr> (raw)
In-Reply-To: <20180726171355.Horde.KlFUG9wXmbRDCiyhk5bHsw8@messagerie.si.c-s.fr>
Hi Christophe,
Sorry, I should have done it already: with and without huge page
activated, the build for mpc885_ads_defconfig is OK.
Thanks,
Alex
On 07/26/2018 03:13 PM, LEROY Christophe wrote:
> Alex Ghiti <alex@ghiti.fr> a écrit :
>
>> Hi everyone,
>>
>> This is the result of the build for all arches tackled in this series
>> rebased on 4.18-rc6:
>>
>> arm:
>> versatile_defconfig: without huge page OK
>> keystone_defconfig: with huge page OK
>> arm64:
>> defconfig: with huge page OK
>> ia64:
>> generic_defconfig: with huge page OK
>> mips:
>> Paul Burton tested cavium octeon with huge page OK
>> parisc:
>> generic-64bit_defconfig: with huge page does not link
>> generic-64bit_defconfig: without huge page does not link
>> BUT not because of this series, any feedback welcome.
>> powerpc:
>> ppc64_defconfig: without huge page OK
>> ppc64_defconfig: with huge page OK
>
> Can you also test ppc32 both with and without hugepage
> (mpc885_ads_defconfig)
>
> Thanks
> Christophe
>
>> sh:
>> dreamcast_defconfig: with huge page OK
>> sparc:
>> sparc32_defconfig: without huge page OK
>> sparc64:
>> sparc64_defconfig: with huge page OK
>> x86:
>> with huge page OK
>>
>> Alex
>>
>> On 07/23/2018 02:00 PM, Michael Ellerman wrote:
>>> Alex Ghiti <alex@ghiti.fr> writes:
>>>
>>>> Does anyone have any suggestion about those patches ?
>>> Cross compiling it for some non-x86 arches would be a good start :)
>>>
>>> There are cross compilers available here:
>>>
>>> https://mirrors.edge.kernel.org/pub/tools/crosstool/
>>>
>>>
>>> cheers
>>>
>>>> On 07/09/2018 02:16 PM, Michal Hocko wrote:
>>>>> [CC hugetlb guys -
>>>>> http://lkml.kernel.org/r/20180705110716.3919-1-alex@ghiti.fr]
>>>>>
>>>>> On Thu 05-07-18 11:07:05, Alexandre Ghiti wrote:
>>>>>> In order to reduce copy/paste of functions across architectures
>>>>>> and then
>>>>>> make riscv hugetlb port (and future ports) simpler and smaller, this
>>>>>> patchset intends to factorize the numerous hugetlb primitives
>>>>>> that are
>>>>>> defined across all the architectures.
>>>>>>
>>>>>> Except for prepare_hugepage_range, this patchset moves the
>>>>>> versions that
>>>>>> are just pass-through to standard pte primitives into
>>>>>> asm-generic/hugetlb.h by using the same #ifdef semantic that can be
>>>>>> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***.
>>>>>>
>>>>>> s390 architecture has not been tackled in this serie since it
>>>>>> does not
>>>>>> use asm-generic/hugetlb.h at all.
>>>>>> powerpc could be factorized a bit more (cf huge_ptep_set_wrprotect).
>>>>>>
>>>>>> This patchset has been compiled on x86 only.
>>>>>>
>>>>>> Changelog:
>>>>>>
>>>>>> v4:
>>>>>> Fix powerpc build error due to misplacing of #include
>>>>>> <asm-generic/hugetlb.h> outside of #ifdef CONFIG_HUGETLB_PAGE, as
>>>>>> pointed by Christophe Leroy.
>>>>>>
>>>>>> v1, v2, v3:
>>>>>> Same version, just problems with email provider and misuse of
>>>>>> --batch-size option of git send-email
>>>>>>
>>>>>> Alexandre Ghiti (11):
>>>>>> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h
>>>>>> hugetlb: Introduce generic version of hugetlb_free_pgd_range
>>>>>> hugetlb: Introduce generic version of set_huge_pte_at
>>>>>> hugetlb: Introduce generic version of huge_ptep_get_and_clear
>>>>>> hugetlb: Introduce generic version of huge_ptep_clear_flush
>>>>>> hugetlb: Introduce generic version of huge_pte_none
>>>>>> hugetlb: Introduce generic version of huge_pte_wrprotect
>>>>>> hugetlb: Introduce generic version of prepare_hugepage_range
>>>>>> hugetlb: Introduce generic version of huge_ptep_set_wrprotect
>>>>>> hugetlb: Introduce generic version of huge_ptep_set_access_flags
>>>>>> hugetlb: Introduce generic version of huge_ptep_get
>>>>>>
>>>>>> arch/arm/include/asm/hugetlb-3level.h | 32 +---------
>>>>>> arch/arm/include/asm/hugetlb.h | 33 +----------
>>>>>> arch/arm64/include/asm/hugetlb.h | 39 +++---------
>>>>>> arch/ia64/include/asm/hugetlb.h | 47 ++-------------
>>>>>> arch/mips/include/asm/hugetlb.h | 40 +++----------
>>>>>> arch/parisc/include/asm/hugetlb.h | 33 +++--------
>>>>>> arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +
>>>>>> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 +
>>>>>> arch/powerpc/include/asm/hugetlb.h | 43 ++------------
>>>>>> arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +
>>>>>> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 +
>>>>>> arch/sh/include/asm/hugetlb.h | 54
>>>>>> ++---------------
>>>>>> arch/sparc/include/asm/hugetlb.h | 40 +++----------
>>>>>> arch/x86/include/asm/hugetlb.h | 72
>>>>>> +----------------------
>>>>>> include/asm-generic/hugetlb.h | 88
>>>>>> +++++++++++++++++++++++++++-
>>>>>> 15 files changed, 143 insertions(+), 384 deletions(-)
>>>>>>
>>>>>> --
>>>>>> 2.16.2
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Alex Ghiti <alex@ghiti.fr>
To: LEROY Christophe <christophe.leroy@c-s.fr>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
davem@davemloft.net, linuxppc-dev@lists.ozlabs.org,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
paul.burton@mips.com, ralf@linux-mips.org,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
tony.luck@intel.com, linux-arm-kernel@lists.infradead.org,
tglx@linutronix.de, arnd@arndb.de, fenghua.yu@intel.com,
jhogan@kernel.org, catalin.marinas@arm.com, mingo@redhat.com,
linux@armlinux.org.uk, x86@kernel.org, deller@gmx.de,
ysato@users.sourceforge.jp, linux-arch@vger.kernel.org,
sparclinux@vger.kernel.org, hpa@zytor.com, paulus@samba.org,
jejb@parisc-linux.org, will.deacon@arm.com,
linux-sh@vger.kernel.org, linux-ia64@vger.kernel.org,
dalias@libc.org, linux-mips@linux-mips.org,
Michal Hocko <mhocko@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives
Date: Thu, 26 Jul 2018 16:46:20 +0000 [thread overview]
Message-ID: <58887adf-1852-4291-08aa-a1dd2007326b@ghiti.fr> (raw)
Message-ID: <20180726164620.0AOGtyUbPKKP284I3xpfQVhe6jg48ls7ODVmLuVED9M@z> (raw)
In-Reply-To: <20180726171355.Horde.KlFUG9wXmbRDCiyhk5bHsw8@messagerie.si.c-s.fr>
Hi Christophe,
Sorry, I should have done it already: with and without huge page
activated, the build for mpc885_ads_defconfig is OK.
Thanks,
Alex
On 07/26/2018 03:13 PM, LEROY Christophe wrote:
> Alex Ghiti <alex@ghiti.fr> a écrit :
>
>> Hi everyone,
>>
>> This is the result of the build for all arches tackled in this series
>> rebased on 4.18-rc6:
>>
>> arm:
>> versatile_defconfig: without huge page OK
>> keystone_defconfig: with huge page OK
>> arm64:
>> defconfig: with huge page OK
>> ia64:
>> generic_defconfig: with huge page OK
>> mips:
>> Paul Burton tested cavium octeon with huge page OK
>> parisc:
>> generic-64bit_defconfig: with huge page does not link
>> generic-64bit_defconfig: without huge page does not link
>> BUT not because of this series, any feedback welcome.
>> powerpc:
>> ppc64_defconfig: without huge page OK
>> ppc64_defconfig: with huge page OK
>
> Can you also test ppc32 both with and without hugepage
> (mpc885_ads_defconfig)
>
> Thanks
> Christophe
>
>> sh:
>> dreamcast_defconfig: with huge page OK
>> sparc:
>> sparc32_defconfig: without huge page OK
>> sparc64:
>> sparc64_defconfig: with huge page OK
>> x86:
>> with huge page OK
>>
>> Alex
>>
>> On 07/23/2018 02:00 PM, Michael Ellerman wrote:
>>> Alex Ghiti <alex@ghiti.fr> writes:
>>>
>>>> Does anyone have any suggestion about those patches ?
>>> Cross compiling it for some non-x86 arches would be a good start :)
>>>
>>> There are cross compilers available here:
>>>
>>> https://mirrors.edge.kernel.org/pub/tools/crosstool/
>>>
>>>
>>> cheers
>>>
>>>> On 07/09/2018 02:16 PM, Michal Hocko wrote:
>>>>> [CC hugetlb guys -
>>>>> http://lkml.kernel.org/r/20180705110716.3919-1-alex@ghiti.fr]
>>>>>
>>>>> On Thu 05-07-18 11:07:05, Alexandre Ghiti wrote:
>>>>>> In order to reduce copy/paste of functions across architectures
>>>>>> and then
>>>>>> make riscv hugetlb port (and future ports) simpler and smaller, this
>>>>>> patchset intends to factorize the numerous hugetlb primitives
>>>>>> that are
>>>>>> defined across all the architectures.
>>>>>>
>>>>>> Except for prepare_hugepage_range, this patchset moves the
>>>>>> versions that
>>>>>> are just pass-through to standard pte primitives into
>>>>>> asm-generic/hugetlb.h by using the same #ifdef semantic that can be
>>>>>> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***.
>>>>>>
>>>>>> s390 architecture has not been tackled in this serie since it
>>>>>> does not
>>>>>> use asm-generic/hugetlb.h at all.
>>>>>> powerpc could be factorized a bit more (cf huge_ptep_set_wrprotect).
>>>>>>
>>>>>> This patchset has been compiled on x86 only.
>>>>>>
>>>>>> Changelog:
>>>>>>
>>>>>> v4:
>>>>>> Fix powerpc build error due to misplacing of #include
>>>>>> <asm-generic/hugetlb.h> outside of #ifdef CONFIG_HUGETLB_PAGE, as
>>>>>> pointed by Christophe Leroy.
>>>>>>
>>>>>> v1, v2, v3:
>>>>>> Same version, just problems with email provider and misuse of
>>>>>> --batch-size option of git send-email
>>>>>>
>>>>>> Alexandre Ghiti (11):
>>>>>> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h
>>>>>> hugetlb: Introduce generic version of hugetlb_free_pgd_range
>>>>>> hugetlb: Introduce generic version of set_huge_pte_at
>>>>>> hugetlb: Introduce generic version of huge_ptep_get_and_clear
>>>>>> hugetlb: Introduce generic version of huge_ptep_clear_flush
>>>>>> hugetlb: Introduce generic version of huge_pte_none
>>>>>> hugetlb: Introduce generic version of huge_pte_wrprotect
>>>>>> hugetlb: Introduce generic version of prepare_hugepage_range
>>>>>> hugetlb: Introduce generic version of huge_ptep_set_wrprotect
>>>>>> hugetlb: Introduce generic version of huge_ptep_set_access_flags
>>>>>> hugetlb: Introduce generic version of huge_ptep_get
>>>>>>
>>>>>> arch/arm/include/asm/hugetlb-3level.h | 32 +---------
>>>>>> arch/arm/include/asm/hugetlb.h | 33 +----------
>>>>>> arch/arm64/include/asm/hugetlb.h | 39 +++---------
>>>>>> arch/ia64/include/asm/hugetlb.h | 47 ++-------------
>>>>>> arch/mips/include/asm/hugetlb.h | 40 +++----------
>>>>>> arch/parisc/include/asm/hugetlb.h | 33 +++--------
>>>>>> arch/powerpc/include/asm/book3s/32/pgtable.h | 2 +
>>>>>> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 +
>>>>>> arch/powerpc/include/asm/hugetlb.h | 43 ++------------
>>>>>> arch/powerpc/include/asm/nohash/32/pgtable.h | 2 +
>>>>>> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 +
>>>>>> arch/sh/include/asm/hugetlb.h | 54
>>>>>> ++---------------
>>>>>> arch/sparc/include/asm/hugetlb.h | 40 +++----------
>>>>>> arch/x86/include/asm/hugetlb.h | 72
>>>>>> +----------------------
>>>>>> include/asm-generic/hugetlb.h | 88
>>>>>> +++++++++++++++++++++++++++-
>>>>>> 15 files changed, 143 insertions(+), 384 deletions(-)
>>>>>>
>>>>>> --
>>>>>> 2.16.2
>
>
next prev parent reply other threads:[~2018-07-26 16:46 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 11:07 [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-05 11:07 ` [PATCH v4 01/11] hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 18:40 ` Mike Kravetz
2018-07-26 18:40 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 18:45 ` Mike Kravetz
2018-07-26 18:45 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 03/11] hugetlb: Introduce generic version of set_huge_pte_at Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:00 ` Mike Kravetz
2018-07-26 19:00 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 04/11] hugetlb: Introduce generic version of huge_ptep_get_and_clear Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:02 ` Mike Kravetz
2018-07-26 19:02 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 05/11] hugetlb: Introduce generic version of huge_ptep_clear_flush Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:03 ` Mike Kravetz
2018-07-26 19:03 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 06/11] hugetlb: Introduce generic version of huge_pte_none Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:04 ` Mike Kravetz
2018-07-26 19:04 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 07/11] hugetlb: Introduce generic version of huge_pte_wrprotect Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:05 ` Mike Kravetz
2018-07-26 19:05 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 08/11] hugetlb: Introduce generic version of prepare_hugepage_range Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:05 ` Mike Kravetz
2018-07-26 19:05 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 09/11] hugetlb: Introduce generic version of huge_ptep_set_wrprotect Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:10 ` Mike Kravetz
2018-07-26 19:10 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 10/11] hugetlb: Introduce generic version of huge_ptep_set_access_flags Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:12 ` Mike Kravetz
2018-07-26 19:12 ` Mike Kravetz
2018-07-05 11:07 ` [PATCH v4 11/11] hugetlb: Introduce generic version of huge_ptep_get Alexandre Ghiti
2018-07-05 11:07 ` Alexandre Ghiti
2018-07-26 19:13 ` Mike Kravetz
2018-07-26 19:13 ` Mike Kravetz
2018-07-09 14:16 ` [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives Michal Hocko
2018-07-09 14:16 ` Michal Hocko
2018-07-20 18:37 ` Alex Ghiti
2018-07-20 18:37 ` Alex Ghiti
2018-07-21 0:24 ` Mike Kravetz
2018-07-21 0:24 ` Mike Kravetz
2018-07-26 11:46 ` Michael Ellerman
2018-07-26 11:46 ` Michael Ellerman
2018-07-26 19:16 ` Mike Kravetz
2018-07-26 19:16 ` Mike Kravetz
2018-07-27 6:51 ` Alexandre Ghiti
2018-07-27 6:51 ` Alexandre Ghiti
2018-07-23 14:00 ` Michael Ellerman
2018-07-23 14:00 ` Michael Ellerman
2018-07-23 17:41 ` Alex Ghiti
2018-07-23 17:41 ` Alex Ghiti
2018-07-26 5:41 ` Alex Ghiti
2018-07-26 5:41 ` Alex Ghiti
2018-07-26 12:59 ` Helge Deller
2018-07-26 12:59 ` Helge Deller
2018-07-26 17:01 ` Alex Ghiti
2018-07-26 17:01 ` Alex Ghiti
2018-07-26 19:13 ` Alex Ghiti
2018-07-26 19:13 ` Alex Ghiti
2018-07-26 21:08 ` Helge Deller
2018-07-26 21:08 ` Helge Deller
2018-07-26 15:13 ` LEROY Christophe
2018-07-26 15:13 ` LEROY Christophe
2018-07-26 16:46 ` Alex Ghiti [this message]
2018-07-26 16:46 ` Alex Ghiti
2018-07-25 0:34 ` Paul Burton
2018-07-25 0:34 ` Paul Burton
2018-07-25 7:38 ` Alexandre Ghiti
2018-07-25 7:38 ` Alexandre Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58887adf-1852-4291-08aa-a1dd2007326b@ghiti.fr \
--to=alex@ghiti.fr \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=christophe.leroy@c-s.fr \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jejb@parisc-linux.org \
--cc=jhogan@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=mingo@redhat.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).