From: Mike Kravetz <mike.kravetz@oracle.com> To: Alex Ghiti <alex@ghiti.fr>, Michal Hocko <mhocko@kernel.org> Cc: linux-mips@linux-mips.org, dalias@libc.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, benh@kernel.crashing.org, will.deacon@arm.com, jejb@parisc-linux.org, paulus@samba.org, hpa@zytor.com, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, ysato@users.sourceforge.jp, mpe@ellerman.id.au, deller@gmx.de, x86@kernel.org, linux@armlinux.org.uk, mingo@redhat.com, catalin.marinas@arm.com, jhogan@kernel.org, fenghua.yu@intel.com, arnd@arndb.de, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, tony.luck@intel.com, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, paul.burton@mips.com, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives Date: Fri, 20 Jul 2018 17:24:12 -0700 [thread overview] Message-ID: <75195a7d-3d0f-4e55-92cc-4ad772683c75@oracle.com> (raw) In-Reply-To: <2173685f-7f85-7acb-4685-2383210c5fa2@ghiti.fr> On 07/20/2018 11:37 AM, Alex Ghiti wrote: > Does anyone have any suggestion about those patches ? I only took a quick look. From the hugetlb perspective, I like the idea of moving routines to a common file. If any of the arch owners (or anyone else) agree, I can do a review of the series. -- Mike Kravetz > On 07/09/2018 02:16 PM, Michal Hocko wrote: >> [CC hugetlb guys - http://lkml.kernel.org/r/20180705110716.3919-1-alex@ghiti.fr] >> >> On Thu 05-07-18 11:07:05, Alexandre Ghiti wrote: >>> In order to reduce copy/paste of functions across architectures and then >>> make riscv hugetlb port (and future ports) simpler and smaller, this >>> patchset intends to factorize the numerous hugetlb primitives that are >>> defined across all the architectures. >>> >>> Except for prepare_hugepage_range, this patchset moves the versions that >>> are just pass-through to standard pte primitives into >>> asm-generic/hugetlb.h by using the same #ifdef semantic that can be >>> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***. >>> >>> s390 architecture has not been tackled in this serie since it does not >>> use asm-generic/hugetlb.h at all. >>> powerpc could be factorized a bit more (cf huge_ptep_set_wrprotect). >>> >>> This patchset has been compiled on x86 only. >>> >>> Changelog: >>> >>> v4: >>> Fix powerpc build error due to misplacing of #include >>> <asm-generic/hugetlb.h> outside of #ifdef CONFIG_HUGETLB_PAGE, as >>> pointed by Christophe Leroy. >>> >>> v1, v2, v3: >>> Same version, just problems with email provider and misuse of >>> --batch-size option of git send-email >>> >>> Alexandre Ghiti (11): >>> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h >>> hugetlb: Introduce generic version of hugetlb_free_pgd_range >>> hugetlb: Introduce generic version of set_huge_pte_at >>> hugetlb: Introduce generic version of huge_ptep_get_and_clear >>> hugetlb: Introduce generic version of huge_ptep_clear_flush >>> hugetlb: Introduce generic version of huge_pte_none >>> hugetlb: Introduce generic version of huge_pte_wrprotect >>> hugetlb: Introduce generic version of prepare_hugepage_range >>> hugetlb: Introduce generic version of huge_ptep_set_wrprotect >>> hugetlb: Introduce generic version of huge_ptep_set_access_flags >>> hugetlb: Introduce generic version of huge_ptep_get >>> >>> arch/arm/include/asm/hugetlb-3level.h | 32 +--------- >>> arch/arm/include/asm/hugetlb.h | 33 +---------- >>> arch/arm64/include/asm/hugetlb.h | 39 +++--------- >>> arch/ia64/include/asm/hugetlb.h | 47 ++------------- >>> arch/mips/include/asm/hugetlb.h | 40 +++---------- >>> arch/parisc/include/asm/hugetlb.h | 33 +++-------- >>> arch/powerpc/include/asm/book3s/32/pgtable.h | 2 + >>> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 + >>> arch/powerpc/include/asm/hugetlb.h | 43 ++------------ >>> arch/powerpc/include/asm/nohash/32/pgtable.h | 2 + >>> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 + >>> arch/sh/include/asm/hugetlb.h | 54 ++--------------- >>> arch/sparc/include/asm/hugetlb.h | 40 +++---------- >>> arch/x86/include/asm/hugetlb.h | 72 +---------------------- >>> include/asm-generic/hugetlb.h | 88 +++++++++++++++++++++++++++- >>> 15 files changed, 143 insertions(+), 384 deletions(-) >>> >>> -- >>> 2.16.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com> To: Alex Ghiti <alex@ghiti.fr>, Michal Hocko <mhocko@kernel.org> Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, tony.luck@intel.com, fenghua.yu@intel.com, ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org, jejb@parisc-linux.org, deller@gmx.de, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@linux-mips.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> Subject: Re: [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives Date: Fri, 20 Jul 2018 17:24:12 -0700 [thread overview] Message-ID: <75195a7d-3d0f-4e55-92cc-4ad772683c75@oracle.com> (raw) Message-ID: <20180721002412.huT4UWrD4rd2JQihK-NOP5a0WMA8IDBdUvOSLLxttEY@z> (raw) In-Reply-To: <2173685f-7f85-7acb-4685-2383210c5fa2@ghiti.fr> On 07/20/2018 11:37 AM, Alex Ghiti wrote: > Does anyone have any suggestion about those patches ? I only took a quick look. From the hugetlb perspective, I like the idea of moving routines to a common file. If any of the arch owners (or anyone else) agree, I can do a review of the series. -- Mike Kravetz > On 07/09/2018 02:16 PM, Michal Hocko wrote: >> [CC hugetlb guys - http://lkml.kernel.org/r/20180705110716.3919-1-alex@ghiti.fr] >> >> On Thu 05-07-18 11:07:05, Alexandre Ghiti wrote: >>> In order to reduce copy/paste of functions across architectures and then >>> make riscv hugetlb port (and future ports) simpler and smaller, this >>> patchset intends to factorize the numerous hugetlb primitives that are >>> defined across all the architectures. >>> >>> Except for prepare_hugepage_range, this patchset moves the versions that >>> are just pass-through to standard pte primitives into >>> asm-generic/hugetlb.h by using the same #ifdef semantic that can be >>> found in asm-generic/pgtable.h, i.e. __HAVE_ARCH_***. >>> >>> s390 architecture has not been tackled in this serie since it does not >>> use asm-generic/hugetlb.h at all. >>> powerpc could be factorized a bit more (cf huge_ptep_set_wrprotect). >>> >>> This patchset has been compiled on x86 only. >>> >>> Changelog: >>> >>> v4: >>> Fix powerpc build error due to misplacing of #include >>> <asm-generic/hugetlb.h> outside of #ifdef CONFIG_HUGETLB_PAGE, as >>> pointed by Christophe Leroy. >>> >>> v1, v2, v3: >>> Same version, just problems with email provider and misuse of >>> --batch-size option of git send-email >>> >>> Alexandre Ghiti (11): >>> hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h >>> hugetlb: Introduce generic version of hugetlb_free_pgd_range >>> hugetlb: Introduce generic version of set_huge_pte_at >>> hugetlb: Introduce generic version of huge_ptep_get_and_clear >>> hugetlb: Introduce generic version of huge_ptep_clear_flush >>> hugetlb: Introduce generic version of huge_pte_none >>> hugetlb: Introduce generic version of huge_pte_wrprotect >>> hugetlb: Introduce generic version of prepare_hugepage_range >>> hugetlb: Introduce generic version of huge_ptep_set_wrprotect >>> hugetlb: Introduce generic version of huge_ptep_set_access_flags >>> hugetlb: Introduce generic version of huge_ptep_get >>> >>> arch/arm/include/asm/hugetlb-3level.h | 32 +--------- >>> arch/arm/include/asm/hugetlb.h | 33 +---------- >>> arch/arm64/include/asm/hugetlb.h | 39 +++--------- >>> arch/ia64/include/asm/hugetlb.h | 47 ++------------- >>> arch/mips/include/asm/hugetlb.h | 40 +++---------- >>> arch/parisc/include/asm/hugetlb.h | 33 +++-------- >>> arch/powerpc/include/asm/book3s/32/pgtable.h | 2 + >>> arch/powerpc/include/asm/book3s/64/pgtable.h | 1 + >>> arch/powerpc/include/asm/hugetlb.h | 43 ++------------ >>> arch/powerpc/include/asm/nohash/32/pgtable.h | 2 + >>> arch/powerpc/include/asm/nohash/64/pgtable.h | 1 + >>> arch/sh/include/asm/hugetlb.h | 54 ++--------------- >>> arch/sparc/include/asm/hugetlb.h | 40 +++---------- >>> arch/x86/include/asm/hugetlb.h | 72 +---------------------- >>> include/asm-generic/hugetlb.h | 88 +++++++++++++++++++++++++++- >>> 15 files changed, 143 insertions(+), 384 deletions(-) >>> >>> -- >>> 2.16.2 >
next prev parent reply other threads:[~2018-07-21 0:24 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-05 11:07 [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-05 11:07 ` [PATCH v4 01/11] hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 18:40 ` Mike Kravetz 2018-07-26 18:40 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 18:45 ` Mike Kravetz 2018-07-26 18:45 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 03/11] hugetlb: Introduce generic version of set_huge_pte_at Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:00 ` Mike Kravetz 2018-07-26 19:00 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 04/11] hugetlb: Introduce generic version of huge_ptep_get_and_clear Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:02 ` Mike Kravetz 2018-07-26 19:02 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 05/11] hugetlb: Introduce generic version of huge_ptep_clear_flush Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:03 ` Mike Kravetz 2018-07-26 19:03 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 06/11] hugetlb: Introduce generic version of huge_pte_none Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:04 ` Mike Kravetz 2018-07-26 19:04 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 07/11] hugetlb: Introduce generic version of huge_pte_wrprotect Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:05 ` Mike Kravetz 2018-07-26 19:05 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 08/11] hugetlb: Introduce generic version of prepare_hugepage_range Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:05 ` Mike Kravetz 2018-07-26 19:05 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 09/11] hugetlb: Introduce generic version of huge_ptep_set_wrprotect Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:10 ` Mike Kravetz 2018-07-26 19:10 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 10/11] hugetlb: Introduce generic version of huge_ptep_set_access_flags Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:12 ` Mike Kravetz 2018-07-26 19:12 ` Mike Kravetz 2018-07-05 11:07 ` [PATCH v4 11/11] hugetlb: Introduce generic version of huge_ptep_get Alexandre Ghiti 2018-07-05 11:07 ` Alexandre Ghiti 2018-07-26 19:13 ` Mike Kravetz 2018-07-26 19:13 ` Mike Kravetz 2018-07-09 14:16 ` [PATCH v4 00/11] hugetlb: Factorize hugetlb architecture primitives Michal Hocko 2018-07-09 14:16 ` Michal Hocko 2018-07-20 18:37 ` Alex Ghiti 2018-07-20 18:37 ` Alex Ghiti 2018-07-21 0:24 ` Mike Kravetz [this message] 2018-07-21 0:24 ` Mike Kravetz 2018-07-26 11:46 ` Michael Ellerman 2018-07-26 11:46 ` Michael Ellerman 2018-07-26 19:16 ` Mike Kravetz 2018-07-26 19:16 ` Mike Kravetz 2018-07-27 6:51 ` Alexandre Ghiti 2018-07-27 6:51 ` Alexandre Ghiti 2018-07-23 14:00 ` Michael Ellerman 2018-07-23 14:00 ` Michael Ellerman 2018-07-23 17:41 ` Alex Ghiti 2018-07-23 17:41 ` Alex Ghiti 2018-07-26 5:41 ` Alex Ghiti 2018-07-26 5:41 ` Alex Ghiti 2018-07-26 12:59 ` Helge Deller 2018-07-26 12:59 ` Helge Deller 2018-07-26 17:01 ` Alex Ghiti 2018-07-26 17:01 ` Alex Ghiti 2018-07-26 19:13 ` Alex Ghiti 2018-07-26 19:13 ` Alex Ghiti 2018-07-26 21:08 ` Helge Deller 2018-07-26 21:08 ` Helge Deller 2018-07-26 15:13 ` LEROY Christophe 2018-07-26 15:13 ` LEROY Christophe 2018-07-26 16:46 ` Alex Ghiti 2018-07-26 16:46 ` Alex Ghiti 2018-07-25 0:34 ` Paul Burton 2018-07-25 0:34 ` Paul Burton 2018-07-25 7:38 ` Alexandre Ghiti 2018-07-25 7:38 ` Alexandre Ghiti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=75195a7d-3d0f-4e55-92cc-4ad772683c75@oracle.com \ --to=mike.kravetz@oracle.com \ --cc=alex@ghiti.fr \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=catalin.marinas@arm.com \ --cc=dalias@libc.org \ --cc=davem@davemloft.net \ --cc=deller@gmx.de \ --cc=fenghua.yu@intel.com \ --cc=hpa@zytor.com \ --cc=jejb@parisc-linux.org \ --cc=jhogan@kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mhocko@kernel.org \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=n-horiguchi@ah.jp.nec.com \ --cc=paul.burton@mips.com \ --cc=paulus@samba.org \ --cc=ralf@linux-mips.org \ --cc=sparclinux@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=tony.luck@intel.com \ --cc=will.deacon@arm.com \ --cc=x86@kernel.org \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).