From: Arnd Bergmann <arnd@arndb.de>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: David Miller <davem@davemloft.net>,
sparclinux <sparclinux@vger.kernel.org>,
gregkh <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header
Date: Mon, 24 Sep 2018 23:06:25 +0200 [thread overview]
Message-ID: <CAK8P3a0_omFwid2NZzs_T=A_TY9ddfGOsVKV2vtiaVodWswbmQ@mail.gmail.com> (raw)
In-Reply-To: <CALxhOngCL4DEcMD7NaxbUiksByzoxaaozzZGPmB0JFziFEWojw@mail.gmail.com>
On Tue, Sep 18, 2018 at 1:53 PM Firoz Khan <firoz.khan@linaro.org> wrote:
>
> On 6 September 2018 at 20:58, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Tue, Sep 4, 2018 at 6:42 AM Firoz Khan <firoz.khan@linaro.org> wrote:
> >
> >> +++ b/arch/sparc/include/uapi/asm/unistd.h
> >> @@ -15,12 +15,6 @@
> >> #ifndef _UAPI_SPARC_UNISTD_H
> >> #define _UAPI_SPARC_UNISTD_H
> >>
> >> -#ifndef __32bit_syscall_numbers__
> >> -#ifndef __arch64__
> >> -#define __32bit_syscall_numbers__
> >> -#endif
> >> -#endif
> >
> > This is certainly required in the uapi header as of this patch,
> > without it all the numbers are wrong when you include the
> > file from user space.
> >
> > I suppose it can be removed later once the header is replaced
> > with the two generated versions,
>
> The script will generate 2 versions, ie, unistd_32.h and unistd_64.h.
> Please give few more pointer here.
You still need to check at least for __arch64__ in asm/unistd.h in order
to pick which header to include, right? Since the
__32bit_syscall_numbers__ check was already in the public header
file, it may also be possible that there is some user space application
that sets this in order to get the 32-bit definitions. This might e.g.
be needed for strace.
Arnd
next prev parent reply other threads:[~2018-09-24 21:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 4:41 [PATCH 0/4] System call table generation support Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-04 4:41 ` [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:28 ` Arnd Bergmann
2018-09-06 15:28 ` Arnd Bergmann
2018-09-18 11:53 ` Firoz Khan
2018-09-18 11:53 ` Firoz Khan
2018-09-24 21:06 ` Arnd Bergmann [this message]
2018-09-24 21:06 ` Arnd Bergmann
2018-09-06 19:09 ` kbuild test robot
2018-09-06 19:09 ` kbuild test robot
2018-09-04 4:41 ` [PATCH 2/4] sparc: Replace NR_SYSCALLS macro with __NR_SYSCALLS Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:29 ` Arnd Bergmann
2018-09-06 15:29 ` Arnd Bergmann
2018-09-18 9:45 ` Firoz Khan
2018-09-18 9:45 ` Firoz Khan
2018-09-04 4:41 ` [PATCH 3/4] sparc: Add system call table generation support Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:32 ` Arnd Bergmann
2018-09-06 15:32 ` Arnd Bergmann
2018-09-18 11:37 ` Firoz Khan
2018-09-18 11:37 ` Firoz Khan
2018-09-04 4:41 ` [PATCH 4/4] sparc: uapi header and system call table file generation Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:34 ` Arnd Bergmann
2018-09-06 15:34 ` Arnd Bergmann
2018-09-18 11:45 ` Firoz Khan
2018-09-18 11:45 ` Firoz Khan
2018-09-06 21:12 ` kbuild test robot
2018-09-06 21:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a0_omFwid2NZzs_T=A_TY9ddfGOsVKV2vtiaVodWswbmQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).