linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Firoz Khan <firoz.khan@linaro.org>
To: "David S . Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kate Stewart <kstewart@linuxfoundation.org>
Cc: y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, arnd@arndb.de,
	deepa.kernel@gmail.com, marcin.juszkiewicz@linaro.org,
	firoz.khan@linaro.org
Subject: [PATCH 2/4] sparc: Replace NR_SYSCALLS macro with __NR_SYSCALLS
Date: Tue,  4 Sep 2018 10:11:25 +0530	[thread overview]
Message-ID: <1536036087-15260-3-git-send-email-firoz.khan@linaro.org> (raw)
Message-ID: <20180904044125.atsmP8QUQd-qA2PLGsiWsSrATYHzHv9H4V9iEnUja4w@z> (raw)
In-Reply-To: <1536036087-15260-1-git-send-email-firoz.khan@linaro.org>

NR_syscalls macro holds the number of system call exist in SPARC
architecture. This macro is currently the part of uapi/asm/unistd.h
file. We have to change the value of NR_syscalls, if we add or
delete a system call.

One of the patch in this patch series has a script which will generate
a uapi header based on syscall.tbl file. The syscall.tbl file contains
the number of system call information. So we have two option to update
NR_syscalls value.

1. Update NR_syscalls in uapi/asm/unistd.h manually by counting the
   no.of system calls. No need to update NR_syscalls until we either
   add a new system call or delete an existing system call.

2. We can keep this feature it above mentioned script, that'll
   count the number of syscalls and keep it in a generated file.
   In this case we don't need to explicitly update NR_syscalls
   in asm/unistd.h file.

The 2nd option will be the recommended one. For that, I moved the
NR_syscalls macro from uapi/asm/unistd.h to asm/unistd.h. The macro
name also changed form NR_syscalls to __NR_syscalls for making the
name convention same across all architecture. While __NR_syscalls
isn't strictly part of the uapi, having it as part of the generated
header to simplifies the implementation.

Signed-off-by: Firoz Khan <firoz.khan@linaro.org>
---
 arch/sparc/include/asm/unistd.h      | 2 ++
 arch/sparc/include/uapi/asm/unistd.h | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/sparc/include/asm/unistd.h b/arch/sparc/include/asm/unistd.h
index f120b6b..c8849b7 100644
--- a/arch/sparc/include/asm/unistd.h
+++ b/arch/sparc/include/asm/unistd.h
@@ -17,6 +17,8 @@
 
 #include <uapi/asm/unistd.h>
 
+#define NR_syscalls __NR_syscalls
+
 #ifndef __32bit_syscall_numbers__
 #ifndef __arch64__
 #define __32bit_syscall_numbers__
diff --git a/arch/sparc/include/uapi/asm/unistd.h b/arch/sparc/include/uapi/asm/unistd.h
index ccf4bea..e2407b4 100644
--- a/arch/sparc/include/uapi/asm/unistd.h
+++ b/arch/sparc/include/uapi/asm/unistd.h
@@ -422,6 +422,6 @@
 #define __NR_pwritev2		359
 #define __NR_statx		360
 
-#define NR_syscalls		361
+#define __NR_syscalls		361
 
 #endif /* _UAPI_SPARC_UNISTD_H */
-- 
1.9.1

  parent reply	other threads:[~2018-09-04  9:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04  4:41 [PATCH 0/4] System call table generation support Firoz Khan
2018-09-04  4:41 ` Firoz Khan
2018-09-04  4:41 ` [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header Firoz Khan
2018-09-04  4:41   ` Firoz Khan
2018-09-06 15:28   ` Arnd Bergmann
2018-09-06 15:28     ` Arnd Bergmann
2018-09-18 11:53     ` Firoz Khan
2018-09-18 11:53       ` Firoz Khan
2018-09-24 21:06       ` Arnd Bergmann
2018-09-24 21:06         ` Arnd Bergmann
2018-09-06 19:09   ` kbuild test robot
2018-09-06 19:09     ` kbuild test robot
2018-09-04  4:41 ` Firoz Khan [this message]
2018-09-04  4:41   ` [PATCH 2/4] sparc: Replace NR_SYSCALLS macro with __NR_SYSCALLS Firoz Khan
2018-09-06 15:29   ` Arnd Bergmann
2018-09-06 15:29     ` Arnd Bergmann
2018-09-18  9:45     ` Firoz Khan
2018-09-18  9:45       ` Firoz Khan
2018-09-04  4:41 ` [PATCH 3/4] sparc: Add system call table generation support Firoz Khan
2018-09-04  4:41   ` Firoz Khan
2018-09-06 15:32   ` Arnd Bergmann
2018-09-06 15:32     ` Arnd Bergmann
2018-09-18 11:37     ` Firoz Khan
2018-09-18 11:37       ` Firoz Khan
2018-09-04  4:41 ` [PATCH 4/4] sparc: uapi header and system call table file generation Firoz Khan
2018-09-04  4:41   ` Firoz Khan
2018-09-06 15:34   ` Arnd Bergmann
2018-09-06 15:34     ` Arnd Bergmann
2018-09-18 11:45     ` Firoz Khan
2018-09-18 11:45       ` Firoz Khan
2018-09-06 21:12   ` kbuild test robot
2018-09-06 21:12     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1536036087-15260-3-git-send-email-firoz.khan@linaro.org \
    --to=firoz.khan@linaro.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=deepa.kernel@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pombredanne@nexb.com \
    --cc=sparclinux@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).