From: Arnd Bergmann <arnd@arndb.de>
To: Firoz Khan <firoz.khan@linaro.org>
Cc: David Miller <davem@davemloft.net>,
sparclinux <sparclinux@vger.kernel.org>,
gregkh <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header
Date: Thu, 6 Sep 2018 17:28:24 +0200 [thread overview]
Message-ID: <CAK8P3a1JCnSPi+D+CozhqL0dS9WwXtONDHp4=Kg5kCHrpdYwrw@mail.gmail.com> (raw)
In-Reply-To: <1536036087-15260-2-git-send-email-firoz.khan@linaro.org>
On Tue, Sep 4, 2018 at 6:42 AM Firoz Khan <firoz.khan@linaro.org> wrote:
> +++ b/arch/sparc/include/uapi/asm/unistd.h
> @@ -15,12 +15,6 @@
> #ifndef _UAPI_SPARC_UNISTD_H
> #define _UAPI_SPARC_UNISTD_H
>
> -#ifndef __32bit_syscall_numbers__
> -#ifndef __arch64__
> -#define __32bit_syscall_numbers__
> -#endif
> -#endif
This is certainly required in the uapi header as of this patch,
without it all the numbers are wrong when you include the
file from user space.
I suppose it can be removed later once the header is replaced
with the two generated versions,
> -/* Bitmask values returned from kern_features system call. */
> -#define KERN_FEATURE_MIXED_MODE_STACK 0x00000001
I'm fairly sure this also needs to remain in the uapi/asm/unistd.h header
as a start, so that user space can call the sys_kern_features() system
call and interpret its result when only the first patch is applied.
> -#ifdef __32bit_syscall_numbers__
> -/* Sparc 32-bit only has the "setresuid32", "getresuid32" variants,
> - * it never had the plain ones and there is no value to adding those
> - * old versions into the syscall table.
> - */
> -#define __IGNORE_setresuid
> -#define __IGNORE_getresuid
> -#define __IGNORE_setresgid
> -#define __IGNORE_getresgid
> -#endif
> -
> -/* Sparc doesn't have protection keys. */
> -#define __IGNORE_pkey_mprotect
> -#define __IGNORE_pkey_alloc
> -#define __IGNORE_pkey_free
> -
This part is fine.
Arnd
next prev parent reply other threads:[~2018-09-06 15:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 4:41 [PATCH 0/4] System call table generation support Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-04 4:41 ` [PATCH 1/4] sparc: Move __IGNORE* entries to non uapi header Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:28 ` Arnd Bergmann [this message]
2018-09-06 15:28 ` Arnd Bergmann
2018-09-18 11:53 ` Firoz Khan
2018-09-18 11:53 ` Firoz Khan
2018-09-24 21:06 ` Arnd Bergmann
2018-09-24 21:06 ` Arnd Bergmann
2018-09-06 19:09 ` kbuild test robot
2018-09-06 19:09 ` kbuild test robot
2018-09-04 4:41 ` [PATCH 2/4] sparc: Replace NR_SYSCALLS macro with __NR_SYSCALLS Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:29 ` Arnd Bergmann
2018-09-06 15:29 ` Arnd Bergmann
2018-09-18 9:45 ` Firoz Khan
2018-09-18 9:45 ` Firoz Khan
2018-09-04 4:41 ` [PATCH 3/4] sparc: Add system call table generation support Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:32 ` Arnd Bergmann
2018-09-06 15:32 ` Arnd Bergmann
2018-09-18 11:37 ` Firoz Khan
2018-09-18 11:37 ` Firoz Khan
2018-09-04 4:41 ` [PATCH 4/4] sparc: uapi header and system call table file generation Firoz Khan
2018-09-04 4:41 ` Firoz Khan
2018-09-06 15:34 ` Arnd Bergmann
2018-09-06 15:34 ` Arnd Bergmann
2018-09-18 11:45 ` Firoz Khan
2018-09-18 11:45 ` Firoz Khan
2018-09-06 21:12 ` kbuild test robot
2018-09-06 21:12 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a1JCnSPi+D+CozhqL0dS9WwXtONDHp4=Kg5kCHrpdYwrw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=firoz.khan@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).