From: "Jan Kundrát" <jan.kundrat@cesnet.cz>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Baruch Siach <baruch@tkos.co.il>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
Date: Sat, 18 May 2019 00:50:28 +0200 [thread overview]
Message-ID: <0609d750-de5e-49cb-97b5-43772c5bbe0d@cesnet.cz> (raw)
In-Reply-To: <87mujkzwkr.fsf@FE-laptop>
> Well, this is just about configuration, I don't consider this is
> something that is a candidate for a fix.
>
> If there is a regression, then, it is maybe located in the Kconfig
> dependency.
>
> Of course I can change my mind with good arguments :)
Hi Gregory,
I agree that it's just a config bug, but it's also something which can
silently produce broken systems. If this is not fixed, people building
their 5.2 kernels will not have working network on Clearfog unless they
take an extra action. For example, a Buildroot defconfig that's been
available for quite some time (and which uses just `mvebu_v7_defconfig` for
kernel) suddenly becomes broken.
Isn't the whole point of the -rc release to find *and* fix bugs early? This
trivial patch does not introduce any new or untested code. I made a choice
to test a pre-release kernel, I hit a bug -- no big deal. I found the root
cause, I sent a trivial fix upstream, and now I'm told by a maintainer that
they will let the next kernel version, which is about seven -rc releases
away, be released without a fully functioning network, I am surprised by
that. I would have understood this better if we were at the final -rc
stage, but during the merge window? Or is that perhaps a misunderstanding
and you're planning to send this in time after -rc1?
Cheers,
Jan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-17 22:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 15:01 [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog Jan Kundrát
2019-05-17 19:31 ` Gregory CLEMENT
2019-05-17 19:34 ` Jan Kundrát
2019-05-17 19:53 ` Gregory CLEMENT
2019-05-17 22:50 ` Jan Kundrát [this message]
2019-05-27 15:57 ` Jan Kundrát
2019-06-11 11:28 ` Gregory CLEMENT
2019-06-11 14:15 ` Jan Kundrát
2019-06-11 14:32 ` Russell King - ARM Linux admin
2019-06-11 15:04 ` Gregory CLEMENT
2019-06-11 15:12 ` Jan Kundrát
2019-06-11 15:31 ` Russell King - ARM Linux admin
2019-06-11 15:36 ` Jan Kundrát
2019-06-12 8:44 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0609d750-de5e-49cb-97b5-43772c5bbe0d@cesnet.cz \
--to=jan.kundrat@cesnet.cz \
--cc=baruch@tkos.co.il \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime.chevallier@bootlin.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).