Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Jan Kundrát" <jan.kundrat@cesnet.cz>
Cc: Baruch Siach <baruch@tkos.co.il>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog
Date: Tue, 11 Jun 2019 13:28:32 +0200
Message-ID: <87wohspdi7.fsf@FE-laptop> (raw)
In-Reply-To: <0f5e7886-f722-44ac-b64f-1f372a52938d@cesnet.cz>

Jan Kundrát <jan.kundrat@cesnet.cz> writes:

> On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote:
>>> Well, this is just about configuration, I don't consider this is
>>> something that is a candidate for a fix.
>>> 
>>> If there is a regression, then, it is maybe located in the Kconfig
>>> dependency.
>>> 
>>> Of course I can change my mind with good arguments :)
>>
>> Hi Gregory,
>> I agree that it's just a config bug, but it's also something 
>> which can silently produce broken systems. If this is not fixed, 
>> people building their 5.2 kernels will not have working network 
>> on Clearfog unless they take an extra action. For example, a 
>> Buildroot defconfig that's been available for quite some time 
>> (and which uses just `mvebu_v7_defconfig` for kernel) suddenly 
>> becomes broken.
>>
>> Isn't the whole point of the -rc release to find *and* fix bugs 
>> early? This trivial patch does not introduce any new or untested 
>> code. I made a choice to test a pre-release kernel, I hit a bug 
>> -- no big deal. I found the root cause, I sent a trivial fix 
>> upstream, and now I'm told by a maintainer that they will let 
>> the next kernel version, which is about seven -rc releases away, 
>> be released without a fully functioning network, I am surprised 
>> by that. I would have understood this better if we were at the 
>> final -rc stage, but during the merge window? Or is that perhaps 
>> a misunderstanding and you're planning to send this in time 
>> after -rc1?
>
> Hi Gregory,
> was I successful in persuading you that this patch should be included in 
> the 5.2 tree, so that Clearfog Base has all three Ethernet interfaces?

Finally I moved the commit from mvebu/arm to mvebu/fixes. I still think
the problem is at driver level, but I didn't take enough time to find
where and we didn't have any feedback from the author of the initila
patch.

So let's try to push it to fixes, I will do the pull request for arm-soc
before end of the week.

Gregory

>
> With kind regards,
> Jan

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 15:01 Jan Kundrát
2019-05-17 19:31 ` Gregory CLEMENT
2019-05-17 19:34   ` Jan Kundrát
2019-05-17 19:53     ` Gregory CLEMENT
2019-05-17 22:50       ` Jan Kundrát
2019-05-27 15:57         ` Jan Kundrát
2019-06-11 11:28           ` Gregory CLEMENT [this message]
2019-06-11 14:15             ` Jan Kundrát
2019-06-11 14:32             ` Russell King - ARM Linux admin
2019-06-11 15:04               ` Gregory CLEMENT
2019-06-11 15:12                 ` Jan Kundrát
2019-06-11 15:31                   ` Russell King - ARM Linux admin
2019-06-11 15:36                     ` Jan Kundrát
2019-06-12  8:44                       ` Gregory CLEMENT

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wohspdi7.fsf@FE-laptop \
    --to=gregory.clement@bootlin.com \
    --cc=baruch@tkos.co.il \
    --cc=davem@davemloft.net \
    --cc=jan.kundrat@cesnet.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox