From: Russell King - ARM Linux admin <linux@armlinux.org.uk> To: Gregory CLEMENT <gregory.clement@bootlin.com> Cc: "Jan Kundrát" <jan.kundrat@cesnet.cz>, "Maxime Chevallier" <maxime.chevallier@bootlin.com>, "Baruch Siach" <baruch@tkos.co.il>, linux-arm-kernel@lists.infradead.org, "David S. Miller" <davem@davemloft.net> Subject: Re: [PATCH] ARM: mvebu_v7_defconfig: fix Ethernet on Clearfog Date: Tue, 11 Jun 2019 15:32:39 +0100 Message-ID: <20190611143239.3v2cpg5o4u5gxzzw@shell.armlinux.org.uk> (raw) In-Reply-To: <87wohspdi7.fsf@FE-laptop> On Tue, Jun 11, 2019 at 01:28:32PM +0200, Gregory CLEMENT wrote: > Jan Kundrát <jan.kundrat@cesnet.cz> writes: > > > On sobota 18. května 2019 0:50:28 CEST, Jan Kundrát wrote: > >>> Well, this is just about configuration, I don't consider this is > >>> something that is a candidate for a fix. > >>> > >>> If there is a regression, then, it is maybe located in the Kconfig > >>> dependency. > >>> > >>> Of course I can change my mind with good arguments :) > >> > >> Hi Gregory, > >> I agree that it's just a config bug, but it's also something > >> which can silently produce broken systems. If this is not fixed, > >> people building their 5.2 kernels will not have working network > >> on Clearfog unless they take an extra action. For example, a > >> Buildroot defconfig that's been available for quite some time > >> (and which uses just `mvebu_v7_defconfig` for kernel) suddenly > >> becomes broken. > >> > >> Isn't the whole point of the -rc release to find *and* fix bugs > >> early? This trivial patch does not introduce any new or untested > >> code. I made a choice to test a pre-release kernel, I hit a bug > >> -- no big deal. I found the root cause, I sent a trivial fix > >> upstream, and now I'm told by a maintainer that they will let > >> the next kernel version, which is about seven -rc releases away, > >> be released without a fully functioning network, I am surprised > >> by that. I would have understood this better if we were at the > >> final -rc stage, but during the merge window? Or is that perhaps > >> a misunderstanding and you're planning to send this in time > >> after -rc1? > > > > Hi Gregory, > > was I successful in persuading you that this patch should be included in > > the 5.2 tree, so that Clearfog Base has all three Ethernet interfaces? > > Finally I moved the commit from mvebu/arm to mvebu/fixes. I still think > the problem is at driver level, but I didn't take enough time to find > where and we didn't have any feedback from the author of the initila > patch. I don't see that there's much that I need to say, and I'm at a total loss to work out why you think it's a problem at driver level. Why do you think it's appropriate for mvneta to know whether the a38x comphy driver is configured for the current kernel or not, given that mvneta is not exclusively used on Armada 38x systems? We're already doing the best we can do with ignoring the comphy if not present; the only case that we defer probe is when devm_of_phy_get() returns -EPROBE_DEFER, which could mean "the comphy driver is a module but is not loaded yet" or "the comphy driver has not been probed yet" - we can't ignore those. > So let's try to push it to fixes, I will do the pull request for arm-soc > before end of the week. That's the correct solution, and it should also have a Fixes: tag on it. Unfortunately, keeping the defconfigs up to date is quite a hard problem unless you have lots of computing power to build and boot all the defconfigs on all platforms (I don't.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-17 15:01 Jan Kundrát 2019-05-17 19:31 ` Gregory CLEMENT 2019-05-17 19:34 ` Jan Kundrát 2019-05-17 19:53 ` Gregory CLEMENT 2019-05-17 22:50 ` Jan Kundrát 2019-05-27 15:57 ` Jan Kundrát 2019-06-11 11:28 ` Gregory CLEMENT 2019-06-11 14:15 ` Jan Kundrát 2019-06-11 14:32 ` Russell King - ARM Linux admin [this message] 2019-06-11 15:04 ` Gregory CLEMENT 2019-06-11 15:12 ` Jan Kundrát 2019-06-11 15:31 ` Russell King - ARM Linux admin 2019-06-11 15:36 ` Jan Kundrát 2019-06-12 8:44 ` Gregory CLEMENT
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190611143239.3v2cpg5o4u5gxzzw@shell.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=baruch@tkos.co.il \ --cc=davem@davemloft.net \ --cc=gregory.clement@bootlin.com \ --cc=jan.kundrat@cesnet.cz \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=maxime.chevallier@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git