[PATCH v3 0/4] Correct vendor-prefix and document device isl29028

[PATCH v3 0/4] Correct vendor-prefix and document device isl29028

[Darshana Padmadas]

Patchset documents correct and the deprecated vendor-prefix found by checkpatch 
warning and also documents information of device isl29028 for compatibility. 
Patchset also includes corrected vendor-prefix and device name in compatible 
property for files with checkpatch warning of undocumented string "isil,isl29028". 

Darshana Padmadas (4):
  Documentation: devicetree: bindings: Document correct and deprecated
    vendor-prefix with device isl29028
  Documentation: devicetree: bindings: Document deprecated device vendor
    name to fix related warning
  Staging: iio: light: Added correct vendor-prefix for device isl29028
  arch: arm: boot: dts: Added correct vendor-prefix with device name to
    compatible property  
  
Changes in v3: 
    - In PATCH 1/4 corrected alphabetical order of vendor-prefix and device name. 
    - In PATCH 2/4 inserted deprecated vendor-prefix in list in alphabetical order 
      and edited vendor/chip string. 
    - In PATCH 4/4 dropped deprecated string "isil,isl29028" and included correct 
      vendor-prefix isl with isl29028 to give "isl,isl29028" for device's compatible 
      property.
      
 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
 Documentation/devicetree/bindings/vendor-prefixes.txt     | 1 +
 drivers/staging/iio/light/isl29028.c                      | 3 ++-
 arch/arm/boot/dts/tegra30-cardhu.dtsi                     | 2 +-
 4 files changed, 6 insertions(+), 2 deletions(-)

-- 
1.9.1

[PATCH v3 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028

[Darshana Padmadas]

This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
found by checkpatch also documented for compatibility reasons.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
---
 Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index 6af570e..d024613 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -57,6 +57,8 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
 infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
 infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
 isl,isl12057		Intersil ISL12057 I2C RTC Chip
+isil,isl29028           Deprecated name, use isl,isl29028 instead
+isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
 maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
 maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
 maxim,max6625		9-Bit/12-Bit Temperature Sensors with I?C-Compatible Serial Interface
-- 
1.9.1

[PATCH v3 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028

[Arnd Bergmann]

On Tuesday 07 October 2014 17:15:05 Darshana Padmadas wrote:
> This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
> found by checkpatch also documented for compatibility reasons.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

[PATCH v3 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028

[Mark Rutland]

On Tue, Oct 07, 2014 at 12:45:05PM +0100, Darshana Padmadas wrote:
> This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
> found by checkpatch also documented for compatibility reasons.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

> ---
>  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> index 6af570e..d024613 100644
> --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> @@ -57,6 +57,8 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
>  infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
>  infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
>  isl,isl12057		Intersil ISL12057 I2C RTC Chip
> +isil,isl29028           Deprecated name, use isl,isl29028 instead
> +isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
>  maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
>  maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
>  maxim,max6625		9-Bit/12-Bit Temperature Sensors with I??C-Compatible Serial Interface
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH v3 1/4] Documentation: devicetree: bindings: Document correct and deprecated vendor-prefix with device isl29028

[Mark Rutland]

On Tue, Oct 07, 2014 at 01:02:49PM +0100, Mark Rutland wrote:
> On Tue, Oct 07, 2014 at 12:45:05PM +0100, Darshana Padmadas wrote:
> > This patch documents the device isl29028 with its vendor-prefix. Undocumented deprecated vendor-prefix
> > found by checkpatch also documented for compatibility reasons.
> > 
> > Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
> 
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> 
> > ---
> >  Documentation/devicetree/bindings/i2c/trivial-devices.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > index 6af570e..d024613 100644
> > --- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > +++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
> > @@ -57,6 +57,8 @@ gmt,g751		G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire In
> >  infineon,slb9635tt	Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
> >  infineon,slb9645tt	Infineon SLB9645 I2C TPM (new protocol, max 400khz)
> >  isl,isl12057		Intersil ISL12057 I2C RTC Chip
> > +isil,isl29028           Deprecated name, use isl,isl29028 instead

Looking again, could you change the comment to "(deprecated, use isl)",
as I mentioned previously?

Then that will match what we have for powervr, which seems to be the
only other instance of "deprecated" in vendor-prefixes.txt.

Cheers,
Mark.

> > +isl,isl29028            Intersil ISL29028 Ambient Light and Proximity Sensor
> >  maxim,ds1050		5 Bit Programmable, Pulse-Width Modulator
> >  maxim,max1237		Low-Power, 4-/12-Channel, 2-Wire Serial, 12-Bit ADCs
> >  maxim,max6625		9-Bit/12-Bit Temperature Sensors with I??C-Compatible Serial Interface
> > -- 
> > 1.9.1
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree" in
> > the body of a message to majordomo at vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH v3 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning

[Darshana Padmadas]

This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index ac7269f..e2503b8 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -68,6 +68,7 @@ img	Imagination Technologies Ltd.
 intel	Intel Corporation
 intercontrol	Inter Control Group
 isee	ISEE 2007 S.L.
+isil 	Intersil (deprecated, use isl)
 isl	Intersil
 karo	Ka-Ro electronics GmbH
 keymile	Keymile GmbH
-- 
1.9.1

[PATCH v3 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning

[Arnd Bergmann]

On Tuesday 07 October 2014 17:15:06 Darshana Padmadas wrote:
> This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

[PATCH v3 2/4] Documentation: devicetree: bindings: Document deprecated device vendor name to fix related warning

[Mark Rutland]

On Tue, Oct 07, 2014 at 12:45:06PM +0100, Darshana Padmadas wrote:
> This patch documents deprecated vendor name of device isl29028 for compatibility with older kernels.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>

Acked-by: Mark Rutland Mark.rutland at arm.com>

> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index ac7269f..e2503b8 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -68,6 +68,7 @@ img	Imagination Technologies Ltd.
>  intel	Intel Corporation
>  intercontrol	Inter Control Group
>  isee	ISEE 2007 S.L.
> +isil 	Intersil (deprecated, use isl)
>  isl	Intersil
>  karo	Ka-Ro electronics GmbH
>  keymile	Keymile GmbH
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH v3 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028

[Darshana Padmadas]

This patch adds the correct vendor-prefix for device isl29028 and
maintains deprecated vendor-prefix found by checkpatch warning
for older kernel releases.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
---
 drivers/staging/iio/light/isl29028.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
index 6014625..60b02a8 100644
--- a/drivers/staging/iio/light/isl29028.c
+++ b/drivers/staging/iio/light/isl29028.c
@@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
 MODULE_DEVICE_TABLE(i2c, isl29028_id);
 
 static const struct of_device_id isl29028_of_match[] = {
-	{ .compatible = "isil,isl29028", },
+	{ .compatible = "isl,isl29028", },
+	{ .compatible = "isil,isl29028", }, /* deprecated, don't use */
 	{ },
 };
 MODULE_DEVICE_TABLE(of, isl29028_of_match);
-- 
1.9.1

[PATCH v3 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028

[Arnd Bergmann]

On Tuesday 07 October 2014 17:15:07 Darshana Padmadas wrote:
> This patch adds the correct vendor-prefix for device isl29028 and
> maintains deprecated vendor-prefix found by checkpatch warning
> for older kernel releases.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

[PATCH v3 3/4] Staging: iio: light: Added correct vendor-prefix for device isl29028

[Mark Rutland]

On Tue, Oct 07, 2014 at 12:45:07PM +0100, Darshana Padmadas wrote:
> This patch adds the correct vendor-prefix for device isl29028 and
> maintains deprecated vendor-prefix found by checkpatch warning
> for older kernel releases.
> 
> Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>

Acked-by: Mark Rutland <mark.rutland@arm.com>

> ---
>  drivers/staging/iio/light/isl29028.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index 6014625..60b02a8 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -537,7 +537,8 @@ static const struct i2c_device_id isl29028_id[] = {
>  MODULE_DEVICE_TABLE(i2c, isl29028_id);
>  
>  static const struct of_device_id isl29028_of_match[] = {
> -	{ .compatible = "isil,isl29028", },
> +	{ .compatible = "isl,isl29028", },
> +	{ .compatible = "isil,isl29028", }, /* deprecated, don't use */
>  	{ },
>  };
>  MODULE_DEVICE_TABLE(of, isl29028_of_match);
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Darshana Padmadas]

This patch adds the correct vendor-prefix listed in Documentation/devicetree/bindings/vendor-prefixes.txt
with the device name to compatible property.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
---
 arch/arm/boot/dts/tegra30-cardhu.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi
index 2063795..dcc6c75 100644
--- a/arch/arm/boot/dts/tegra30-cardhu.dtsi
+++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi
@@ -187,7 +187,7 @@
 
 		/* ALS and Proximity sensor */
 		isl29028 at 44 {
-			compatible = "isil,isl29028";
+			compatible = "isl,isl29028";
 			reg = <0x44>;
 			interrupt-parent = <&gpio>;
 			interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
-- 
1.9.1

[PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Arnd Bergmann]

On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:
>                 /* ALS and Proximity sensor */
>                 isl29028 at 44 {
> -                       compatible = "isil,isl29028";
> +                       compatible = "isl,isl29028";
>                         reg = <0x44>;
>                         interrupt-parent = <&gpio>;
>                         interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> 

Does this intentionally list only the new string?

If we want compatibility between new dts files and old kernels, this would
need to be 

	compatible = "isl,isl29028", compatible = "isil,isl29028";

I don't know if we want to go that far though, given that this is
only a staging driver.

	Arnd

[PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Mark Rutland]

On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote:
> On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:
> >                 /* ALS and Proximity sensor */
> >                 isl29028 at 44 {
> > -                       compatible = "isil,isl29028";
> > +                       compatible = "isl,isl29028";
> >                         reg = <0x44>;
> >                         interrupt-parent = <&gpio>;
> >                         interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> > 
> 
> Does this intentionally list only the new string?
> 
> If we want compatibility between new dts files and old kernels, this would
> need to be 
> 
> 	compatible = "isl,isl29028", compatible = "isil,isl29028";

Are we aiming for new dts wto work with old kernels? It's nice if they
do, but I don't think it should be necessary. Old DTBs should definitely
work with a new kernel, though.

Personally I'd rather see one string (preferably the canonical one, but
the deprecated one is ok) than two strings when those strings are for
the exact same device.

Mark.

[PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Arnd Bergmann]

On Tuesday 07 October 2014 13:08:12 Mark Rutland wrote:
> On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote:
> > On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:
> > >                 /* ALS and Proximity sensor */
> > >                 isl29028 at 44 {
> > > -                       compatible = "isil,isl29028";
> > > +                       compatible = "isl,isl29028";
> > >                         reg = <0x44>;
> > >                         interrupt-parent = <&gpio>;
> > >                         interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> > > 
> > 
> > Does this intentionally list only the new string?
> > 
> > If we want compatibility between new dts files and old kernels, this would
> > need to be 
> > 
> >       compatible = "isl,isl29028", compatible = "isil,isl29028";
> 
> Are we aiming for new dts wto work with old kernels? It's nice if they
> do, but I don't think it should be necessary. Old DTBs should definitely
> work with a new kernel, though.
> 
> Personally I'd rather see one string (preferably the canonical one, but
> the deprecated one is ok) than two strings when those strings are for
> the exact same device.
> 

Ok, fair enough. I think we should have the new name in dts files
normally then, in order to avoid spreading the mistake further when
someone copies it.

	Arnd

[PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Mark Rutland]

On Tue, Oct 07, 2014 at 01:31:23PM +0100, Arnd Bergmann wrote:
> On Tuesday 07 October 2014 13:08:12 Mark Rutland wrote:
> > On Tue, Oct 07, 2014 at 12:49:02PM +0100, Arnd Bergmann wrote:
> > > On Tuesday 07 October 2014 17:15:08 Darshana Padmadas wrote:
> > > >                 /* ALS and Proximity sensor */
> > > >                 isl29028 at 44 {
> > > > -                       compatible = "isil,isl29028";
> > > > +                       compatible = "isl,isl29028";
> > > >                         reg = <0x44>;
> > > >                         interrupt-parent = <&gpio>;
> > > >                         interrupts = <TEGRA_GPIO(L, 0) IRQ_TYPE_LEVEL_HIGH>;
> > > > 
> > > 
> > > Does this intentionally list only the new string?
> > > 
> > > If we want compatibility between new dts files and old kernels, this would
> > > need to be 
> > > 
> > >       compatible = "isl,isl29028", compatible = "isil,isl29028";
> > 
> > Are we aiming for new dts wto work with old kernels? It's nice if they
> > do, but I don't think it should be necessary. Old DTBs should definitely
> > work with a new kernel, though.
> > 
> > Personally I'd rather see one string (preferably the canonical one, but
> > the deprecated one is ok) than two strings when those strings are for
> > the exact same device.
> > 
> 
> Ok, fair enough. I think we should have the new name in dts files
> normally then, in order to avoid spreading the mistake further when
> someone copies it.

Sounds good to me.

Mark.

[PATCH v3 4/4] arch: arm: boot: dts: Added correct vendor-prefix with device name to compatible property

[Arnd Bergmann]

On Tuesday 07 October 2014 19:17:34 Darshana Padmadas wrote:
> So we stick to using just the new string, right? Any more changes to this
> patch ?
> 
> 

No, the patch looks good.

Acked-by: Arnd Bergmann <arnd@arndb.de>