* [PATCH 1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
@ 2016-07-11 21:51 ` Sergei Shtylyov
2016-07-13 1:20 ` Geert Uytterhoeven
2016-07-11 21:52 ` [PATCH 2/2] ARM: dts: r8a7792: remove ADSP clock Sergei Shtylyov
` (5 subsequent siblings)
6 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2016-07-11 21:51 UTC (permalink / raw)
To: linux-arm-kernel
Despite the QSPI clock has PLL1/VCOx1/4 clock as a parent, the latter
hasn't been added to the R8A7792 device tree -- fix this overlook at
last...
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/boot/dts/r8a7792.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792.dtsi
+++ renesas/arch/arm/boot/dts/r8a7792.dtsi
@@ -469,6 +469,13 @@
};
/* Fixed factor clocks */
+ pll1_div2_clk: pll1_div2 {
+ compatible = "fixed-factor-clock";
+ clocks = <&cpg_clocks R8A7792_CLK_PLL1>;
+ #clock-cells = <0>;
+ clock-div = <2>;
+ clock-mult = <1>;
+ };
zs_clk: zs {
compatible = "fixed-factor-clock";
clocks = <&cpg_clocks R8A7792_CLK_PLL1>;
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH 1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock
2016-07-11 21:51 ` [PATCH 1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock Sergei Shtylyov
@ 2016-07-13 1:20 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2016-07-13 1:20 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 11, 2016 at 11:51 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Despite the QSPI clock has PLL1/VCOx1/4 clock as a parent, the latter
> hasn't been added to the R8A7792 device tree -- fix this overlook at
> last...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 2/2] ARM: dts: r8a7792: remove ADSP clock
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
2016-07-11 21:51 ` [PATCH 1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock Sergei Shtylyov
@ 2016-07-11 21:52 ` Sergei Shtylyov
2016-07-13 1:23 ` Geert Uytterhoeven
2016-07-12 20:30 ` [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
` (4 subsequent siblings)
6 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2016-07-11 21:52 UTC (permalink / raw)
To: linux-arm-kernel
Simon Horman told me that R8A7792 had ADSP clock (based on the most recent
R-Car gen2 manual) but when I got that manual as well, this claim proved
to be false: R8A7792 is the only gen2 SoC that doesn't have ADSP at all.
Remove that clock for good...
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm/boot/dts/r8a7792.dtsi | 2 +-
include/dt-bindings/clock/r8a7792-clock.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7792.dtsi
+++ renesas/arch/arm/boot/dts/r8a7792.dtsi
@@ -464,7 +464,7 @@
clocks = <&extal_clk>;
#clock-cells = <1>;
clock-output-names = "main", "pll0", "pll1", "pll3",
- "lb", "qspi", "z", "adsp";
+ "lb", "qspi", "z";
#power-domain-cells = <0>;
};
Index: renesas/include/dt-bindings/clock/r8a7792-clock.h
===================================================================
--- renesas.orig/include/dt-bindings/clock/r8a7792-clock.h
+++ renesas/include/dt-bindings/clock/r8a7792-clock.h
@@ -18,7 +18,6 @@
#define R8A7792_CLK_LB 4
#define R8A7792_CLK_QSPI 5
#define R8A7792_CLK_Z 6
-#define R8A7792_CLK_ADSP 7
/* MSTP0 */
#define R8A7792_CLK_MSIOF0 0
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH 2/2] ARM: dts: r8a7792: remove ADSP clock
2016-07-11 21:52 ` [PATCH 2/2] ARM: dts: r8a7792: remove ADSP clock Sergei Shtylyov
@ 2016-07-13 1:23 ` Geert Uytterhoeven
0 siblings, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2016-07-13 1:23 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jul 11, 2016 at 11:52 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Simon Horman told me that R8A7792 had ADSP clock (based on the most recent
... based on a probably incorrect table in ...
> R-Car gen2 manual) but when I got that manual as well, this claim proved
> to be false: R8A7792 is the only gen2 SoC that doesn't have ADSP at all.
> Remove that clock for good...
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 0/2] R8A7792 clock fixes
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
2016-07-11 21:51 ` [PATCH 1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock Sergei Shtylyov
2016-07-11 21:52 ` [PATCH 2/2] ARM: dts: r8a7792: remove ADSP clock Sergei Shtylyov
@ 2016-07-12 20:30 ` Sergei Shtylyov
2016-07-15 4:25 ` Simon Horman
2016-10-29 21:31 ` [PATCH] ARM: dts: r8a7794: remove Z clock Sergei Shtylyov
` (3 subsequent siblings)
6 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2016-07-12 20:30 UTC (permalink / raw)
To: linux-arm-kernel
On 07/12/2016 12:50 AM, Sergei Shtylyov wrote:
> Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> 'renesas-devel-20160711-v4.7-rc7' tag. I've found a couple of issues in the
> R8A7792 DT clock descriptions, so these patches are targeted as fixes for 4.8.
Oops, those were atop of the PFC/GPIO/EtherAVB patches in my series. After
moving them before those, there was offset -185 lines while applying -- tell
me if I need to repost.
> [1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock
> [2/2] ARM: dts: r8a7792: remove ADSP clock
WBR, Sergei
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH 0/2] R8A7792 clock fixes
2016-07-12 20:30 ` [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
@ 2016-07-15 4:25 ` Simon Horman
0 siblings, 0 replies; 21+ messages in thread
From: Simon Horman @ 2016-07-15 4:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jul 12, 2016 at 11:30:25PM +0300, Sergei Shtylyov wrote:
> On 07/12/2016 12:50 AM, Sergei Shtylyov wrote:
>
> > Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
> >'renesas-devel-20160711-v4.7-rc7' tag. I've found a couple of issues in the
> >R8A7792 DT clock descriptions, so these patches are targeted as fixes for 4.8.
>
> Oops, those were atop of the PFC/GPIO/EtherAVB patches in my series.
> After moving them before those, there was offset -185 lines while applying
> -- tell me if I need to repost.
>
> >[1/2] ARM: dts: r8a7792: add PLL1 divided by 2 clock
> >[2/2] ARM: dts: r8a7792: remove ADSP clock
>
> WBR, Sergei
No need. I have queued these up.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] ARM: dts: r8a7794: remove Z clock
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
` (2 preceding siblings ...)
2016-07-12 20:30 ` [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
@ 2016-10-29 21:31 ` Sergei Shtylyov
2016-11-01 9:21 ` Simon Horman
2016-11-02 8:50 ` Geert Uytterhoeven
2016-12-14 22:07 ` [PATCH] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
` (2 subsequent siblings)
6 siblings, 2 replies; 21+ messages in thread
From: Sergei Shtylyov @ 2016-10-29 21:31 UTC (permalink / raw)
To: linux-arm-kernel
R8A7794 doesn't have Cortex-A15 CPUs, thus there's no Z clock...
Fixes: 0dce5454d5c2 ("ARM: shmobile: Initial r8a7794 SoC device tree")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against the 'master' branch of Simon Horman's 'renesas.git' repo.
arch/arm/boot/dts/r8a7794.dtsi | 3 +--
include/dt-bindings/clock/r8a7794-clock.h | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
@@ -1025,8 +1025,7 @@
clocks = <&extal_clk &usb_extal_clk>;
#clock-cells = <1>;
clock-output-names = "main", "pll0", "pll1", "pll3",
- "lb", "qspi", "sdh", "sd0", "z",
- "rcan";
+ "lb", "qspi", "sdh", "sd0", "rcan";
#power-domain-cells = <0>;
};
/* Variable factor clocks */
Index: renesas/include/dt-bindings/clock/r8a7794-clock.h
===================================================================
--- renesas.orig/include/dt-bindings/clock/r8a7794-clock.h
+++ renesas/include/dt-bindings/clock/r8a7794-clock.h
@@ -20,8 +20,7 @@
#define R8A7794_CLK_QSPI 5
#define R8A7794_CLK_SDH 6
#define R8A7794_CLK_SD0 7
-#define R8A7794_CLK_Z 8
-#define R8A7794_CLK_RCAN 9
+#define R8A7794_CLK_RCAN 8
/* MSTP0 */
#define R8A7794_CLK_MSIOF0 0
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH] ARM: dts: r8a7794: remove Z clock
2016-10-29 21:31 ` [PATCH] ARM: dts: r8a7794: remove Z clock Sergei Shtylyov
@ 2016-11-01 9:21 ` Simon Horman
2016-11-02 8:50 ` Geert Uytterhoeven
1 sibling, 0 replies; 21+ messages in thread
From: Simon Horman @ 2016-11-01 9:21 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Oct 30, 2016 at 12:31:27AM +0300, Sergei Shtylyov wrote:
> R8A7794 doesn't have Cortex-A15 CPUs, thus there's no Z clock...
>
> Fixes: 0dce5454d5c2 ("ARM: shmobile: Initial r8a7794 SoC device tree")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against the 'master' branch of Simon Horman's 'renesas.git' repo.
Thanks, I have queued this up.
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH] ARM: dts: r8a7794: remove Z clock
2016-10-29 21:31 ` [PATCH] ARM: dts: r8a7794: remove Z clock Sergei Shtylyov
2016-11-01 9:21 ` Simon Horman
@ 2016-11-02 8:50 ` Geert Uytterhoeven
1 sibling, 0 replies; 21+ messages in thread
From: Geert Uytterhoeven @ 2016-11-02 8:50 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Oct 29, 2016 at 11:31 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> R8A7794 doesn't have Cortex-A15 CPUs, thus there's no Z clock...
>
> Fixes: 0dce5454d5c2 ("ARM: shmobile: Initial r8a7794 SoC device tree")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> The patch is against the 'master' branch of Simon Horman's 'renesas.git' repo.
>
> arch/arm/boot/dts/r8a7794.dtsi | 3 +--
> include/dt-bindings/clock/r8a7794-clock.h | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -1025,8 +1025,7 @@
> clocks = <&extal_clk &usb_extal_clk>;
> #clock-cells = <1>;
> clock-output-names = "main", "pll0", "pll1", "pll3",
> - "lb", "qspi", "sdh", "sd0", "z",
> - "rcan";
> + "lb", "qspi", "sdh", "sd0", "rcan";
> #power-domain-cells = <0>;
> };
> /* Variable factor clocks */
> Index: renesas/include/dt-bindings/clock/r8a7794-clock.h
> ===================================================================
> --- renesas.orig/include/dt-bindings/clock/r8a7794-clock.h
> +++ renesas/include/dt-bindings/clock/r8a7794-clock.h
> @@ -20,8 +20,7 @@
> #define R8A7794_CLK_QSPI 5
> #define R8A7794_CLK_SDH 6
> #define R8A7794_CLK_SD0 7
> -#define R8A7794_CLK_Z 8
> -#define R8A7794_CLK_RCAN 9
> +#define R8A7794_CLK_RCAN 8
JFTR, this changes the bindings file, but the values are solely used
for indexing
the clock-output-names array, so this is fine.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] ARM: dts: r8a7791: link DU to VSPDs
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
` (3 preceding siblings ...)
2016-10-29 21:31 ` [PATCH] ARM: dts: r8a7794: remove Z clock Sergei Shtylyov
@ 2016-12-14 22:07 ` Sergei Shtylyov
2016-12-15 9:59 ` Magnus Damm
2017-01-03 9:24 ` Laurent Pinchart
2016-12-28 21:35 ` [PATCH] ARM: dts: r8a7794: link DU to VSPD Sergei Shtylyov
2017-01-25 21:42 ` [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
6 siblings, 2 replies; 21+ messages in thread
From: Sergei Shtylyov @ 2016-12-14 22:07 UTC (permalink / raw)
To: linux-arm-kernel
Add the "vsps" property to the DU device node in order to link this node to
the VSPD nodes.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'renesas-devel-20161212-v4.9' of Simon Horman's
'renesas.git' repo. It's only meaningful if the DU driver patch I've just
posted is applied.
arch/arm/boot/dts/r8a7791.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
+++ renesas/arch/arm/boot/dts/r8a7791.dtsi
@@ -989,7 +989,7 @@
power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
};
- vsp1 at fe930000 {
+ vspd0: vsp1 at fe930000 {
compatible = "renesas,vsp1";
reg = <0 0xfe930000 0 0x8000>;
interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
@@ -997,7 +997,7 @@
power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
};
- vsp1 at fe938000 {
+ vspd1: vsp1 at fe938000 {
compatible = "renesas,vsp1";
reg = <0 0xfe938000 0 0x8000>;
interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
@@ -1016,6 +1016,7 @@
<&mstp7_clks R8A7791_CLK_DU1>,
<&mstp7_clks R8A7791_CLK_LVDS0>;
clock-names = "du.0", "du.1", "lvds.0";
+ vsps = <&vspd0 &vspd1>;
status = "disabled";
ports {
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH] ARM: dts: r8a7791: link DU to VSPDs
2016-12-14 22:07 ` [PATCH] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
@ 2016-12-15 9:59 ` Magnus Damm
2017-01-03 9:24 ` Laurent Pinchart
1 sibling, 0 replies; 21+ messages in thread
From: Magnus Damm @ 2016-12-15 9:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Thu, Dec 15, 2016 at 7:07 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Add the "vsps" property to the DU device node in order to link this node to
> the VSPD nodes.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'renesas-devel-20161212-v4.9' of Simon Horman's
> 'renesas.git' repo. It's only meaningful if the DU driver patch I've just
> posted is applied.
Next time, please consider pointing out the exact name of the patch
you are referring to.
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] ARM: dts: r8a7791: link DU to VSPDs
2016-12-14 22:07 ` [PATCH] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
2016-12-15 9:59 ` Magnus Damm
@ 2017-01-03 9:24 ` Laurent Pinchart
1 sibling, 0 replies; 21+ messages in thread
From: Laurent Pinchart @ 2017-01-03 9:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Thursday 15 Dec 2016 01:07:52 Sergei Shtylyov wrote:
> Add the "vsps" property to the DU device node in order to link this node to
> the VSPD nodes.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
I'd like to first address the issues I've pointed out on the driver side of
this change.
> ---
> This patch is against the 'renesas-devel-20161212-v4.9' of Simon Horman's
> 'renesas.git' repo. It's only meaningful if the DU driver patch I've just
> posted is applied.
>
> arch/arm/boot/dts/r8a7791.dtsi | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7791.dtsi
> @@ -989,7 +989,7 @@
> power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
> };
>
> - vsp1 at fe930000 {
> + vspd0: vsp1 at fe930000 {
> compatible = "renesas,vsp1";
> reg = <0 0xfe930000 0 0x8000>;
> interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
> @@ -997,7 +997,7 @@
> power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
> };
>
> - vsp1 at fe938000 {
> + vspd1: vsp1 at fe938000 {
> compatible = "renesas,vsp1";
> reg = <0 0xfe938000 0 0x8000>;
> interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1016,6 +1016,7 @@
> <&mstp7_clks R8A7791_CLK_DU1>,
> <&mstp7_clks R8A7791_CLK_LVDS0>;
> clock-names = "du.0", "du.1", "lvds.0";
> + vsps = <&vspd0 &vspd1>;
> status = "disabled";
>
> ports {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH] ARM: dts: r8a7794: link DU to VSPD
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
` (4 preceding siblings ...)
2016-12-14 22:07 ` [PATCH] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
@ 2016-12-28 21:35 ` Sergei Shtylyov
2017-01-03 9:24 ` Laurent Pinchart
2017-01-25 21:42 ` [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
6 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2016-12-28 21:35 UTC (permalink / raw)
To: linux-arm-kernel
Add the "vsps" property to the DU device node in order to link this node to
the (single) VSPD node.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'renesas-devel-20161220-v4.9' of Simon Horman's
'renesas.git' repo. It's only meaningful if the "Enable R8A7794 DU VSPD
compositor" DU driver patches are applied...
arch/arm/boot/dts/r8a7794.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
+++ renesas/arch/arm/boot/dts/r8a7794.dtsi
@@ -908,7 +908,7 @@
power-domains = <&sysc R8A7794_PD_ALWAYS_ON>;
};
- vsp1 at fe930000 {
+ vspd0: vsp1 at fe930000 {
compatible = "renesas,vsp1";
reg = <0 0xfe930000 0 0x8000>;
interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
@@ -925,6 +925,7 @@
clocks = <&mstp7_clks R8A7794_CLK_DU0>,
<&mstp7_clks R8A7794_CLK_DU0>;
clock-names = "du.0", "du.1";
+ vsps = <&vspd0>;
status = "disabled";
ports {
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH] ARM: dts: r8a7794: link DU to VSPD
2016-12-28 21:35 ` [PATCH] ARM: dts: r8a7794: link DU to VSPD Sergei Shtylyov
@ 2017-01-03 9:24 ` Laurent Pinchart
0 siblings, 0 replies; 21+ messages in thread
From: Laurent Pinchart @ 2017-01-03 9:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Thursday 29 Dec 2016 00:35:07 Sergei Shtylyov wrote:
> Add the "vsps" property to the DU device node in order to link this node to
> the (single) VSPD node.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
I'd like to first address the issues I've pointed out on the driver side of
this change.
> ---
> This patch is against the 'renesas-devel-20161220-v4.9' of Simon Horman's
> 'renesas.git' repo. It's only meaningful if the "Enable R8A7794 DU VSPD
> compositor" DU driver patches are applied...
>
> arch/arm/boot/dts/r8a7794.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -908,7 +908,7 @@
> power-domains = <&sysc R8A7794_PD_ALWAYS_ON>;
> };
>
> - vsp1 at fe930000 {
> + vspd0: vsp1 at fe930000 {
> compatible = "renesas,vsp1";
> reg = <0 0xfe930000 0 0x8000>;
> interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
> @@ -925,6 +925,7 @@
> clocks = <&mstp7_clks R8A7794_CLK_DU0>,
> <&mstp7_clks R8A7794_CLK_DU0>;
> clock-names = "du.0", "du.1";
> + vsps = <&vspd0>;
> status = "disabled";
>
> ports {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs
2016-07-11 21:50 [PATCH 0/2] R8A7792 clock fixes Sergei Shtylyov
` (5 preceding siblings ...)
2016-12-28 21:35 ` [PATCH] ARM: dts: r8a7794: link DU to VSPD Sergei Shtylyov
@ 2017-01-25 21:42 ` Sergei Shtylyov
2017-01-26 18:42 ` Sergei Shtylyov
6 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2017-01-25 21:42 UTC (permalink / raw)
To: linux-arm-kernel
Add the "vsps" property to the DU device node in order to link this node to
the VSPD nodes.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
Changes in version 2:
- rebased the patch.
This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon Horman's
'renesas.git' repo. It's only meaningful if the DRM driver patches I've just
posted are applied.
arch/arm/boot/dts/r8a7791.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
+++ renesas/arch/arm/boot/dts/r8a7791.dtsi
@@ -992,7 +992,7 @@
power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
};
- vsp1 at fe930000 {
+ vspd0: vsp1 at fe930000 {
compatible = "renesas,vsp1";
reg = <0 0xfe930000 0 0x8000>;
interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
@@ -1000,7 +1000,7 @@
power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
};
- vsp1 at fe938000 {
+ vspd1: vsp1 at fe938000 {
compatible = "renesas,vsp1";
reg = <0 0xfe938000 0 0x8000>;
interrupts = <GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
@@ -1019,6 +1019,7 @@
<&mstp7_clks R8A7791_CLK_DU1>,
<&mstp7_clks R8A7791_CLK_LVDS0>;
clock-names = "du.0", "du.1", "lvds.0";
+ vsps = <&vspd0 &vspd1>;
status = "disabled";
ports {
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs
2017-01-25 21:42 ` [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs Sergei Shtylyov
@ 2017-01-26 18:42 ` Sergei Shtylyov
2017-02-01 11:13 ` Magnus Damm
0 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2017-01-26 18:42 UTC (permalink / raw)
To: linux-arm-kernel
On 01/26/2017 12:42 AM, Sergei Shtylyov wrote:
> Add the "vsps" property to the DU device node in order to link this node to
> the VSPD nodes.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Changes in version 2:
> - rebased the patch.
>
> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon Horman's
> 'renesas.git' repo. It's only meaningful if the DRM driver patches I've just
> posted are applied.
Forgot to note that without this patch the DU driver fails to link to VSPD
and probe correctly, so there's no video signal. So it makes sense to apply
before the DU driver patch (once it's ACKed for merge)...
MBR, Sergei
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs
2017-01-26 18:42 ` Sergei Shtylyov
@ 2017-02-01 11:13 ` Magnus Damm
2017-02-01 11:40 ` Sergei Shtylyov
0 siblings, 1 reply; 21+ messages in thread
From: Magnus Damm @ 2017-02-01 11:13 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Fri, Jan 27, 2017 at 3:42 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 01/26/2017 12:42 AM, Sergei Shtylyov wrote:
>
>> Add the "vsps" property to the DU device node in order to link this node
>> to
>> the VSPD nodes.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> Changes in version 2:
>> - rebased the patch.
>>
>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon
>> Horman's
>> 'renesas.git' repo. It's only meaningful if the DRM driver patches I've
>> just
>> posted are applied.
>
>
> Forgot to note that without this patch the DU driver fails to link to
> VSPD and probe correctly, so there's no video signal. So it makes sense to
> apply before the DU driver patch (once it's ACKed for merge)...
Doesn't that translate to breaking the DT ABI? Is there someway we can
avoid doing that?
Thanks,
/ magnus
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs
2017-02-01 11:13 ` Magnus Damm
@ 2017-02-01 11:40 ` Sergei Shtylyov
2017-02-01 12:01 ` Magnus Damm
0 siblings, 1 reply; 21+ messages in thread
From: Sergei Shtylyov @ 2017-02-01 11:40 UTC (permalink / raw)
To: linux-arm-kernel
On 2/1/2017 2:13 PM, Magnus Damm wrote:
>>> Add the "vsps" property to the DU device node in order to link this node
>>> to
>>> the VSPD nodes.
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>
>>> ---
>>> Changes in version 2:
>>> - rebased the patch.
>>>
>>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon
>>> Horman's
>>> 'renesas.git' repo. It's only meaningful if the DRM driver patches I've
>>> just
>>> posted are applied.
>>
>>
>> Forgot to note that without this patch the DU driver fails to link to
>> VSPD and probe correctly, so there's no video signal. So it makes sense to
>> apply before the DU driver patch (once it's ACKed for merge)...
>
> Doesn't that translate to breaking the DT ABI? Is there someway we can
> avoid doing that?
It doesn't -- if this patch is merged ahead of the DU patches.
> Thanks,
>
> / magnus
MBR, Sergei
^ permalink raw reply [flat|nested] 21+ messages in thread* [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs
2017-02-01 11:40 ` Sergei Shtylyov
@ 2017-02-01 12:01 ` Magnus Damm
2017-02-02 13:02 ` Sergei Shtylyov
0 siblings, 1 reply; 21+ messages in thread
From: Magnus Damm @ 2017-02-01 12:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Wed, Feb 1, 2017 at 8:40 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 2/1/2017 2:13 PM, Magnus Damm wrote:
>
>>>> Add the "vsps" property to the DU device node in order to link this node
>>>> to
>>>> the VSPD nodes.
>>>>
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>
>>>> ---
>>>> Changes in version 2:
>>>> - rebased the patch.
>>>>
>>>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon
>>>> Horman's
>>>> 'renesas.git' repo. It's only meaningful if the DRM driver patches
>>>> I've
>>>> just
>>>> posted are applied.
>>>
>>>
>>>
>>> Forgot to note that without this patch the DU driver fails to link to
>>> VSPD and probe correctly, so there's no video signal. So it makes sense
>>> to
>>> apply before the DU driver patch (once it's ACKed for merge)...
>>
>>
>> Doesn't that translate to breaking the DT ABI? Is there someway we can
>> avoid doing that?
>
>
> It doesn't -- if this patch is merged ahead of the DU patches.
Perhaps I'm misunderstanding, but if you require a DTS patch to be
merged before a driver change then doesn't this mean that older DTBs
will stop working with newer kernels and the user is forced to update
the DTB to avoid breakage?
It would be nice if older DTBs could keep on working as before and the
DU driver modification would work both with connected VSPs and also
keep on working as before in case the VSP connection is not present in
DT.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] ARM: dts: r8a7791: link DU to VSPDs
2017-02-01 12:01 ` Magnus Damm
@ 2017-02-02 13:02 ` Sergei Shtylyov
0 siblings, 0 replies; 21+ messages in thread
From: Sergei Shtylyov @ 2017-02-02 13:02 UTC (permalink / raw)
To: linux-arm-kernel
Hello!
On 02/01/2017 03:01 PM, Magnus Damm wrote:
>>>>> Add the "vsps" property to the DU device node in order to link this node
>>>>> to
>>>>> the VSPD nodes.
>>>>>
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>>>
>>>>> ---
>>>>> Changes in version 2:
>>>>> - rebased the patch.
>>>>>
>>>>> This patch is against the 'renesas-devel-20170125-v4.10-rc5' of Simon
>>>>> Horman's
>>>>> 'renesas.git' repo. It's only meaningful if the DRM driver patches
>>>>> I've
>>>>> just
>>>>> posted are applied.
>>>>
>>>>
>>>>
>>>> Forgot to note that without this patch the DU driver fails to link to
>>>> VSPD and probe correctly, so there's no video signal. So it makes sense
>>>> to
>>>> apply before the DU driver patch (once it's ACKed for merge)...
>>>
>>>
>>> Doesn't that translate to breaking the DT ABI? Is there someway we can
>>> avoid doing that?
>>
>>
>> It doesn't -- if this patch is merged ahead of the DU patches.
>
> Perhaps I'm misunderstanding, but if you require a DTS patch to be
> merged before a driver change then doesn't this mean that older DTBs
> will stop working with newer kernels and the user is forced to update
> the DTB to avoid breakage?
Yes, it seems so. :-(
> It would be nice if older DTBs could keep on working as before and the
> DU driver modification would work both with connected VSPs and also
> keep on working as before in case the VSP connection is not present in
> DT.
I'll try to look into that...
> Cheers,
>
> / magnus
MBR, Sergei
^ permalink raw reply [flat|nested] 21+ messages in thread