Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] Arm: zx: remove redundant dev_err message
@ 2019-06-18  7:39 Ding Xiang
  2019-06-18 13:46 ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Ding Xiang @ 2019-06-18  7:39 UTC (permalink / raw)
  To: jun.nie, shawnguo; +Cc: linux-kernel, linux-arm-kernel

devm_ioremap_resource already contains error message, so remove
the redundant dev_err message

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
 arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
index 7a08bf9d..ac44ea8 100644
--- a/arch/arm/mach-zx/zx296702-pm-domain.c
+++ b/arch/arm/mach-zx/zx296702-pm-domain.c
@@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
 	}
 
 	pcubase = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(pcubase)) {
-		dev_err(&pdev->dev, "ioremap fail.\n");
+	if (IS_ERR(pcubase))
 		return -EIO;
-	}
 
 	for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
 		pm_genpd_init(zx296702_pm_domains[i], NULL, false);
-- 
1.9.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Arm: zx: remove redundant dev_err message
  2019-06-18  7:39 [PATCH] Arm: zx: remove redundant dev_err message Ding Xiang
@ 2019-06-18 13:46 ` Shawn Guo
  2019-06-18 13:52   ` Russell King - ARM Linux admin
  0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2019-06-18 13:46 UTC (permalink / raw)
  To: Ding Xiang, Arnd Bergmann, Olof Johansson
  Cc: jun.nie, linux-kernel, linux-arm-kernel

On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
> 
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>

Acked-by: Shawn Guo <shawnguo@kernel.org>

Arnd, Olof,

Can you please apply it to arm-soc tree?  Thanks.

Shawn

> ---
>  arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
> index 7a08bf9d..ac44ea8 100644
> --- a/arch/arm/mach-zx/zx296702-pm-domain.c
> +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
>  	}
>  
>  	pcubase = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(pcubase)) {
> -		dev_err(&pdev->dev, "ioremap fail.\n");
> +	if (IS_ERR(pcubase))
>  		return -EIO;
> -	}
>  
>  	for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
>  		pm_genpd_init(zx296702_pm_domains[i], NULL, false);
> -- 
> 1.9.1
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Arm: zx: remove redundant dev_err message
  2019-06-18 13:46 ` Shawn Guo
@ 2019-06-18 13:52   ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2019-06-18 13:52 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Arnd Bergmann, linux-kernel, Ding Xiang, Olof Johansson, jun.nie,
	linux-arm-kernel

On Tue, Jun 18, 2019 at 09:46:36PM +0800, Shawn Guo wrote:
> On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote:
> > devm_ioremap_resource already contains error message, so remove
> > the redundant dev_err message
> > 
> > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> 
> Acked-by: Shawn Guo <shawnguo@kernel.org>
> 
> Arnd, Olof,
> 
> Can you please apply it to arm-soc tree?  Thanks.
> 
> Shawn
> 
> > ---
> >  arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
> > index 7a08bf9d..ac44ea8 100644
> > --- a/arch/arm/mach-zx/zx296702-pm-domain.c
> > +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> > @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
> >  	}
> >  
> >  	pcubase = devm_ioremap_resource(&pdev->dev, res);
> > -	if (IS_ERR(pcubase)) {
> > -		dev_err(&pdev->dev, "ioremap fail.\n");
> > +	if (IS_ERR(pcubase))
> >  		return -EIO;

Shouldn't the error return also get fixed?

> > -	}
> >  
> >  	for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
> >  		pm_genpd_init(zx296702_pm_domains[i], NULL, false);
> > -- 
> > 1.9.1
> > 
> > 
> > 
> > 
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18  7:39 [PATCH] Arm: zx: remove redundant dev_err message Ding Xiang
2019-06-18 13:46 ` Shawn Guo
2019-06-18 13:52   ` Russell King - ARM Linux admin

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org infradead-linux-arm-kernel@archiver.kernel.org
	public-inbox-index linux-arm-kernel


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox