* [v1, 1/1] gpio: dts: aspeed: Add SGPIO driver
@ 2019-09-24 19:07 Hongwei Zhang
2019-09-25 7:31 ` Bartosz Golaszewski
2019-09-25 19:19 ` Hongwei Zhang
0 siblings, 2 replies; 3+ messages in thread
From: Hongwei Zhang @ 2019-09-24 19:07 UTC (permalink / raw)
To: Andrew Jeffery, Linus Walleij, linux-gpio, Joel Stanley
Cc: Mark Rutland, devicetree, Arnd Bergmann, linux-aspeed,
Ard Biesheuvel, Masahiro Yamada, linux-kernel, Russell King,
Mike Rapoport, Bartosz Golaszewski, Rob Herring,
Benjamin Gaignard, Mauro Carvalho Chehab, Doug Anderson,
Andrew Morton, Hongwei Zhang, linux-arm-kernel
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
---
arch/arm/Kconfig | 2 ++
arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++++++++++++++-
drivers/gpio/Kconfig | 8 ++++++++
drivers/gpio/Makefile | 1 +
4 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2436021..c9f08ab 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1460,6 +1460,8 @@ config ARCH_NR_GPIO
default 416 if ARCH_SUNXI
default 392 if ARCH_U8500
default 352 if ARCH_VT8500
+ default 312 if MACH_ASPEED_G5
+ default 304 if MACH_ASPEED_G4
default 288 if ARCH_ROCKCHIP
default 264 if MACH_H4700
default 0
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 00f05bd..85da7ea 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -311,7 +311,7 @@
#gpio-cells = <2>;
gpio-controller;
compatible = "aspeed,ast2500-gpio";
- reg = <0x1e780000 0x1000>;
+ reg = <0x1e780000 0x200>;
interrupts = <20>;
gpio-ranges = <&pinctrl 0 0 232>;
clocks = <&syscon ASPEED_CLK_APB>;
@@ -319,6 +319,20 @@
#interrupt-cells = <2>;
};
+ sgpio: sgpio@1e780200 {
+ #gpio-cells = <2>;
+ compatible = "aspeed,ast2500-sgpio";
+ gpio-controller;
+ interrupts = <40>;
+ reg = <0x1e780200 0x0100>;
+ clocks = <&syscon ASPEED_CLK_APB>;
+ interrupt-controller;
+ ngpios = <8>;
+ bus-frequency = <12000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_sgpm_default>;
+ };
+
rtc: rtc@1e781000 {
compatible = "aspeed,ast2500-rtc";
reg = <0x1e781000 0x18>;
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index bb13c26..e94f903 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -120,6 +120,14 @@ config GPIO_ASPEED
help
Say Y here to support Aspeed AST2400 and AST2500 GPIO controllers.
+config SGPIO_ASPEED
+ bool "Aspeed SGPIO support"
+ depends on (ARCH_ASPEED || COMPILE_TEST) && OF_GPIO
+ select GPIO_GENERIC
+ select GPIOLIB_IRQCHIP
+ help
+ Say Y here to support Aspeed AST2500 SGPIO functionality.
+
config GPIO_ATH79
tristate "Atheros AR71XX/AR724X/AR913X GPIO support"
default y if ATH79
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index a4e9117..bebbd82 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -32,6 +32,7 @@ obj-$(CONFIG_GPIO_AMD_FCH) += gpio-amd-fch.o
obj-$(CONFIG_GPIO_AMDPT) += gpio-amdpt.o
obj-$(CONFIG_GPIO_ARIZONA) += gpio-arizona.o
obj-$(CONFIG_GPIO_ASPEED) += gpio-aspeed.o
+obj-$(CONFIG_SGPIO_ASPEED) += sgpio-aspeed.o
obj-$(CONFIG_GPIO_ATH79) += gpio-ath79.o
obj-$(CONFIG_GPIO_BCM_KONA) += gpio-bcm-kona.o
obj-$(CONFIG_GPIO_BD70528) += gpio-bd70528.o
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [v1, 1/1] gpio: dts: aspeed: Add SGPIO driver
2019-09-24 19:07 [v1, 1/1] gpio: dts: aspeed: Add SGPIO driver Hongwei Zhang
@ 2019-09-25 7:31 ` Bartosz Golaszewski
2019-09-25 19:19 ` Hongwei Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-09-25 7:31 UTC (permalink / raw)
To: Hongwei Zhang
Cc: Mark Rutland, devicetree, Arnd Bergmann, linux-aspeed,
Bartosz Golaszewski, Andrew Jeffery, Linux Kernel Mailing List,
Linus Walleij, Ard Biesheuvel, Russell King, Mike Rapoport,
open list:GPIO SUBSYSTEM, Rob Herring, Joel Stanley,
Benjamin Gaignard, Mauro Carvalho Chehab, Doug Anderson,
Andrew Morton, Linux ARM, Masahiro Yamada
wt., 24 wrz 2019 o 21:07 Hongwei Zhang <hongweiz@ami.com> napisał(a):
>
> Add SGPIO driver support for Aspeed AST2500 SoC.
>
> Signed-off-by: Hongwei Zhang <hongweiz@ami.com>
> ---
> arch/arm/Kconfig | 2 ++
> arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++++++++++++++-
> drivers/gpio/Kconfig | 8 ++++++++
> drivers/gpio/Makefile | 1 +
> 4 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 2436021..c9f08ab 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1460,6 +1460,8 @@ config ARCH_NR_GPIO
> default 416 if ARCH_SUNXI
> default 392 if ARCH_U8500
> default 352 if ARCH_VT8500
> + default 312 if MACH_ASPEED_G5
> + default 304 if MACH_ASPEED_G4
> default 288 if ARCH_ROCKCHIP
> default 264 if MACH_H4700
> default 0
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 00f05bd..85da7ea 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -311,7 +311,7 @@
> #gpio-cells = <2>;
> gpio-controller;
> compatible = "aspeed,ast2500-gpio";
> - reg = <0x1e780000 0x1000>;
> + reg = <0x1e780000 0x200>;
> interrupts = <20>;
> gpio-ranges = <&pinctrl 0 0 232>;
> clocks = <&syscon ASPEED_CLK_APB>;
> @@ -319,6 +319,20 @@
> #interrupt-cells = <2>;
> };
>
> + sgpio: sgpio@1e780200 {
> + #gpio-cells = <2>;
> + compatible = "aspeed,ast2500-sgpio";
> + gpio-controller;
> + interrupts = <40>;
> + reg = <0x1e780200 0x0100>;
> + clocks = <&syscon ASPEED_CLK_APB>;
> + interrupt-controller;
> + ngpios = <8>;
> + bus-frequency = <12000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_sgpm_default>;
> + };
> +
> rtc: rtc@1e781000 {
> compatible = "aspeed,ast2500-rtc";
> reg = <0x1e781000 0x18>;
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index bb13c26..e94f903 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -120,6 +120,14 @@ config GPIO_ASPEED
> help
> Say Y here to support Aspeed AST2400 and AST2500 GPIO controllers.
>
> +config SGPIO_ASPEED
> + bool "Aspeed SGPIO support"
> + depends on (ARCH_ASPEED || COMPILE_TEST) && OF_GPIO
> + select GPIO_GENERIC
> + select GPIOLIB_IRQCHIP
> + help
> + Say Y here to support Aspeed AST2500 SGPIO functionality.
> +
> config GPIO_ATH79
> tristate "Atheros AR71XX/AR724X/AR913X GPIO support"
> default y if ATH79
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index a4e9117..bebbd82 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -32,6 +32,7 @@ obj-$(CONFIG_GPIO_AMD_FCH) += gpio-amd-fch.o
> obj-$(CONFIG_GPIO_AMDPT) += gpio-amdpt.o
> obj-$(CONFIG_GPIO_ARIZONA) += gpio-arizona.o
> obj-$(CONFIG_GPIO_ASPEED) += gpio-aspeed.o
> +obj-$(CONFIG_SGPIO_ASPEED) += sgpio-aspeed.o
> obj-$(CONFIG_GPIO_ATH79) += gpio-ath79.o
> obj-$(CONFIG_GPIO_BCM_KONA) += gpio-bcm-kona.o
> obj-$(CONFIG_GPIO_BD70528) += gpio-bd70528.o
> --
> 2.7.4
>
This should be split into separate patches with one extending the
binding document and one adding actual support.
Bart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v1, 1/1] gpio: dts: aspeed: Add SGPIO driver
2019-09-24 19:07 [v1, 1/1] gpio: dts: aspeed: Add SGPIO driver Hongwei Zhang
2019-09-25 7:31 ` Bartosz Golaszewski
@ 2019-09-25 19:19 ` Hongwei Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Hongwei Zhang @ 2019-09-25 19:19 UTC (permalink / raw)
To: Bartosz Golaszewski, Linus Walleij, Andrew Jeffery, linux-gpio,
Joel Stanley
Cc: Mark Rutland, devicetree, Arnd Bergmann, linux-aspeed,
Ard Biesheuvel, linux-kernel, Russell King, Mike Rapoport,
Masahiro Yamada, Rob Herring, Benjamin Gaignard,
Mauro Carvalho Chehab, Doug Anderson, Andrew Morton,
Hongwei Zhang, linux-arm-kernel
> > obj-$(CONFIG_GPIO_BD70528) += gpio-bd70528.o
> > --
> > 2.7.4
> >
>
> This should be split into separate patches with one extending the binding document and one adding
> actual support.
>
> Bart
Thanks Bart,
I just submitted splitted patches.
--Hongwei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-25 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 19:07 [v1, 1/1] gpio: dts: aspeed: Add SGPIO driver Hongwei Zhang
2019-09-25 7:31 ` Bartosz Golaszewski
2019-09-25 19:19 ` Hongwei Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).