* [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue
@ 2020-05-08 3:56 Hanjun Guo
2020-05-08 7:58 ` Ard Biesheuvel
2020-05-11 16:27 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Hanjun Guo @ 2020-05-08 3:56 UTC (permalink / raw)
To: Ard Biesheuvel, Lorenzo Pieralisi, Rafael J. Wysocki,
Sudeep Holla, Will Deacon
Cc: linux-acpi, linux-arm-kernel, Hanjun Guo
As we already applied a workaround for the off-by-1 issue,
it's good to add extra message "applying workaround" to make
people less uneasy to see FW_BUG message in the boot log.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
v2:
- Print the extra message only for rid_in == map->input_base;
- Still based on top of for-next/acpi branch of ARM64 repo
drivers/acpi/arm64/iort.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index b011d25..6e445bc 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -332,6 +332,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
map, rid_in);
if (rid_in != map->input_base)
return -ENXIO;
+
+ pr_err(FW_BUG "applying workaround.\n");
}
*rid_out = map->output_base + (rid_in - map->input_base);
--
1.7.12.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue
2020-05-08 3:56 [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue Hanjun Guo
@ 2020-05-08 7:58 ` Ard Biesheuvel
2020-05-11 16:27 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-05-08 7:58 UTC (permalink / raw)
To: Hanjun Guo
Cc: Lorenzo Pieralisi, Rafael J. Wysocki, ACPI Devel Maling List,
Sudeep Holla, Will Deacon, Linux ARM
On Fri, 8 May 2020 at 06:07, Hanjun Guo <guohanjun@huawei.com> wrote:
>
> As we already applied a workaround for the off-by-1 issue,
> it's good to add extra message "applying workaround" to make
> people less uneasy to see FW_BUG message in the boot log.
>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
>
> v2:
> - Print the extra message only for rid_in == map->input_base;
> - Still based on top of for-next/acpi branch of ARM64 repo
>
> drivers/acpi/arm64/iort.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index b011d25..6e445bc 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -332,6 +332,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
> map, rid_in);
> if (rid_in != map->input_base)
> return -ENXIO;
> +
> + pr_err(FW_BUG "applying workaround.\n");
> }
>
> *rid_out = map->output_base + (rid_in - map->input_base);
> --
> 1.7.12.4
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue
2020-05-08 3:56 [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue Hanjun Guo
2020-05-08 7:58 ` Ard Biesheuvel
@ 2020-05-11 16:27 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-05-11 16:27 UTC (permalink / raw)
To: Rafael J. Wysocki, Hanjun Guo, Lorenzo Pieralisi, Ard Biesheuvel,
Sudeep Holla
Cc: catalin.marinas, Will Deacon, linux-arm-kernel, linux-acpi
On Fri, 8 May 2020 11:56:38 +0800, Hanjun Guo wrote:
> As we already applied a workaround for the off-by-1 issue,
> it's good to add extra message "applying workaround" to make
> people less uneasy to see FW_BUG message in the boot log.
Applied to arm64 (for-next/acpi), thanks!
[1/1] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue
https://git.kernel.org/arm64/c/44cdc7b16e0a
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-11 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 3:56 [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue Hanjun Guo
2020-05-08 7:58 ` Ard Biesheuvel
2020-05-11 16:27 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).