* [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c
@ 2020-09-16 2:20 Tian Tao
2020-09-16 3:34 ` Gavin Shan
2020-09-18 16:17 ` Will Deacon
0 siblings, 2 replies; 3+ messages in thread
From: Tian Tao @ 2020-09-16 2:20 UTC (permalink / raw)
To: catalin.marinas, will, rppt, akpm, zhangpan26, broonie, linux-arm-kernel
Cc: linuxarm
Fix the following warnings.
arch/arm64/mm/pageattr.c:138:5: warning: no previous prototype for
‘set_memory_valid’ [-Wmissing-prototypes]
int set_memory_valid(unsigned long addr, int numpages, int enable)
^
arch/arm64/mm/pageattr.c:150:5: warning: no previous prototype for
‘set_direct_map_invalid_noflush’ [-Wmissing-prototypes]
int set_direct_map_invalid_noflush(struct page *page)
^
arch/arm64/mm/pageattr.c:165:5: warning: no previous prototype for
‘set_direct_map_default_noflush’ [-Wmissing-prototypes]
int set_direct_map_default_noflush(struct page *page)
^
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
arch/arm64/mm/pageattr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
index 23f648c..1b94f5b 100644
--- a/arch/arm64/mm/pageattr.c
+++ b/arch/arm64/mm/pageattr.c
@@ -8,6 +8,7 @@
#include <linux/sched.h>
#include <linux/vmalloc.h>
+#include <asm/cacheflush.h>
#include <asm/set_memory.h>
#include <asm/tlbflush.h>
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c
2020-09-16 2:20 [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c Tian Tao
@ 2020-09-16 3:34 ` Gavin Shan
2020-09-18 16:17 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Gavin Shan @ 2020-09-16 3:34 UTC (permalink / raw)
To: Tian Tao, catalin.marinas, will, rppt, akpm, zhangpan26, broonie,
linux-arm-kernel
Cc: linuxarm
On 9/16/20 12:20 PM, Tian Tao wrote:
> Fix the following warnings.
> arch/arm64/mm/pageattr.c:138:5: warning: no previous prototype for
> ‘set_memory_valid’ [-Wmissing-prototypes]
> int set_memory_valid(unsigned long addr, int numpages, int enable)
> ^
> arch/arm64/mm/pageattr.c:150:5: warning: no previous prototype for
> ‘set_direct_map_invalid_noflush’ [-Wmissing-prototypes]
> int set_direct_map_invalid_noflush(struct page *page)
> ^
> arch/arm64/mm/pageattr.c:165:5: warning: no previous prototype for
> ‘set_direct_map_default_noflush’ [-Wmissing-prototypes]
> int set_direct_map_default_noflush(struct page *page)
> ^
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
Reviewed-by: Gavin Shan <gshan@redhat.com>
> arch/arm64/mm/pageattr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/mm/pageattr.c b/arch/arm64/mm/pageattr.c
> index 23f648c..1b94f5b 100644
> --- a/arch/arm64/mm/pageattr.c
> +++ b/arch/arm64/mm/pageattr.c
> @@ -8,6 +8,7 @@
> #include <linux/sched.h>
> #include <linux/vmalloc.h>
>
> +#include <asm/cacheflush.h>
> #include <asm/set_memory.h>
> #include <asm/tlbflush.h>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c
2020-09-16 2:20 [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c Tian Tao
2020-09-16 3:34 ` Gavin Shan
@ 2020-09-18 16:17 ` Will Deacon
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2020-09-18 16:17 UTC (permalink / raw)
To: catalin.marinas, rppt, akpm, broonie, Tian Tao, linux-arm-kernel,
zhangpan26
Cc: Will Deacon, kernel-team, linuxarm
On Wed, 16 Sep 2020 10:20:47 +0800, Tian Tao wrote:
> Fix the following warnings.
> ‘set_memory_valid’ [-Wmissing-prototypes]
> int set_memory_valid(unsigned long addr, int numpages, int enable)
> ^
> ‘set_direct_map_invalid_noflush’ [-Wmissing-prototypes]
> int set_direct_map_invalid_noflush(struct page *page)
> ^
> ‘set_direct_map_default_noflush’ [-Wmissing-prototypes]
> int set_direct_map_default_noflush(struct page *page)
> ^
Applied to arm64 (for-next/misc), thanks!
[1/1] arm64: mm: Fix missing-prototypes in pageattr.c
https://git.kernel.org/arm64/c/152d75d66428
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-18 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 2:20 [PATCH] arm64: mm: Fix missing-prototypes in pageattr.c Tian Tao
2020-09-16 3:34 ` Gavin Shan
2020-09-18 16:17 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).