From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com, UNGLinuxDriver@microchip.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x
Date: Mon, 6 Jun 2022 15:03:18 +0200 [thread overview]
Message-ID: <1764f3ce-608f-e55c-d977-18fb95e4a0fe@linaro.org> (raw)
In-Reply-To: <20220603121802.30320-3-kavyasree.kotagiri@microchip.com>
On 03/06/2022 14:18, Kavyasree Kotagiri wrote:
> LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1 in
> flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on
> functions being configured.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> .../bindings/mfd/atmel,flexcom.yaml | 21 ++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> index 221bd840b49e..6050482ad8ef 100644
> --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> @@ -16,7 +16,9 @@ description:
>
> properties:
> compatible:
> - const: atmel,sama5d2-flexcom
> + enum:
> + - atmel,sama5d2-flexcom
> + - microchip,lan966x-flexcom
Your new v1 is here worse than old v2, where this was just simple
extension of existing enum. Why did you change it?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-06 13:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 12:17 [PATCH 0/3] Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri
2022-06-03 12:18 ` [PATCH 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Kavyasree Kotagiri
2022-06-03 20:34 ` Rob Herring
2022-06-06 13:01 ` Krzysztof Kozlowski
2022-06-06 13:25 ` Kavyasree.Kotagiri
2022-06-07 6:55 ` Kavyasree.Kotagiri
2022-06-07 7:04 ` Krzysztof Kozlowski
2022-06-03 12:18 ` [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x Kavyasree Kotagiri
2022-06-03 20:36 ` Rob Herring
2022-06-06 13:03 ` Krzysztof Kozlowski [this message]
2022-06-06 13:28 ` Kavyasree.Kotagiri
2022-06-07 7:05 ` Krzysztof Kozlowski
2022-06-07 7:54 ` Kavyasree.Kotagiri
2022-06-07 7:56 ` Krzysztof Kozlowski
2022-06-03 12:18 ` [PATCH 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri
2022-06-06 8:44 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1764f3ce-608f-e55c-d977-18fb95e4a0fe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=kavyasree.kotagiri@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).