From: <Kavyasree.Kotagiri@microchip.com>
To: <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
UNGLinuxDriver@microchip.com, Claudiu.Beznea@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x
Date: Tue, 7 Jun 2022 07:54:54 +0000 [thread overview]
Message-ID: <CO1PR11MB4865CA9098EA7E1C052823D792A59@CO1PR11MB4865.namprd11.prod.outlook.com> (raw)
In-Reply-To: <ed469c4d-cbf3-2f54-743b-a22c0c120df1@linaro.org>
> >>> LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
> in
> >>> flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> >>> can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage
> >> depends on
> >>> functions being configured.
> >>>
> >>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> >>> ---
> >>> .../bindings/mfd/atmel,flexcom.yaml | 21 ++++++++++++++++++-
> >>> 1 file changed, 20 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >> b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >>> index 221bd840b49e..6050482ad8ef 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >>> +++ b/Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml
> >>> @@ -16,7 +16,9 @@ description:
> >>>
> >>> properties:
> >>> compatible:
> >>> - const: atmel,sama5d2-flexcom
> >>> + enum:
> >>> + - atmel,sama5d2-flexcom
> >>> + - microchip,lan966x-flexcom
> >>
> >> Your new v1 is here worse than old v2, where this was just simple
> >> extension of existing enum. Why did you change it?
> >>
> > I introduced new compatible string for lan966x and also I have new DT
> properties
> > "microchip,flx-shrd-pins" and "microchip,flx-cs-names".
>
> v1 also had the new compatible, hadn't it? The difference is in the enum
> - before you did not modify this line. Less code in the diff...
>
Yes, previous patch series also had new compatible which introduced new mux DT properties in atmel-flexcom.yaml and mux driver.
As part of review comments from Peter Rosin on driver part, Mux implementation is dropped. Please ignore previous patch series. Now, flexcom chip-select support is done in atme-flexcom.c driver. So, I started new patch series now which introduced new DT properties "microchip,flx-shrd-pins" and "microchip,flx-cs-names" and driver changes only in atmel-flexcom.c driver.
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-07 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 12:17 [PATCH 0/3] Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri
2022-06-03 12:18 ` [PATCH 1/3] dt-bindings: mfd: atmel,flexcom: Convert to json-schema Kavyasree Kotagiri
2022-06-03 20:34 ` Rob Herring
2022-06-06 13:01 ` Krzysztof Kozlowski
2022-06-06 13:25 ` Kavyasree.Kotagiri
2022-06-07 6:55 ` Kavyasree.Kotagiri
2022-06-07 7:04 ` Krzysztof Kozlowski
2022-06-03 12:18 ` [PATCH 2/3] dt-bindings: mfd: atmel,flexcom: Add new compatible string for lan966x Kavyasree Kotagiri
2022-06-03 20:36 ` Rob Herring
2022-06-06 13:03 ` Krzysztof Kozlowski
2022-06-06 13:28 ` Kavyasree.Kotagiri
2022-06-07 7:05 ` Krzysztof Kozlowski
2022-06-07 7:54 ` Kavyasree.Kotagiri [this message]
2022-06-07 7:56 ` Krzysztof Kozlowski
2022-06-03 12:18 ` [PATCH 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri
2022-06-06 8:44 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO1PR11MB4865CA9098EA7E1C052823D792A59@CO1PR11MB4865.namprd11.prod.outlook.com \
--to=kavyasree.kotagiri@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).