From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting
Date: Mon, 7 Jul 2014 13:15:13 +0100 [thread overview]
Message-ID: <20140707121512.GT3705@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <53BA8983.3030803@ti.com>
On Mon, Jul 07, 2014 at 05:20:27PM +0530, Sekhar Nori wrote:
> OMAP4430 had L2 cache controller version r2p0 (per the public TRM) which
> does not have this register. So unless there is a ROM API that was
> introduced after OMAP4430, this would not be there even for other
> OMAP4s. Public TRM of OMAP4470 does not indicate an API for this.
>
> Before creating the patch, I checked with ROM team handling AM437x and
> they denied an API to write to this register was present in AM437x ROM.
Okay, so why are we trying to write to this register then...
Ah, we have a bug in cache-l2x0.c:
#define L2X0_CACHE_ID_PART_MASK (0xf << 6)
#define L2X0_CACHE_ID_RTL_MASK 0x3f
#define L310_CACHE_ID_RTL_R3P0 0x05
unsigned rev = readl_relaxed(base + L2X0_CACHE_ID) & L2X0_CACHE_ID_PART_MASK;
if (rev >= L310_CACHE_ID_RTL_R2P0) {
...
if (rev >= L310_CACHE_ID_RTL_R3P0) {
l2c_write_sec(L310_DYNAMIC_CLK_GATING_EN | L310_STNDBY_MODE_EN,
base, L310_POWER_CTRL);
So, because we're masking the wrong bits, we end up with these tests
always succeeding.
So that's a NACK for the original patch, it's the wrong fix. The
right fix is to avoid writing this register by fixing the RTL masking.
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
next prev parent reply other threads:[~2014-07-07 12:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 10:34 [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting Sekhar Nori
2014-06-17 13:19 ` Felipe Balbi
2014-07-01 19:47 ` Felipe Balbi
2014-07-02 8:11 ` Tony Lindgren
2014-07-07 10:47 ` Tony Lindgren
2014-07-07 10:49 ` Russell King - ARM Linux
2014-07-07 11:02 ` Tony Lindgren
2014-07-07 11:50 ` Sekhar Nori
2014-07-07 12:15 ` Russell King - ARM Linux [this message]
2014-07-07 12:39 ` Tony Lindgren
2014-07-07 13:40 ` Russell King - ARM Linux
2014-07-07 15:10 ` Felipe Balbi
2014-07-08 4:54 ` Sekhar Nori
2014-07-08 8:29 ` Tony Lindgren
2014-07-09 9:25 ` Tony Lindgren
2014-07-09 12:26 ` Sekhar Nori
2014-07-09 12:31 ` Tony Lindgren
2014-07-09 12:39 ` Russell King - ARM Linux
2014-07-09 14:15 ` Santosh Shilimkar
2014-07-14 10:46 ` Sekhar Nori
2014-07-09 13:55 ` Felipe Balbi
2014-07-14 10:41 ` Sekhar Nori
2014-07-09 13:51 ` Felipe Balbi
2014-07-09 14:06 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140707121512.GT3705@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).