linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting
Date: Wed, 9 Jul 2014 13:39:50 +0100	[thread overview]
Message-ID: <20140709123950.GV3705@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <53BD34FD.5070005@ti.com>

On Wed, Jul 09, 2014 at 05:56:37PM +0530, Sekhar Nori wrote:
> On Wednesday 09 July 2014 02:55 PM, Tony Lindgren wrote:
> > I guess no more comments. Took a look at the patch again, Sekhar, can
> > you please update the description with what has been discovered in this
> > thread and repost?
> 
> How does the following sound:
> 
> ---
> AM437x has L2C-310 version r3p2 and ROM code on that device does not
> support writing to L2C-310 power control register. The L2C driver,
> however, tries writing to this register for all revisions >= r3p0.
> 
> This leads to a warning dump on boot which leads most users to believe
> that L2 cache is non-functional.
> 
> Since the problem is understood, and cannot be addressed through
> software, replace the warning with a pr_info() while maintaining the
> WARN_ON() for other truly unexpected scenarios.
> 
> >From the public TRM available for OMAP4470, even on that device, ROM
> does not support writing to this register even though it uses a version
> of L2C-310 which has the register implemented. So this patch should take
> care of all variants of existing OMAPs.
> ---

That sounds perfect, and explains why the change has to exist, and why
it can't be fixed elsewhere.  Thanks for providing the full reasoning in
the commit message.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  parent reply	other threads:[~2014-07-09 12:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 10:34 [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting Sekhar Nori
2014-06-17 13:19 ` Felipe Balbi
2014-07-01 19:47   ` Felipe Balbi
2014-07-02  8:11     ` Tony Lindgren
2014-07-07 10:47       ` Tony Lindgren
2014-07-07 10:49         ` Russell King - ARM Linux
2014-07-07 11:02           ` Tony Lindgren
2014-07-07 11:50             ` Sekhar Nori
2014-07-07 12:15               ` Russell King - ARM Linux
2014-07-07 12:39                 ` Tony Lindgren
2014-07-07 13:40                   ` Russell King - ARM Linux
2014-07-07 15:10                     ` Felipe Balbi
2014-07-08  4:54                       ` Sekhar Nori
2014-07-08  8:29                         ` Tony Lindgren
2014-07-09  9:25                           ` Tony Lindgren
2014-07-09 12:26                             ` Sekhar Nori
2014-07-09 12:31                               ` Tony Lindgren
2014-07-09 12:39                               ` Russell King - ARM Linux [this message]
2014-07-09 14:15                                 ` Santosh Shilimkar
2014-07-14 10:46                                   ` Sekhar Nori
2014-07-09 13:55                               ` Felipe Balbi
2014-07-14 10:41                                 ` Sekhar Nori
2014-07-09 13:51                             ` Felipe Balbi
2014-07-09 14:06                     ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140709123950.GV3705@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).