linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting
Date: Tue, 17 Jun 2014 16:04:51 +0530	[thread overview]
Message-ID: <3c3a7a4861df01d0163787a9c18f7b7ac821c5b9.1403000372.git.nsekhar@ti.com> (raw)

ROM code on AM437x does not support writing to L2C-310 power control
register. The L2C driver, however, tries writing to this register for
all revisions >= r3p0.

This leads to a warning dump on boot which leads most users to believe
that L2 cache is non-functional.

Since the problem is understood, and cannot be addressed through software,
replace the warning with a pr_info() while maintaining the WARN_ON() for
other truly unexpected scenarios.

Reported-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-omap2/omap4-common.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c
index 326cd98..9139729 100644
--- a/arch/arm/mach-omap2/omap4-common.c
+++ b/arch/arm/mach-omap2/omap4-common.c
@@ -188,6 +188,10 @@ static void omap4_l2c310_write_sec(unsigned long val, unsigned reg)
 		smc_op = OMAP4_MON_L2X0_PREFETCH_INDEX;
 		break;
 
+	case L310_POWER_CTRL:
+		pr_info_once("OMAP L2C310: ROM does not support power control setting\n");
+		return;
+
 	default:
 		WARN_ONCE(1, "OMAP L2C310: ignoring write to reg 0x%x\n", reg);
 		return;
-- 
1.7.10.1

             reply	other threads:[~2014-06-17 10:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17 10:34 Sekhar Nori [this message]
2014-06-17 13:19 ` [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting Felipe Balbi
2014-07-01 19:47   ` Felipe Balbi
2014-07-02  8:11     ` Tony Lindgren
2014-07-07 10:47       ` Tony Lindgren
2014-07-07 10:49         ` Russell King - ARM Linux
2014-07-07 11:02           ` Tony Lindgren
2014-07-07 11:50             ` Sekhar Nori
2014-07-07 12:15               ` Russell King - ARM Linux
2014-07-07 12:39                 ` Tony Lindgren
2014-07-07 13:40                   ` Russell King - ARM Linux
2014-07-07 15:10                     ` Felipe Balbi
2014-07-08  4:54                       ` Sekhar Nori
2014-07-08  8:29                         ` Tony Lindgren
2014-07-09  9:25                           ` Tony Lindgren
2014-07-09 12:26                             ` Sekhar Nori
2014-07-09 12:31                               ` Tony Lindgren
2014-07-09 12:39                               ` Russell King - ARM Linux
2014-07-09 14:15                                 ` Santosh Shilimkar
2014-07-14 10:46                                   ` Sekhar Nori
2014-07-09 13:55                               ` Felipe Balbi
2014-07-14 10:41                                 ` Sekhar Nori
2014-07-09 13:51                             ` Felipe Balbi
2014-07-09 14:06                     ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c3a7a4861df01d0163787a9c18f7b7ac821c5b9.1403000372.git.nsekhar@ti.com \
    --to=nsekhar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).