linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
@ 2014-07-07 13:23 Simon Horman
  2014-07-07 13:54 ` Sergei Shtylyov
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2014-07-07 13:23 UTC (permalink / raw)
  To: linux-arm-kernel

The R-Car Gen 2 PCIe driver provides PCIe host support for
Renesas R-Car Gen2 platforms. To increase hardware support enable
the driver in the shmobile_defconfig multiplatform configuration.

Cc: Phil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 5f05e98..6bc85a5 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
 CONFIG_ARM_ERRATA_754322=y
 CONFIG_PCI=y
 CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y
 CONFIG_SMP=y
 CONFIG_SCHED_MC=y
 CONFIG_HAVE_ARM_ARCH_TIMER=y
-- 
2.0.0.rc2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
  2014-07-07 13:23 [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig Simon Horman
@ 2014-07-07 13:54 ` Sergei Shtylyov
  2014-07-07 13:59   ` Phil Edworthy
  0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2014-07-07 13:54 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 07/07/2014 05:23 PM, Simon Horman wrote:

> The R-Car Gen 2 PCIe driver provides PCIe host support for
> Renesas R-Car Gen2 platforms. To increase hardware support enable
> the driver in the shmobile_defconfig multiplatform configuration.

> Cc: Phil Edworthy <phil.edworthy@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   arch/arm/configs/shmobile_defconfig | 1 +
>   1 file changed, 1 insertion(+)

> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 5f05e98..6bc85a5 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
>   CONFIG_ARM_ERRATA_754322=y
>   CONFIG_PCI=y
>   CONFIG_PCI_RCAR_GEN2=y
> +CONFIG_PCI_RCAR_GEN2_PCIE=y

    Hmm, I'm not sure why the option has GEN2 -- the driver claims support for 
R8A7779 as well as R8A779x. Probably the option should be renamed.

WBR, Sergei

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
  2014-07-07 13:54 ` Sergei Shtylyov
@ 2014-07-07 13:59   ` Phil Edworthy
  2014-07-08  8:15     ` Simon Horman
  0 siblings, 1 reply; 6+ messages in thread
From: Phil Edworthy @ 2014-07-07 13:59 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Sergei

On 07 July 2014 14:54, Sergei wrote:
> On 07/07/2014 05:23 PM, Simon Horman wrote:
> 
> > The R-Car Gen 2 PCIe driver provides PCIe host support for
> > Renesas R-Car Gen2 platforms. To increase hardware support enable
> > the driver in the shmobile_defconfig multiplatform configuration.
> 
> > Cc: Phil Edworthy <phil.edworthy@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> >   arch/arm/configs/shmobile_defconfig | 1 +
> >   1 file changed, 1 insertion(+)
> 
> > diff --git a/arch/arm/configs/shmobile_defconfig
> b/arch/arm/configs/shmobile_defconfig
> > index 5f05e98..6bc85a5 100644
> > --- a/arch/arm/configs/shmobile_defconfig
> > +++ b/arch/arm/configs/shmobile_defconfig
> > @@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
> >   CONFIG_ARM_ERRATA_754322=y
> >   CONFIG_PCI=y
> >   CONFIG_PCI_RCAR_GEN2=y
> > +CONFIG_PCI_RCAR_GEN2_PCIE=y
> 
>     Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
> R8A7779 as well as R8A779x. Probably the option should be renamed.
Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.

Phil

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
  2014-07-07 13:59   ` Phil Edworthy
@ 2014-07-08  8:15     ` Simon Horman
  2014-07-09  8:44       ` Simon Horman
  0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2014-07-08  8:15 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jul 07, 2014 at 01:59:12PM +0000, Phil Edworthy wrote:
> Hi Sergei
> 
> On 07 July 2014 14:54, Sergei wrote:
> > On 07/07/2014 05:23 PM, Simon Horman wrote:
> > 
> > > The R-Car Gen 2 PCIe driver provides PCIe host support for
> > > Renesas R-Car Gen2 platforms. To increase hardware support enable
> > > the driver in the shmobile_defconfig multiplatform configuration.
> > 
> > > Cc: Phil Edworthy <phil.edworthy@renesas.com>
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > ---
> > >   arch/arm/configs/shmobile_defconfig | 1 +
> > >   1 file changed, 1 insertion(+)
> > 
> > > diff --git a/arch/arm/configs/shmobile_defconfig
> > b/arch/arm/configs/shmobile_defconfig
> > > index 5f05e98..6bc85a5 100644
> > > --- a/arch/arm/configs/shmobile_defconfig
> > > +++ b/arch/arm/configs/shmobile_defconfig
> > > @@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
> > >   CONFIG_ARM_ERRATA_754322=y
> > >   CONFIG_PCI=y
> > >   CONFIG_PCI_RCAR_GEN2=y
> > > +CONFIG_PCI_RCAR_GEN2_PCIE=y
> > 
> >     Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
> > R8A7779 as well as R8A779x. Probably the option should be renamed.
> Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit
> accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.

It seems to me that dropping GEN2 from the config option may be a good idea.
But I believe that conversation is orthogonal to enabling the driver
in the defconfig. At this stage I plan to apply this patch.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
  2014-07-08  8:15     ` Simon Horman
@ 2014-07-09  8:44       ` Simon Horman
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-07-09  8:44 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Jul 08, 2014 at 10:15:44AM +0200, Simon Horman wrote:
> On Mon, Jul 07, 2014 at 01:59:12PM +0000, Phil Edworthy wrote:
> > Hi Sergei
> > 
> > On 07 July 2014 14:54, Sergei wrote:
> > > On 07/07/2014 05:23 PM, Simon Horman wrote:
> > > 
> > > > The R-Car Gen 2 PCIe driver provides PCIe host support for
> > > > Renesas R-Car Gen2 platforms. To increase hardware support enable
> > > > the driver in the shmobile_defconfig multiplatform configuration.
> > > 
> > > > Cc: Phil Edworthy <phil.edworthy@renesas.com>
> > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > > > ---
> > > >   arch/arm/configs/shmobile_defconfig | 1 +
> > > >   1 file changed, 1 insertion(+)
> > > 
> > > > diff --git a/arch/arm/configs/shmobile_defconfig
> > > b/arch/arm/configs/shmobile_defconfig
> > > > index 5f05e98..6bc85a5 100644
> > > > --- a/arch/arm/configs/shmobile_defconfig
> > > > +++ b/arch/arm/configs/shmobile_defconfig
> > > > @@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
> > > >   CONFIG_ARM_ERRATA_754322=y
> > > >   CONFIG_PCI=y
> > > >   CONFIG_PCI_RCAR_GEN2=y
> > > > +CONFIG_PCI_RCAR_GEN2_PCIE=y
> > > 
> > >     Hmm, I'm not sure why the option has GEN2 -- the driver claims support for
> > > R8A7779 as well as R8A779x. Probably the option should be renamed.
> > Technically, you are correct. However, whilst the driver does support R8A7779, that device only supports 32-bit
> > accesses over the PCIe bus so it's only useful for custom cards, not off-the-shelf PCIe cards.
> 
> It seems to me that dropping GEN2 from the config option may be a good idea.
> But I believe that conversation is orthogonal to enabling the driver
> in the defconfig. At this stage I plan to apply this patch.

I have queued up this change.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig
  2014-07-12 13:53 [GIT PULL] Third Round of Renesas ARM Based SoC Defconfig Updates for v3.17 Simon Horman
@ 2014-07-12 13:53 ` Simon Horman
  0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-07-12 13:53 UTC (permalink / raw)
  To: linux-arm-kernel

The R-Car Gen 2 PCIe driver provides PCIe host support for
Renesas R-Car Gen2 platforms. To increase hardware support enable
the driver in the shmobile_defconfig multiplatform configuration.

Cc: Phil Edworthy <phil.edworthy@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/configs/shmobile_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 5f05e98..6bc85a5 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -24,6 +24,7 @@ CONFIG_PL310_ERRATA_588369=y
 CONFIG_ARM_ERRATA_754322=y
 CONFIG_PCI=y
 CONFIG_PCI_RCAR_GEN2=y
+CONFIG_PCI_RCAR_GEN2_PCIE=y
 CONFIG_SMP=y
 CONFIG_SCHED_MC=y
 CONFIG_HAVE_ARM_ARCH_TIMER=y
-- 
2.0.0.rc2

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-07-12 13:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-07 13:23 [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig Simon Horman
2014-07-07 13:54 ` Sergei Shtylyov
2014-07-07 13:59   ` Phil Edworthy
2014-07-08  8:15     ` Simon Horman
2014-07-09  8:44       ` Simon Horman
2014-07-12 13:53 [GIT PULL] Third Round of Renesas ARM Based SoC Defconfig Updates for v3.17 Simon Horman
2014-07-12 13:53 ` [PATCH] ARM: shmobile: Enable R-Car Gen 2 PCIe in shmobile_defconfig Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).