* [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT
@ 2019-05-16 16:10 Jernej Skrabec
2019-05-17 7:30 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Jernej Skrabec @ 2019-05-16 16:10 UTC (permalink / raw)
To: maxime.ripard, wens
Cc: mark.rutland, devicetree, robh+dt, linux-kernel, linux-arm-kernel
mmc1 node where wifi module is connected doesn't have properly defined
power supplies so wifi module is never powered up. Fix that by
specifying additional power supplies.
Additionally, this STB may have either Realtek or Broadcom based wifi
module. One based on Broadcom module also needs external clock to work
properly. Fix that by adding clock property to wifi_pwrseq node.
Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 STB")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
index 6277f13f3eb3..6a0ac85b4616 100644
--- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
+++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
@@ -89,7 +89,10 @@
wifi_pwrseq: wifi_pwrseq {
compatible = "mmc-pwrseq-simple";
+ pinctrl-names = "default";
reset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
+ clocks = <&rtc 1>;
+ clock-names = "ext_clock";
};
sound_spdif {
@@ -155,6 +158,8 @@
&mmc1 {
vmmc-supply = <®_vcc3v3>;
+ vqmmc-supply = <®_vcc3v3>;
+ mmc-pwrseq = <&wifi_pwrseq>;
bus-width = <4>;
non-removable;
status = "okay";
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT
2019-05-16 16:10 [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT Jernej Skrabec
@ 2019-05-17 7:30 ` Maxime Ripard
2019-05-18 15:07 ` Jernej Škrabec
0 siblings, 1 reply; 4+ messages in thread
From: Maxime Ripard @ 2019-05-17 7:30 UTC (permalink / raw)
To: Jernej Skrabec
Cc: mark.rutland, devicetree, linux-kernel, wens, robh+dt, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1258 bytes --]
Hi,
On Thu, May 16, 2019 at 06:10:39PM +0200, Jernej Skrabec wrote:
> mmc1 node where wifi module is connected doesn't have properly defined
> power supplies so wifi module is never powered up. Fix that by
> specifying additional power supplies.
>
> Additionally, this STB may have either Realtek or Broadcom based wifi
> module. One based on Broadcom module also needs external clock to work
> properly. Fix that by adding clock property to wifi_pwrseq node.
>
> Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 STB")
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
> arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> index 6277f13f3eb3..6a0ac85b4616 100644
> --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> @@ -89,7 +89,10 @@
>
> wifi_pwrseq: wifi_pwrseq {
> compatible = "mmc-pwrseq-simple";
> + pinctrl-names = "default";
pinctrl-names only make sense with another pinctrl-[0-255]
property. Did you forgot something here?
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT
2019-05-17 7:30 ` Maxime Ripard
@ 2019-05-18 15:07 ` Jernej Škrabec
2019-05-20 7:24 ` Maxime Ripard
0 siblings, 1 reply; 4+ messages in thread
From: Jernej Škrabec @ 2019-05-18 15:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: mark.rutland, devicetree, linux-kernel, wens, robh+dt, linux-arm-kernel
Dne petek, 17. maj 2019 ob 09:30:48 CEST je Maxime Ripard napisal(a):
> Hi,
>
> On Thu, May 16, 2019 at 06:10:39PM +0200, Jernej Skrabec wrote:
> > mmc1 node where wifi module is connected doesn't have properly defined
> > power supplies so wifi module is never powered up. Fix that by
> > specifying additional power supplies.
> >
> > Additionally, this STB may have either Realtek or Broadcom based wifi
> > module. One based on Broadcom module also needs external clock to work
> > properly. Fix that by adding clock property to wifi_pwrseq node.
> >
> > Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 STB")
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > ---
> >
> > arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts index
> > 6277f13f3eb3..6a0ac85b4616 100644
> > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > @@ -89,7 +89,10 @@
> >
> > wifi_pwrseq: wifi_pwrseq {
> >
> > compatible = "mmc-pwrseq-simple";
> >
> > + pinctrl-names = "default";
>
> pinctrl-names only make sense with another pinctrl-[0-255]
> property. Did you forgot something here?
No, I just took BananaPi M2+ as a example, which has pinctrl-names property
too and no "pinctrl-*". But digging through history of this DT, it seems that
this is just leftover which somebody forgot to remove.
I'll send v2.
Best regards,
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT
2019-05-18 15:07 ` Jernej Škrabec
@ 2019-05-20 7:24 ` Maxime Ripard
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Ripard @ 2019-05-20 7:24 UTC (permalink / raw)
To: Jernej Škrabec
Cc: mark.rutland, devicetree, linux-kernel, wens, robh+dt, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1881 bytes --]
On Sat, May 18, 2019 at 05:07:11PM +0200, Jernej Škrabec wrote:
> Dne petek, 17. maj 2019 ob 09:30:48 CEST je Maxime Ripard napisal(a):
> > Hi,
> >
> > On Thu, May 16, 2019 at 06:10:39PM +0200, Jernej Skrabec wrote:
> > > mmc1 node where wifi module is connected doesn't have properly defined
> > > power supplies so wifi module is never powered up. Fix that by
> > > specifying additional power supplies.
> > >
> > > Additionally, this STB may have either Realtek or Broadcom based wifi
> > > module. One based on Broadcom module also needs external clock to work
> > > properly. Fix that by adding clock property to wifi_pwrseq node.
> > >
> > > Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 STB")
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > ---
> > >
> > > arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts index
> > > 6277f13f3eb3..6a0ac85b4616 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > @@ -89,7 +89,10 @@
> > >
> > > wifi_pwrseq: wifi_pwrseq {
> > >
> > > compatible = "mmc-pwrseq-simple";
> > >
> > > + pinctrl-names = "default";
> >
> > pinctrl-names only make sense with another pinctrl-[0-255]
> > property. Did you forgot something here?
>
> No, I just took BananaPi M2+ as a example, which has pinctrl-names property
> too and no "pinctrl-*". But digging through history of this DT, it seems that
> this is just leftover which somebody forgot to remove.
>
> I'll send v2.
This should be fixed in 5.2 thanks to the commit 75f9a058838b
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-20 7:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-16 16:10 [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT Jernej Skrabec
2019-05-17 7:30 ` Maxime Ripard
2019-05-18 15:07 ` Jernej Škrabec
2019-05-20 7:24 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).