[PATCH 1/2] drm/pl111: Deprecate the pads from the DT binding

[PATCH 1/2] drm/pl111: Deprecate the pads from the DT binding

[Linus Walleij]

The pads were an earlier workaround for the internal image
pipeline in the Linux fbdev subsystem. As we move to generic
definition of display properties and drivers that no longer
need this to work, deprecate this property.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>
Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 Documentation/devicetree/bindings/display/arm,pl11x.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/arm,pl11x.txt b/Documentation/devicetree/bindings/display/arm,pl11x.txt
index 572fa2773ec4..3f977e72a200 100644
--- a/Documentation/devicetree/bindings/display/arm,pl11x.txt
+++ b/Documentation/devicetree/bindings/display/arm,pl11x.txt
@@ -39,9 +39,11 @@ Required sub-nodes:
 
 - port: describes LCD panel signals, following the common binding
 	for video transmitter interfaces; see
-	Documentation/devicetree/bindings/media/video-interfaces.txt;
-	when it is a TFT panel, the port's endpoint must define the
-	following property:
+	Documentation/devicetree/bindings/media/video-interfaces.txt
+
+Deprecated properties:
+	The port's endbpoint subnode had this, now deprecated property
+	in the past. Drivers should be able to survive without it:
 
 	- arm,pl11x,tft-r0g0b0-pads: an array of three 32-bit values,
 		defining the way CLD pads are wired up; first value
@@ -80,7 +82,6 @@ Example:
 		port {
 			clcd_pads: endpoint {
 				remote-endpoint = <&clcd_panel>;
-				arm,pl11x,tft-r0g0b0-pads = <0 8 16>;
 			};
 		};
 
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH 2/2] drm/pl111: Drop special pads config check

[Linus Walleij]

This drops the check of the surplus "pads" configuration
from the device tree that is completely unused in the DRM
driver.

This was only used to work around limitations in the earlier
fbdev driver.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpu/drm/pl111/pl111_display.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
index e42fb6353623..8595a676b084 100644
--- a/drivers/gpu/drm/pl111/pl111_display.c
+++ b/drivers/gpu/drm/pl111/pl111_display.c
@@ -572,24 +572,8 @@ int pl111_display_init(struct drm_device *drm)
 {
 	struct pl111_drm_dev_private *priv = drm->dev_private;
 	struct device *dev = drm->dev;
-	struct device_node *endpoint;
-	u32 tft_r0b0g0[3];
 	int ret;
 
-	endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
-	if (!endpoint)
-		return -ENODEV;
-
-	if (of_property_read_u32_array(endpoint,
-				       "arm,pl11x,tft-r0g0b0-pads",
-				       tft_r0b0g0,
-				       ARRAY_SIZE(tft_r0b0g0)) != 0) {
-		dev_err(dev, "arm,pl11x,tft-r0g0b0-pads should be 3 ints\n");
-		of_node_put(endpoint);
-		return -ENOENT;
-	}
-	of_node_put(endpoint);
-
 	ret = pl111_init_clock_divider(drm);
 	if (ret)
 		return ret;
-- 
2.21.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] drm/pl111: Deprecate the pads from the DT binding

[Sam Ravnborg]

Hi Linus.

On Wed, Jul 24, 2019 at 03:49:58PM +0200, Linus Walleij wrote:
> The pads were an earlier workaround for the internal image
> pipeline in the Linux fbdev subsystem. As we move to generic
> definition of display properties and drivers that no longer
> need this to work, deprecate this property.
> 
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Acked-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  Documentation/devicetree/bindings/display/arm,pl11x.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/arm,pl11x.txt b/Documentation/devicetree/bindings/display/arm,pl11x.txt
> index 572fa2773ec4..3f977e72a200 100644
> --- a/Documentation/devicetree/bindings/display/arm,pl11x.txt
> +++ b/Documentation/devicetree/bindings/display/arm,pl11x.txt
> @@ -39,9 +39,11 @@ Required sub-nodes:
>  
>  - port: describes LCD panel signals, following the common binding
>  	for video transmitter interfaces; see
> -	Documentation/devicetree/bindings/media/video-interfaces.txt;
> -	when it is a TFT panel, the port's endpoint must define the
> -	following property:
> +	Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Deprecated properties:
> +	The port's endbpoint subnode had this, now deprecated property
> +	in the past. Drivers should be able to survive without it:
>  
>  	- arm,pl11x,tft-r0g0b0-pads: an array of three 32-bit values,
>  		defining the way CLD pads are wired up; first value
> @@ -80,7 +82,6 @@ Example:
>  		port {
>  			clcd_pads: endpoint {
>  				remote-endpoint = <&clcd_panel>;
> -				arm,pl11x,tft-r0g0b0-pads = <0 8 16>;
>  			};
>  		};
>  
> -- 
> 2.21.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] drm/pl111: Drop special pads config check

[Sam Ravnborg]

On Wed, Jul 24, 2019 at 03:49:59PM +0200, Linus Walleij wrote:
> This drops the check of the surplus "pads" configuration
> from the device tree that is completely unused in the DRM
> driver.
> 
> This was only used to work around limitations in the earlier
> fbdev driver.
> 
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Liviu Dudau <Liviu.Dudau@arm.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Always good to delete code.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  drivers/gpu/drm/pl111/pl111_display.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index e42fb6353623..8595a676b084 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -572,24 +572,8 @@ int pl111_display_init(struct drm_device *drm)
>  {
>  	struct pl111_drm_dev_private *priv = drm->dev_private;
>  	struct device *dev = drm->dev;
> -	struct device_node *endpoint;
> -	u32 tft_r0b0g0[3];
>  	int ret;
>  
> -	endpoint = of_graph_get_next_endpoint(dev->of_node, NULL);
> -	if (!endpoint)
> -		return -ENODEV;
> -
> -	if (of_property_read_u32_array(endpoint,
> -				       "arm,pl11x,tft-r0g0b0-pads",
> -				       tft_r0b0g0,
> -				       ARRAY_SIZE(tft_r0b0g0)) != 0) {
> -		dev_err(dev, "arm,pl11x,tft-r0g0b0-pads should be 3 ints\n");
> -		of_node_put(endpoint);
> -		return -ENOENT;
> -	}
> -	of_node_put(endpoint);
> -
>  	ret = pl111_init_clock_divider(drm);
>  	if (ret)
>  		return ret;
> -- 
> 2.21.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel