* [PATCH] drm/sti: Include the right header
@ 2019-08-23 7:14 Linus Walleij
2019-09-02 13:12 ` Benjamin Gaignard
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2019-08-23 7:14 UTC (permalink / raw)
To: dri-devel, Maarten Lankhorst, Maxime Ripard, Sean Paul
Cc: Linus Walleij, Vincent Abriou, Benjamin Gaignard, linux-arm-kernel
The sti_hdmi.c file include <linux/of_gpio.h> despite not even
using any GPIOs.
What it does use is devm_ioremap_nocache() which comes from
<linux/io.h> implicitly by including that header.
Fix this up by including the right header instead.
Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index f03d617edc4c..4f1aaf222cb0 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -9,7 +9,7 @@
#include <linux/debugfs.h>
#include <linux/hdmi.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
+#include <linux/io.h>
#include <linux/platform_device.h>
#include <linux/reset.h>
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/sti: Include the right header
2019-08-23 7:14 [PATCH] drm/sti: Include the right header Linus Walleij
@ 2019-09-02 13:12 ` Benjamin Gaignard
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Gaignard @ 2019-09-02 13:12 UTC (permalink / raw)
To: Linus Walleij
Cc: Maxime Ripard, Vincent Abriou, Maarten Lankhorst, ML dri-devel,
Sean Paul, Linux ARM
Le ven. 23 août 2019 à 09:14, Linus Walleij <linus.walleij@linaro.org> a écrit :
>
> The sti_hdmi.c file include <linux/of_gpio.h> despite not even
> using any GPIOs.
>
> What it does use is devm_ioremap_nocache() which comes from
> <linux/io.h> implicitly by including that header.
>
> Fix this up by including the right header instead.
Applied on drm-misc-next,
Thanks
Benjamin
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/gpu/drm/sti/sti_hdmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index f03d617edc4c..4f1aaf222cb0 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -9,7 +9,7 @@
> #include <linux/debugfs.h>
> #include <linux/hdmi.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> +#include <linux/io.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
>
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-02 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 7:14 [PATCH] drm/sti: Include the right header Linus Walleij
2019-09-02 13:12 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).