From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Subject: Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support
Date: Wed, 2 Oct 2019 09:34:10 -0600 [thread overview]
Message-ID: <20191002153410.GA10598@xps15> (raw)
In-Reply-To: <585ee38c-39d1-47df-78b7-f4b670f17a25@free.fr>
On Wed, Oct 02, 2019 at 05:21:23PM +0200, Marc Gonzalez wrote:
> On 02/10/2019 17:03, Mathieu Poirier wrote:
>
> > The problem here is that a debug and production device are using the
> > same device tree, i.e msm8998.dtsi. Disabling coresight devices in
> > the DTS file will allow the laptop to boot but completely disabled
> > coresight blocks on the MTP board. Leaving things as is breaks the
> > laptop but allows coresight to be used on the MTP board. One of three
> > things can happen:
> >
> > 1) Nothing gets done and production board can't boot without DTS modifications.
> > 2) Disable tags are added to the DTS file and the debug board can't
> > use coresight without modifications.
> > 2) The handling of the debug power domain is done properly on the
> > MSM8998 rather than relying on the bootloader to enable it.
> > 3) The DTS file is split or reorganised to account for debug/production devices.
>
> I believe 3) is already the de facto situation.
>
> arch/arm64/boot/dts/qcom/msm8998.dtsi is the "base" config.
> arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi for the MTP board.
> arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi for the laptops.
"DTS file", i.e msm8998.dtsi
>
> > Which of the above ends up being the final solution is entirely up to
> > David and Andy.
>
> 2498f8c1c668 ;-)
Then it is even easier to make a decision.
>
> Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-02 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 5:57 [PATCHv9 0/3] Add coresight support for SDM845, MSM8998 and MSM8996 Sai Prakash Ranjan
2019-07-31 5:58 ` [PATCHv9 1/3] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan
2019-07-31 6:05 ` Sai Prakash Ranjan
2019-08-07 10:08 ` Sai Prakash Ranjan
2019-08-07 10:12 ` Suzuki K Poulose
2019-08-07 11:16 ` Sai Prakash Ranjan
2019-07-31 5:58 ` [PATCHv9 2/3] arm64: dts: qcom: msm8998: " Sai Prakash Ranjan
2019-10-01 16:13 ` Jeffrey Hugo
2019-10-01 17:04 ` Sai Prakash Ranjan
2019-10-01 17:14 ` Jeffrey Hugo
2019-10-01 17:31 ` Suzuki K Poulose
2019-10-01 17:52 ` Sai Prakash Ranjan
2019-10-01 18:01 ` Jeffrey Hugo
2019-10-01 18:05 ` Sai Prakash Ranjan
2019-10-02 15:03 ` Mathieu Poirier
2019-10-02 15:21 ` Marc Gonzalez
2019-10-02 15:34 ` Mathieu Poirier [this message]
2019-10-02 15:49 ` Jeffrey Hugo
2019-10-03 10:20 ` Daniel Thompson
2019-10-03 10:52 ` Suzuki K Poulose
2019-10-03 12:52 ` Daniel Thompson
2019-07-31 5:58 ` [PATCHv9 3/3] arm64: dts: qcom: msm8996: " Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002153410.GA10598@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=saiprakash.ranjan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).