From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: daniel.thompson@linaro.org, mathieu.poirier@linaro.org
Cc: mark.rutland@arm.com, saiprakash.ranjan@codeaurora.org,
rnayak@codeaurora.org, jeffrey.l.hugo@gmail.com,
alexander.shishkin@linux.intel.com,
linux-arm-msm@vger.kernel.org, marc.w.gonzalez@free.fr,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
david.brown@linaro.org, agross@kernel.org, sibis@codeaurora.org,
leo.yan@linaro.org, linux-arm-msm-owner@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv9 2/3] arm64: dts: qcom: msm8998: Add Coresight support
Date: Thu, 3 Oct 2019 11:52:36 +0100 [thread overview]
Message-ID: <57349bda-0e86-5fe0-3be0-55b12748c346@arm.com> (raw)
In-Reply-To: <20191003102023.qk6ik5vmatheaofs@holly.lan>
On 10/03/2019 11:20 AM, Daniel Thompson wrote:
> On Wed, Oct 02, 2019 at 09:03:59AM -0600, Mathieu Poirier wrote:
>> On Tue, 1 Oct 2019 at 12:05, Sai Prakash Ranjan
>> <saiprakash.ranjan@codeaurora.org> wrote:
>>>
>>> On 2019-10-01 11:01, Jeffrey Hugo wrote:
>>>> On Tue, Oct 1, 2019 at 11:52 AM Sai Prakash Ranjan
>>>> <saiprakash.ranjan@codeaurora.org> wrote:
>>>>>
>>>>>
>>>>> Haan then likely it's the firmware issue.
>>>>> We should probably disable coresight in soc dtsi and enable only for
>>>>> MTP. For now you can add a status=disabled for all coresight nodes in
>>>>> msm8998.dtsi and I will send the patch doing the same in a day or
>>>>> two(sorry I am travelling currently).
>>>>
>>>> This sounds sane to me (and is what I did while bisecting the issue).
>>>> When you do create the patch, feel free to add the following tags as
>>>> you see fit.
>>>>
>>>> Reported-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>>>> Tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
>>>
>>> Thanks Jeffrey, I will add them.
>>> Hope Mathieu and Suzuki are OK with this.
>>
>> The problem here is that a debug and production device are using the
>> same device tree, i.e msm8998.dtsi. Disabling coresight devices in
>> the DTS file will allow the laptop to boot but completely disabled
>> coresight blocks on the MTP board. Leaving things as is breaks the
>> laptop but allows coresight to be used on the MTP board. One of three
>> things can happen:
>>
>> 1) Nothing gets done and production board can't boot without DTS modifications.
>> 2) Disable tags are added to the DTS file and the debug board can't
>> use coresight without modifications.
>> 2) The handling of the debug power domain is done properly on the
>> MSM8998 rather than relying on the bootloader to enable it.
>> 3) The DTS file is split or reorganised to account for debug/production devices.
>
> msm8998.dtsi is a SoC include file. Can't whatever default it adopts be
> reversed in the board include files such as msm8998-mtp.dtsi or
> msm8998-clamshell.dtsi ?
Or like Mathieu said, all the Coresight specific nodes could be moved in
to say, msm8998-coresight.dtsi and could be included into the platforms
where it actually works.
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-03 10:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 5:57 [PATCHv9 0/3] Add coresight support for SDM845, MSM8998 and MSM8996 Sai Prakash Ranjan
2019-07-31 5:58 ` [PATCHv9 1/3] arm64: dts: qcom: sdm845: Add Coresight support Sai Prakash Ranjan
2019-07-31 6:05 ` Sai Prakash Ranjan
2019-08-07 10:08 ` Sai Prakash Ranjan
2019-08-07 10:12 ` Suzuki K Poulose
2019-08-07 11:16 ` Sai Prakash Ranjan
2019-07-31 5:58 ` [PATCHv9 2/3] arm64: dts: qcom: msm8998: " Sai Prakash Ranjan
2019-10-01 16:13 ` Jeffrey Hugo
2019-10-01 17:04 ` Sai Prakash Ranjan
2019-10-01 17:14 ` Jeffrey Hugo
2019-10-01 17:31 ` Suzuki K Poulose
2019-10-01 17:52 ` Sai Prakash Ranjan
2019-10-01 18:01 ` Jeffrey Hugo
2019-10-01 18:05 ` Sai Prakash Ranjan
2019-10-02 15:03 ` Mathieu Poirier
2019-10-02 15:21 ` Marc Gonzalez
2019-10-02 15:34 ` Mathieu Poirier
2019-10-02 15:49 ` Jeffrey Hugo
2019-10-03 10:20 ` Daniel Thompson
2019-10-03 10:52 ` Suzuki K Poulose [this message]
2019-10-03 12:52 ` Daniel Thompson
2019-07-31 5:58 ` [PATCHv9 3/3] arm64: dts: qcom: msm8996: " Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57349bda-0e86-5fe0-3be0-55b12748c346@arm.com \
--to=suzuki.poulose@arm.com \
--cc=agross@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=david.brown@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=rnayak@codeaurora.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).