* [PATCH] pwm: imx27: Eliminate error message for defer probe
@ 2019-12-30 3:02 Anson Huang
2019-12-30 12:54 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Anson Huang @ 2019-12-30 3:02 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, shawnguo, s.hauer, kernel,
festevam, linux-pwm, linux-arm-kernel, linux-kernel
Cc: Linux-imx
For defer probe error, no need to output error message which
will cause confusion.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/pwm/pwm-imx27.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index 59d8b12..35a7ac42 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -319,9 +319,13 @@ static int pwm_imx27_probe(struct platform_device *pdev)
imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
if (IS_ERR(imx->clk_ipg)) {
- dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
- PTR_ERR(imx->clk_ipg));
- return PTR_ERR(imx->clk_ipg);
+ int ret = PTR_ERR(imx->clk_ipg);
+
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev,
+ "getting ipg clock failed with %d\n",
+ ret);
+ return ret;
}
imx->clk_per = devm_clk_get(&pdev->dev, "per");
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pwm: imx27: Eliminate error message for defer probe
2019-12-30 3:02 [PATCH] pwm: imx27: Eliminate error message for defer probe Anson Huang
@ 2019-12-30 12:54 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2019-12-30 12:54 UTC (permalink / raw)
To: Anson Huang
Cc: linux-pwm, shawnguo, s.hauer, linux-kernel, thierry.reding,
Linux-imx, kernel, festevam, linux-arm-kernel
On Mon, Dec 30, 2019 at 11:02:40AM +0800, Anson Huang wrote:
> For defer probe error, no need to output error message which
> will cause confusion.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/pwm/pwm-imx27.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
> index 59d8b12..35a7ac42 100644
> --- a/drivers/pwm/pwm-imx27.c
> +++ b/drivers/pwm/pwm-imx27.c
> @@ -319,9 +319,13 @@ static int pwm_imx27_probe(struct platform_device *pdev)
>
> imx->clk_ipg = devm_clk_get(&pdev->dev, "ipg");
> if (IS_ERR(imx->clk_ipg)) {
> - dev_err(&pdev->dev, "getting ipg clock failed with %ld\n",
> - PTR_ERR(imx->clk_ipg));
> - return PTR_ERR(imx->clk_ipg);
> + int ret = PTR_ERR(imx->clk_ipg);
> +
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev,
> + "getting ipg clock failed with %d\n",
> + ret);
While you touch this part, you could convert to %pe to get a more
expressive error message.
But even independent of this the patch is fine, so
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-30 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-30 3:02 [PATCH] pwm: imx27: Eliminate error message for defer probe Anson Huang
2019-12-30 12:54 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).