From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Tingwei Zhang <tingwei@codeaurora.org>
Cc: tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Kim Phillips <kim.phillips@arm.com>,
Mao Jinlong <jinlmao@codeaurora.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
coresight@lists.linaro.org, Randy Dunlap <rdunlap@infradead.org>,
Mian Yousaf Kaukab <ykaukab@suse.de>,
Russell King <linux@armlinux.org.uk>,
Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH v8 04/24] coresight: add coresight prefix to barrier_pkt
Date: Wed, 12 Aug 2020 11:58:31 -0600 [thread overview]
Message-ID: <20200812175831.GD3393195@xps15> (raw)
In-Reply-To: <20200807111153.7784-5-tingwei@codeaurora.org>
On Fri, Aug 07, 2020 at 07:11:33PM +0800, Tingwei Zhang wrote:
> Add coresight prefix to make it specific. It will be a export symbol.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
> Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
> drivers/hwtracing/coresight/coresight-priv.h | 8 ++++----
> drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
> drivers/hwtracing/coresight/coresight.c | 3 ++-
> 4 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c
> index 03e3f2590191..04ee9cda988d 100644
> --- a/drivers/hwtracing/coresight/coresight-etb10.c
> +++ b/drivers/hwtracing/coresight/coresight-etb10.c
> @@ -525,7 +525,7 @@ static unsigned long etb_update_buffer(struct coresight_device *csdev,
>
> cur = buf->cur;
> offset = buf->offset;
> - barrier = barrier_pkt;
> + barrier = coresight_barrier_pkt;
>
> for (i = 0; i < to_read; i += 4) {
> buf_ptr = buf->data_pages[cur] + offset;
> diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtracing/coresight/coresight-priv.h
> index d801a2755432..dcb8aeb6af62 100644
> --- a/drivers/hwtracing/coresight/coresight-priv.h
> +++ b/drivers/hwtracing/coresight/coresight-priv.h
> @@ -66,8 +66,8 @@ static DEVICE_ATTR_RO(name)
> #define coresight_simple_reg64(type, name, lo_off, hi_off) \
> __coresight_simple_func(type, NULL, name, lo_off, hi_off)
>
> -extern const u32 barrier_pkt[4];
> -#define CORESIGHT_BARRIER_PKT_SIZE (sizeof(barrier_pkt))
> +extern const u32 coresight_barrier_pkt[4];
> +#define CORESIGHT_BARRIER_PKT_SIZE (sizeof(coresight_barrier_pkt))
>
> enum etm_addr_type {
> ETM_ADDR_TYPE_NONE,
> @@ -104,10 +104,10 @@ struct cs_buffers {
> static inline void coresight_insert_barrier_packet(void *buf)
> {
> if (buf)
> - memcpy(buf, barrier_pkt, CORESIGHT_BARRIER_PKT_SIZE);
> + memcpy(buf, coresight_barrier_pkt,
> + CORESIGHT_BARRIER_PKT_SIZE);
Indentation problem.
> }
>
> -
> static inline void CS_LOCK(void __iomem *addr)
> {
> do {
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> index 6375504ba8b0..44402d413ebb 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> @@ -519,7 +519,7 @@ static unsigned long tmc_update_etf_buffer(struct coresight_device *csdev,
>
> cur = buf->cur;
> offset = buf->offset;
> - barrier = barrier_pkt;
> + barrier = coresight_barrier_pkt;
>
> /* for every byte to read */
> for (i = 0; i < to_read; i += 4) {
> diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> index e9c90f2de34a..310b1b825dd1 100644
> --- a/drivers/hwtracing/coresight/coresight.c
> +++ b/drivers/hwtracing/coresight/coresight.c
> @@ -53,7 +53,8 @@ static struct list_head *stm_path;
> * beginning of the data collected in a buffer. That way the decoder knows that
> * it needs to look for another sync sequence.
> */
> -const u32 barrier_pkt[4] = {0x7fffffff, 0x7fffffff, 0x7fffffff, 0x7fffffff};
> +const u32 coresight_barrier_pkt[4] = {
> + 0x7fffffff, 0x7fffffff, 0x7fffffff, 0x7fffffff};
As of kernel 5.8 lines up to 100 characters are allowed. No need to break this
line.
With that:
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> static int coresight_id_match(struct device *dev, void *data)
> {
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-12 18:00 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 11:11 [PATCH v8 00/24] coresight: allow to build coresight as modules Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 01/24] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang
2020-08-12 17:16 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 02/24] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang
2020-08-12 17:54 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 04/24] coresight: add coresight prefix to barrier_pkt Tingwei Zhang
2020-08-12 17:58 ` Mathieu Poirier [this message]
2020-08-07 11:11 ` [PATCH v8 05/24] coresight: export global symbols Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 06/24] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang
2020-08-12 19:36 ` Mathieu Poirier
2020-08-13 7:37 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 07/24] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang
2020-08-12 20:48 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 09/24] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang
2020-08-12 20:47 ` Mathieu Poirier
2020-08-13 2:16 ` Tingwei Zhang
2020-08-13 9:47 ` Suzuki K Poulose
2020-08-13 10:56 ` Tingwei Zhang
2020-08-13 17:00 ` Mathieu Poirier
2020-08-13 23:44 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 10/24] coresight: etm4x: allow etm4x " Tingwei Zhang
2020-08-13 19:39 ` Mathieu Poirier
2020-08-13 23:46 ` Suzuki K Poulose
2020-08-14 9:52 ` Tingwei Zhang
2020-08-14 10:42 ` Suzuki K Poulose
2020-08-14 11:00 ` Tingwei Zhang
2020-08-14 11:18 ` Suzuki K Poulose
2020-08-13 19:40 ` Mathieu Poirier
2020-08-13 23:58 ` Tingwei Zhang
2020-08-13 19:45 ` Mathieu Poirier
2020-08-13 23:57 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 11/24] coresight: etb: allow etb " Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 12/24] coresight: tpiu: allow tpiu " Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 13/24] coresight: tmc: allow tmc " Tingwei Zhang
2020-08-13 20:36 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 14/24] coresight: allow funnel driver to be built as module Tingwei Zhang
2020-08-13 20:15 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 15/24] coresight: allow replicator " Tingwei Zhang
2020-08-13 20:35 ` Mathieu Poirier
2020-08-14 0:08 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 16/24] coresight: cti: add function to register cti associate ops Tingwei Zhang
2020-08-17 16:02 ` Mathieu Poirier
2020-08-17 18:49 ` Mike Leach
2020-08-18 17:16 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 17/24] coresight: cti: Fix remove sysfs link error Tingwei Zhang
2020-08-17 16:15 ` Mathieu Poirier
2020-08-17 22:48 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 18/24] coresight: cti: Fix bug clearing sysfs links on callback Tingwei Zhang
2020-08-17 16:21 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 19/24] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang
2020-08-17 16:38 ` Mathieu Poirier
2020-08-17 19:04 ` Mike Leach
2020-08-18 17:39 ` Mathieu Poirier
2020-08-19 1:55 ` Tingwei Zhang
2020-08-19 19:50 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 20/24] coresight: cti: increase reference count when enabling cti Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 21/24] coresight: cti: allow cti to be built as a module Tingwei Zhang
2020-08-17 17:13 ` Mathieu Poirier
2020-08-17 19:14 ` Mike Leach
2020-08-18 17:42 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 22/24] coresight: tmc-etr: add function to register catu ops Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 23/24] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang
2020-08-17 17:39 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 24/24] coresight: allow the coresight core driver to be built as a module Tingwei Zhang
2020-08-17 17:47 ` Mathieu Poirier
2020-08-17 22:56 ` Tingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200812175831.GD3393195@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mike.leach@linaro.org \
--cc=rdunlap@infradead.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).