From: Tingwei Zhang <tingweiz@codeaurora.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: tsoni <tsoni@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Kim Phillips <kim.phillips@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Greg KH <gregkh@linuxfoundation.org>,
Coresight ML <coresight@lists.linaro.org>,
Mao Jinlong <jinlmao@codeaurora.org>,
Mian Yousaf Kaukab <ykaukab@suse.de>,
Russell King <linux@armlinux.org.uk>,
Randy Dunlap <rdunlap@infradead.org>,
Tingwei Zhang <tingwei@codeaurora.org>,
Leo Yan <leo.yan@linaro.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH v8 09/24] coresight: etm3x: allow etm3x to be built as a module
Date: Fri, 14 Aug 2020 07:44:22 +0800 [thread overview]
Message-ID: <20200813234422.GA23242@codeaurora.org> (raw)
In-Reply-To: <CANLsYkz5ZH0wkbCFbm5ie69xEso9zO8PFTCxoiCxL68nTJ9DUw@mail.gmail.com>
On Thu, Aug 13, 2020 at 11:00:04AM -0600, Mathieu Poirier wrote:
> On Thu, 13 Aug 2020 at 04:57, Tingwei Zhang <tingweiz@codeaurora.org> wrote:
> >
> > On Thu, Aug 13, 2020 at 05:47:22PM +0800, Suzuki K Poulose wrote:
> > > On 08/07/2020 12:11 PM, Tingwei Zhang wrote:
> > > >From: Kim Phillips <kim.phillips@arm.com>
> > > >
> > > >Allow to build coresight-etm3x as a module, for ease of development.
> > > >
> > > >- Kconfig becomes a tristate, to allow =m
> > > >- append -core to source file name to allow module to
> > > > be called coresight-etm3x by the Makefile
> > > >- add an etm_remove function, for module unload
> > > >- add a MODULE_DEVICE_TABLE for autoloading on boot
> > > >
> > > >Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > >Cc: Leo Yan <leo.yan@linaro.org>
> > > >Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> > > >Cc: Randy Dunlap <rdunlap@infradead.org>
> > > >Cc: Suzuki K Poulose <Suzuki.Poulose@arm.com>
> > > >Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > >Cc: Russell King <linux@armlinux.org.uk>
> > > >Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> > > >Signed-off-by: Tingwei Zhang <tingwei@codeaurora.org>
> > > >Reviewed-by: Mike Leach <mike.leach@linaro.org>
> > > >---
> > > > drivers/hwtracing/coresight/Kconfig | 5 +++-
> > > > drivers/hwtracing/coresight/Makefile | 3 ++-
> > > > ...resight-etm3x.c => coresight-etm3x-core.c} | 27 ++++++++++++++++++-
> > > > 3 files changed, 32 insertions(+), 3 deletions(-)
> > > > rename drivers/hwtracing/coresight/{coresight-etm3x.c =>
> > > >coresight-etm3x-core.c} (97%)
> > > >
> > > >diff --git a/drivers/hwtracing/coresight/Kconfig
> > > >b/drivers/hwtracing/coresight/Kconfig
> > > >index 6433f835fc97..8fd9fd139cf3 100644
> > > >--- a/drivers/hwtracing/coresight/Kconfig
> > > >+++ b/drivers/hwtracing/coresight/Kconfig
> > > >@@ -65,7 +65,7 @@ config CORESIGHT_SINK_ETBV10
> > > > special enhancement or added features.
> > > >
> > > > config CORESIGHT_SOURCE_ETM3X
> > > >- bool "CoreSight Embedded Trace Macrocell 3.x driver"
> > > >+ tristate "CoreSight Embedded Trace Macrocell 3.x driver"
> > > > depends on !ARM64
> > > > select CORESIGHT_LINKS_AND_SINKS
> > > > help
> > > >@@ -74,6 +74,9 @@ config CORESIGHT_SOURCE_ETM3X
> > > > This is primarily useful for instruction level tracing. Depending
> > > > the ETM version data tracing may also be available.
> > > >
> > > >+ To compile this driver as a module, choose M here: the
> > > >+ module will be called coresight-etm3x.
> > > >+
> > > > config CORESIGHT_SOURCE_ETM4X
> > > > bool "CoreSight Embedded Trace Macrocell 4.x driver"
> > > > depends on ARM64
> > > >diff --git a/drivers/hwtracing/coresight/Makefile
> > > >b/drivers/hwtracing/coresight/Makefile
> > > >index 19497d1d92bf..d619cfd0abd8 100644
> > > >--- a/drivers/hwtracing/coresight/Makefile
> > > >+++ b/drivers/hwtracing/coresight/Makefile
> > > >@@ -11,7 +11,8 @@ obj-$(CONFIG_CORESIGHT_SINK_TPIU) += coresight-tpiu.o
> > > > obj-$(CONFIG_CORESIGHT_SINK_ETBV10) += coresight-etb10.o
> > > > obj-$(CONFIG_CORESIGHT_LINKS_AND_SINKS) += coresight-funnel.o \
> > > > coresight-replicator.o
> > > >-obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o
> > > >coresight-etm-cp14.o \
> > > >+obj-$(CONFIG_CORESIGHT_SOURCE_ETM3X) += coresight-etm3x.o
> > > >+coresight-etm3x-y := coresight-etm3x-core.o coresight-etm-cp14.o \
> > > > coresight-etm3x-sysfs.o
> > > > obj-$(CONFIG_CORESIGHT_SOURCE_ETM4X) += coresight-etm4x.o \
> > > > coresight-etm4x-sysfs.o
> > > >diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c
> > > >b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> > > >similarity index 97%
> > > >rename from drivers/hwtracing/coresight/coresight-etm3x.c
> > > >rename to drivers/hwtracing/coresight/coresight-etm3x-core.c
> > > >index bf22dcfd3327..82b333c40006 100644
> > > >--- a/drivers/hwtracing/coresight/coresight-etm3x.c
> > > >+++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c
> > > >@@ -895,6 +895,23 @@ static int etm_probe(struct amba_device *adev, const
> > > >struct amba_id *id)
> > > > return ret;
> > > > }
> > > >
> > > >+static int __exit etm_remove(struct amba_device *adev)
> > > >+{
> > > >+ struct etm_drvdata *drvdata = dev_get_drvdata(&adev->dev);
> > > >+
> > > >+ etm_perf_symlink(drvdata->csdev, false);
> > > >+
> > > >+ if (--etm_count == 0) {
> > > >+ cpuhp_remove_state_nocalls(CPUHP_AP_ARM_CORESIGHT_STARTING);
> > > >+ if (hp_online)
> > > >+ cpuhp_remove_state_nocalls(hp_online);
> > > >+ }
> > > >+
> > >
> > > As mentioned in the previous version, this needs fixing
> > > similar to the etm4x to avoid races with etm_count. I understand
> > > that it is an exisiting problem. But this set exposes it more
> > > due to etm_remove() calls and is much more probable to hit it.
> > >
> > OK. I'll fix this. Can you help to review ETM4 fix? If that's fine,
> > I'll make similar fix here.
> >
> > Unfortunately, I don't have any device with ETM3. Can anyone help
> > to verify the function on ETM3? I'll really appreciate that.
>
> I'll take care of ETMv3. Please wait before sending a new revision
> since I am still reviewing the current set. I will let you know when
> I am done.
>
Thanks a lot, Mathieu. I'll wait for your comments.
> >
> > Thanks,
> > Tingwei
> > >
> > > Suzuki
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-13 23:46 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 11:11 [PATCH v8 00/24] coresight: allow to build coresight as modules Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 01/24] coresight: cpu_debug: add module name in Kconfig Tingwei Zhang
2020-08-12 17:16 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 02/24] coresight: cpu_debug: define MODULE_DEVICE_TABLE Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules Tingwei Zhang
2020-08-12 17:54 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 04/24] coresight: add coresight prefix to barrier_pkt Tingwei Zhang
2020-08-12 17:58 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 05/24] coresight: export global symbols Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 06/24] coresight: add try_get_module() in coresight_grab_device() Tingwei Zhang
2020-08-12 19:36 ` Mathieu Poirier
2020-08-13 7:37 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 07/24] coresight: stm: allow to build coresight-stm as a module Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure Tingwei Zhang
2020-08-12 20:48 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 09/24] coresight: etm3x: allow etm3x to be built as a module Tingwei Zhang
2020-08-12 20:47 ` Mathieu Poirier
2020-08-13 2:16 ` Tingwei Zhang
2020-08-13 9:47 ` Suzuki K Poulose
2020-08-13 10:56 ` Tingwei Zhang
2020-08-13 17:00 ` Mathieu Poirier
2020-08-13 23:44 ` Tingwei Zhang [this message]
2020-08-07 11:11 ` [PATCH v8 10/24] coresight: etm4x: allow etm4x " Tingwei Zhang
2020-08-13 19:39 ` Mathieu Poirier
2020-08-13 23:46 ` Suzuki K Poulose
2020-08-14 9:52 ` Tingwei Zhang
2020-08-14 10:42 ` Suzuki K Poulose
2020-08-14 11:00 ` Tingwei Zhang
2020-08-14 11:18 ` Suzuki K Poulose
2020-08-13 19:40 ` Mathieu Poirier
2020-08-13 23:58 ` Tingwei Zhang
2020-08-13 19:45 ` Mathieu Poirier
2020-08-13 23:57 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 11/24] coresight: etb: allow etb " Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 12/24] coresight: tpiu: allow tpiu " Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 13/24] coresight: tmc: allow tmc " Tingwei Zhang
2020-08-13 20:36 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 14/24] coresight: allow funnel driver to be built as module Tingwei Zhang
2020-08-13 20:15 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 15/24] coresight: allow replicator " Tingwei Zhang
2020-08-13 20:35 ` Mathieu Poirier
2020-08-14 0:08 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 16/24] coresight: cti: add function to register cti associate ops Tingwei Zhang
2020-08-17 16:02 ` Mathieu Poirier
2020-08-17 18:49 ` Mike Leach
2020-08-18 17:16 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 17/24] coresight: cti: Fix remove sysfs link error Tingwei Zhang
2020-08-17 16:15 ` Mathieu Poirier
2020-08-17 22:48 ` Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 18/24] coresight: cti: Fix bug clearing sysfs links on callback Tingwei Zhang
2020-08-17 16:21 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 19/24] coresight: cti: don't disable ect device if it's not enabled Tingwei Zhang
2020-08-17 16:38 ` Mathieu Poirier
2020-08-17 19:04 ` Mike Leach
2020-08-18 17:39 ` Mathieu Poirier
2020-08-19 1:55 ` Tingwei Zhang
2020-08-19 19:50 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 20/24] coresight: cti: increase reference count when enabling cti Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 21/24] coresight: cti: allow cti to be built as a module Tingwei Zhang
2020-08-17 17:13 ` Mathieu Poirier
2020-08-17 19:14 ` Mike Leach
2020-08-18 17:42 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 22/24] coresight: tmc-etr: add function to register catu ops Tingwei Zhang
2020-08-07 11:11 ` [PATCH v8 23/24] coresight: catu: allow catu drivers to be built as modules Tingwei Zhang
2020-08-17 17:39 ` Mathieu Poirier
2020-08-07 11:11 ` [PATCH v8 24/24] coresight: allow the coresight core driver to be built as a module Tingwei Zhang
2020-08-17 17:47 ` Mathieu Poirier
2020-08-17 22:56 ` Tingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813234422.GA23242@codeaurora.org \
--to=tingweiz@codeaurora.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jinlmao@codeaurora.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=rdunlap@infradead.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).