* [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL
@ 2020-09-14 12:38 Necip Fazil Yildiran
2020-09-24 15:20 ` Sekhar Nori
0 siblings, 1 reply; 2+ messages in thread
From: Necip Fazil Yildiran @ 2020-09-14 12:38 UTC (permalink / raw)
To: nsekhar
Cc: arnd, paul, Necip Fazil Yildiran, linux-kernel, bgolaszewski,
jeho, linux-arm-kernel
When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results
in the following Kbuild warning:
WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
Selected by [y]:
- ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]
The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on
or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
---
arch/arm/mach-davinci/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index f56ff8c24043..e0cbcda6f087 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -11,6 +11,7 @@ menuconfig ARCH_DAVINCI
select REGMAP_MMIO
select RESET_CONTROLLER
select HAVE_IDE
+ select PINCTRL
select PINCTRL_SINGLE
if ARCH_DAVINCI
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL
2020-09-14 12:38 [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL Necip Fazil Yildiran
@ 2020-09-24 15:20 ` Sekhar Nori
0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2020-09-24 15:20 UTC (permalink / raw)
To: Necip Fazil Yildiran
Cc: arnd, paul, linux-kernel, bgolaszewski, jeho, linux-arm-kernel
Hi Necip,
On 14/09/20 6:08 PM, Necip Fazil Yildiran wrote:
> When ARCH_DAVINCI is enabled and PINCTRL is disabled, it results
> in the following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for PINCTRL_SINGLE
> Depends on [n]: PINCTRL [=n] && OF [=y] && HAS_IOMEM [=y]
> Selected by [y]:
> - ARCH_DAVINCI [=y] && ARCH_MULTI_V5 [=y]
>
> The reason is that ARCH_DAVINCI selects PINCTRL_SINGLE without depending on
> or selecting PINCTRL while PINCTRL_SINGLE is subordinate to PINCTRL.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
I think its better to fix this by changing the "select PINCTRL_SINGLE"
to "imply PINCTRL_SINGLE". It should be valid to build a DaVinci kernel
without pinctrl support if bootloader is taking care of the pin muxing.
I would not recommend it, but its not illegal either.
While at it, I would drop the other "select PINCTRL" line under "config
MACH_DA8XX_DT". It should not be needed since ARCH_DAVINCI will imply
PINCTRL_SINGLE
Thanks,
Sekhar
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-24 15:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 12:38 [PATCH] ARM: davinci: fix kconfig dependency warning when !PINCTRL Necip Fazil Yildiran
2020-09-24 15:20 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).