* [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested
@ 2021-02-15 11:57 Daniel Palmer
2021-02-15 11:57 ` [PATCH 2/2] clk: mstar: msc313-mpll: Fix format specifier Daniel Palmer
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Palmer @ 2021-02-15 11:57 UTC (permalink / raw)
To: linux-clk, linux-arm-kernel, sboyd; +Cc: Daniel Palmer
Allow COMPILE_TEST to also build the MStar clk drivers
instead of only building them when ARCH_MSTARV7 is selected.
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Suggested-by: Stephen Boyd <sboyd@kernel.org>
---
drivers/clk/Makefile | 2 +-
drivers/clk/mstar/Kconfig | 7 ++++++-
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
index 7fed7e5944cd..e5e23a44fbe9 100644
--- a/drivers/clk/Makefile
+++ b/drivers/clk/Makefile
@@ -95,7 +95,7 @@ obj-$(CONFIG_MACH_PIC32) += microchip/
ifeq ($(CONFIG_COMMON_CLK), y)
obj-$(CONFIG_ARCH_MMP) += mmp/
endif
-obj-$(CONFIG_ARCH_MSTARV7) += mstar/
+obj-y += mstar/
obj-y += mvebu/
obj-$(CONFIG_ARCH_MXS) += mxs/
obj-$(CONFIG_COMMON_CLK_NXP) += nxp/
diff --git a/drivers/clk/mstar/Kconfig b/drivers/clk/mstar/Kconfig
index 23765edde3af..eab8f7dcaa90 100644
--- a/drivers/clk/mstar/Kconfig
+++ b/drivers/clk/mstar/Kconfig
@@ -1,5 +1,10 @@
# SPDX-License-Identifier: GPL-2.0-only
config MSTAR_MSC313_MPLL
- bool
+ bool "MStar MPLL driver"
+ depends on ARCH_MSTARV7 || COMPILE_TEST
+ default ARCH_MSTARV7
select REGMAP
select REGMAP_MMIO
+ help
+ Support for the MPLL PLL and dividers block present on
+ MStar/Sigmastar SoCs.
--
2.30.0.rc2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] clk: mstar: msc313-mpll: Fix format specifier
2021-02-15 11:57 [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Daniel Palmer
@ 2021-02-15 11:57 ` Daniel Palmer
2021-02-16 20:48 ` Stephen Boyd
2021-02-16 20:48 ` [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Stephen Boyd
2021-02-16 20:54 ` Stephen Boyd
2 siblings, 1 reply; 5+ messages in thread
From: Daniel Palmer @ 2021-02-15 11:57 UTC (permalink / raw)
To: linux-clk, linux-arm-kernel, sboyd; +Cc: Daniel Palmer
The output dividers are unsigned int so the format specifier
should have been %u not %d.
Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
drivers/clk/mstar/clk-msc313-mpll.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/mstar/clk-msc313-mpll.c b/drivers/clk/mstar/clk-msc313-mpll.c
index 09f578108eef..61beb4e87525 100644
--- a/drivers/clk/mstar/clk-msc313-mpll.c
+++ b/drivers/clk/mstar/clk-msc313-mpll.c
@@ -123,7 +123,7 @@ static int msc313_mpll_probe(struct platform_device *pdev)
mpll->clk_data->hws[0] = &mpll->clk_hw;
for (i = 0; i < ARRAY_SIZE(output_dividers); i++) {
- outputname = devm_kasprintf(dev, GFP_KERNEL, "%s_div_%d",
+ outputname = devm_kasprintf(dev, GFP_KERNEL, "%s_div_%u",
clk_init.name, output_dividers[i]);
if (!outputname)
return -ENOMEM;
--
2.30.0.rc2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested
2021-02-15 11:57 [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Daniel Palmer
2021-02-15 11:57 ` [PATCH 2/2] clk: mstar: msc313-mpll: Fix format specifier Daniel Palmer
@ 2021-02-16 20:48 ` Stephen Boyd
2021-02-16 20:54 ` Stephen Boyd
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2021-02-16 20:48 UTC (permalink / raw)
To: Daniel Palmer, linux-arm-kernel, linux-clk; +Cc: Daniel Palmer
Quoting Daniel Palmer (2021-02-15 03:57:09)
> Allow COMPILE_TEST to also build the MStar clk drivers
> instead of only building them when ARCH_MSTARV7 is selected.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> ---
Applied to clk-next
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested
2021-02-15 11:57 [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Daniel Palmer
2021-02-15 11:57 ` [PATCH 2/2] clk: mstar: msc313-mpll: Fix format specifier Daniel Palmer
2021-02-16 20:48 ` [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Stephen Boyd
@ 2021-02-16 20:54 ` Stephen Boyd
2 siblings, 0 replies; 5+ messages in thread
From: Stephen Boyd @ 2021-02-16 20:54 UTC (permalink / raw)
To: Daniel Palmer, linux-arm-kernel, linux-clk; +Cc: Daniel Palmer
Quoting Daniel Palmer (2021-02-15 03:57:09)
> Allow COMPILE_TEST to also build the MStar clk drivers
> instead of only building them when ARCH_MSTARV7 is selected.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> ---
> drivers/clk/Makefile | 2 +-
> drivers/clk/mstar/Kconfig | 7 ++++++-
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index 7fed7e5944cd..e5e23a44fbe9 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -95,7 +95,7 @@ obj-$(CONFIG_MACH_PIC32) += microchip/
> ifeq ($(CONFIG_COMMON_CLK), y)
> obj-$(CONFIG_ARCH_MMP) += mmp/
> endif
> -obj-$(CONFIG_ARCH_MSTARV7) += mstar/
> +obj-y += mstar/
> obj-y += mvebu/
> obj-$(CONFIG_ARCH_MXS) += mxs/
> obj-$(CONFIG_COMMON_CLK_NXP) += nxp/
> diff --git a/drivers/clk/mstar/Kconfig b/drivers/clk/mstar/Kconfig
> index 23765edde3af..eab8f7dcaa90 100644
> --- a/drivers/clk/mstar/Kconfig
> +++ b/drivers/clk/mstar/Kconfig
> @@ -1,5 +1,10 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config MSTAR_MSC313_MPLL
> - bool
> + bool "MStar MPLL driver"
> + depends on ARCH_MSTARV7 || COMPILE_TEST
> + default ARCH_MSTARV7
> select REGMAP
I've also removed this select REGMAP. It isn't necessary as this selects
REGMAP_MMIO.
> select REGMAP_MMIO
> + help
> + Support for the MPLL PLL and dividers block present on
> + MStar/Sigmastar SoCs.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-02-16 20:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-15 11:57 [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Daniel Palmer
2021-02-15 11:57 ` [PATCH 2/2] clk: mstar: msc313-mpll: Fix format specifier Daniel Palmer
2021-02-16 20:48 ` Stephen Boyd
2021-02-16 20:48 ` [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Stephen Boyd
2021-02-16 20:54 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).