* [PATCH 1/2] Perf: Clean generated directory, other archs.
@ 2021-03-03 18:32 Gon Solo
2021-03-06 19:28 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Gon Solo @ 2021-03-03 18:32 UTC (permalink / raw)
To: John Garry, Will Deacon, Mathieu Poirier, Leo Yan,
Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim
Cc: Gon Solo, linux-arm-kernel, linux-kernel
---
tools/perf/arch/arm64/Makefile | 5 +++--
tools/perf/arch/powerpc/Makefile | 5 +++--
tools/perf/arch/s390/Makefile | 5 +++--
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
index fab3095fb5d0..426aecdd0b71 100644
--- a/tools/perf/arch/arm64/Makefile
+++ b/tools/perf/arch/arm64/Makefile
@@ -10,7 +10,8 @@ HAVE_KVM_STAT_SUPPORT := 1
# Syscall table generation for perf
#
-out := $(OUTPUT)arch/arm64/include/generated/asm
+generated := $(OUTPUT)arch/arm64/include/generated
+out := $(generated)/asm
header := $(out)/syscalls.c
incpath := $(srctree)/tools
sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
@@ -24,6 +25,6 @@ $(header): $(sysdef) $(systbl)
$(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@
clean::
- $(call QUIET_CLEAN, arm64) $(RM) $(header)
+ $(call QUIET_CLEAN, arm64) $(RM) -r $(header) $(generated)
archheaders: $(header)
diff --git a/tools/perf/arch/powerpc/Makefile b/tools/perf/arch/powerpc/Makefile
index 840ea0e59287..979c2bebc167 100644
--- a/tools/perf/arch/powerpc/Makefile
+++ b/tools/perf/arch/powerpc/Makefile
@@ -11,7 +11,8 @@ PERF_HAVE_JITDUMP := 1
# Syscall table generation for perf
#
-out := $(OUTPUT)arch/powerpc/include/generated/asm
+generated := $(OUTPUT)arch/powerpc/include/generated
+out := $(generated)/asm
header32 := $(out)/syscalls_32.c
header64 := $(out)/syscalls_64.c
sysprf := $(srctree)/tools/perf/arch/powerpc/entry/syscalls
@@ -28,6 +29,6 @@ $(header32): $(sysdef) $(systbl)
$(Q)$(SHELL) '$(systbl)' '32' $(sysdef) > $@
clean::
- $(call QUIET_CLEAN, powerpc) $(RM) $(header32) $(header64)
+ $(call QUIET_CLEAN, powerpc) $(RM) -r $(header32) $(header64) $(generated)
archheaders: $(header32) $(header64)
diff --git a/tools/perf/arch/s390/Makefile b/tools/perf/arch/s390/Makefile
index 74bffbea03e2..27cf67f1cc78 100644
--- a/tools/perf/arch/s390/Makefile
+++ b/tools/perf/arch/s390/Makefile
@@ -10,7 +10,8 @@ PERF_HAVE_JITDUMP := 1
# Syscall table generation for perf
#
-out := $(OUTPUT)arch/s390/include/generated/asm
+generated := $(OUTPUT)arch/s390/include/generated
+out := $(generated)/asm
header := $(out)/syscalls_64.c
sysprf := $(srctree)/tools/perf/arch/s390/entry/syscalls
sysdef := $(sysprf)/syscall.tbl
@@ -23,6 +24,6 @@ $(header): $(sysdef) $(systbl)
$(Q)$(SHELL) '$(systbl)' $(sysdef) > $@
clean::
- $(call QUIET_CLEAN, s390) $(RM) $(header)
+ $(call QUIET_CLEAN, s390) $(RM) -r $(header) $(generted)
archheaders: $(header)
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Perf: Clean generated directory, other archs.
2021-03-03 18:32 [PATCH 1/2] Perf: Clean generated directory, other archs Gon Solo
@ 2021-03-06 19:28 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-03-06 19:28 UTC (permalink / raw)
To: Gon Solo
Cc: John Garry, Will Deacon, Mathieu Poirier, Leo Yan,
Peter Zijlstra, Ingo Molnar, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, linux-arm-kernel, linux-kernel
Em Wed, Mar 03, 2021 at 07:32:46PM +0100, Gon Solo escreveu:
You forgot to add an explanation here and to add your:
Signed-off-by: Gon Solo <gonsolo@gmail.com>
In this case a:
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Is also appropriate, since I pointed you in this direction.
Please take a look at:
Documentation/process/submitting-patches.rst
Direct link for your convenience:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst
Thanks for working on this!
- Arnaldo
> ---
> tools/perf/arch/arm64/Makefile | 5 +++--
> tools/perf/arch/powerpc/Makefile | 5 +++--
> tools/perf/arch/s390/Makefile | 5 +++--
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
> index fab3095fb5d0..426aecdd0b71 100644
> --- a/tools/perf/arch/arm64/Makefile
> +++ b/tools/perf/arch/arm64/Makefile
> @@ -10,7 +10,8 @@ HAVE_KVM_STAT_SUPPORT := 1
> # Syscall table generation for perf
> #
>
> -out := $(OUTPUT)arch/arm64/include/generated/asm
> +generated := $(OUTPUT)arch/arm64/include/generated
> +out := $(generated)/asm
> header := $(out)/syscalls.c
> incpath := $(srctree)/tools
> sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
> @@ -24,6 +25,6 @@ $(header): $(sysdef) $(systbl)
> $(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@
>
> clean::
> - $(call QUIET_CLEAN, arm64) $(RM) $(header)
> + $(call QUIET_CLEAN, arm64) $(RM) -r $(header) $(generated)
>
> archheaders: $(header)
> diff --git a/tools/perf/arch/powerpc/Makefile b/tools/perf/arch/powerpc/Makefile
> index 840ea0e59287..979c2bebc167 100644
> --- a/tools/perf/arch/powerpc/Makefile
> +++ b/tools/perf/arch/powerpc/Makefile
> @@ -11,7 +11,8 @@ PERF_HAVE_JITDUMP := 1
> # Syscall table generation for perf
> #
>
> -out := $(OUTPUT)arch/powerpc/include/generated/asm
> +generated := $(OUTPUT)arch/powerpc/include/generated
> +out := $(generated)/asm
> header32 := $(out)/syscalls_32.c
> header64 := $(out)/syscalls_64.c
> sysprf := $(srctree)/tools/perf/arch/powerpc/entry/syscalls
> @@ -28,6 +29,6 @@ $(header32): $(sysdef) $(systbl)
> $(Q)$(SHELL) '$(systbl)' '32' $(sysdef) > $@
>
> clean::
> - $(call QUIET_CLEAN, powerpc) $(RM) $(header32) $(header64)
> + $(call QUIET_CLEAN, powerpc) $(RM) -r $(header32) $(header64) $(generated)
>
> archheaders: $(header32) $(header64)
> diff --git a/tools/perf/arch/s390/Makefile b/tools/perf/arch/s390/Makefile
> index 74bffbea03e2..27cf67f1cc78 100644
> --- a/tools/perf/arch/s390/Makefile
> +++ b/tools/perf/arch/s390/Makefile
> @@ -10,7 +10,8 @@ PERF_HAVE_JITDUMP := 1
> # Syscall table generation for perf
> #
>
> -out := $(OUTPUT)arch/s390/include/generated/asm
> +generated := $(OUTPUT)arch/s390/include/generated
> +out := $(generated)/asm
> header := $(out)/syscalls_64.c
> sysprf := $(srctree)/tools/perf/arch/s390/entry/syscalls
> sysdef := $(sysprf)/syscall.tbl
> @@ -23,6 +24,6 @@ $(header): $(sysdef) $(systbl)
> $(Q)$(SHELL) '$(systbl)' $(sysdef) > $@
>
> clean::
> - $(call QUIET_CLEAN, s390) $(RM) $(header)
> + $(call QUIET_CLEAN, s390) $(RM) -r $(header) $(generted)
>
> archheaders: $(header)
> --
> 2.27.0
>
--
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Perf: Clean generated directory, other archs.
2021-03-07 10:19 Gon Solo
@ 2021-03-25 12:40 ` Will Deacon
0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2021-03-25 12:40 UTC (permalink / raw)
To: Gon Solo
Cc: John Garry, Mathieu Poirier, Leo Yan, Peter Zijlstra,
Ingo Molnar, Arnaldo Carvalho de Melo, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Andreas Wendleder,
linux-arm-kernel, linux-kernel
On Sun, Mar 07, 2021 at 11:19:42AM +0100, Gon Solo wrote:
> After a make clean there are generated directories left in the arch
> directories of perf. Clean them up.
>
> Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
> Signed-off-by: Andreas Wendleder <andreas.wendleder@gmail.com>
> ---
> tools/perf/arch/arm64/Makefile | 5 +++--
> tools/perf/arch/powerpc/Makefile | 5 +++--
> tools/perf/arch/s390/Makefile | 5 +++--
> 3 files changed, 9 insertions(+), 6 deletions(-)
For arm64:
Acked-by: Will Deacon <will@kernel.org>
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] Perf: Clean generated directory, other archs.
@ 2021-03-07 10:19 Gon Solo
2021-03-25 12:40 ` Will Deacon
0 siblings, 1 reply; 4+ messages in thread
From: Gon Solo @ 2021-03-07 10:19 UTC (permalink / raw)
To: John Garry, Will Deacon, Mathieu Poirier, Leo Yan,
Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim
Cc: Gon Solo, Andreas Wendleder, linux-arm-kernel, linux-kernel
After a make clean there are generated directories left in the arch
directories of perf. Clean them up.
Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Andreas Wendleder <andreas.wendleder@gmail.com>
---
tools/perf/arch/arm64/Makefile | 5 +++--
tools/perf/arch/powerpc/Makefile | 5 +++--
tools/perf/arch/s390/Makefile | 5 +++--
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/tools/perf/arch/arm64/Makefile b/tools/perf/arch/arm64/Makefile
index fab3095fb5d0..426aecdd0b71 100644
--- a/tools/perf/arch/arm64/Makefile
+++ b/tools/perf/arch/arm64/Makefile
@@ -10,7 +10,8 @@ HAVE_KVM_STAT_SUPPORT := 1
# Syscall table generation for perf
#
-out := $(OUTPUT)arch/arm64/include/generated/asm
+generated := $(OUTPUT)arch/arm64/include/generated
+out := $(generated)/asm
header := $(out)/syscalls.c
incpath := $(srctree)/tools
sysdef := $(srctree)/tools/arch/arm64/include/uapi/asm/unistd.h
@@ -24,6 +25,6 @@ $(header): $(sysdef) $(systbl)
$(Q)$(SHELL) '$(systbl)' '$(CC)' '$(HOSTCC)' $(incpath) $(sysdef) > $@
clean::
- $(call QUIET_CLEAN, arm64) $(RM) $(header)
+ $(call QUIET_CLEAN, arm64) $(RM) -r $(header) $(generated)
archheaders: $(header)
diff --git a/tools/perf/arch/powerpc/Makefile b/tools/perf/arch/powerpc/Makefile
index 840ea0e59287..979c2bebc167 100644
--- a/tools/perf/arch/powerpc/Makefile
+++ b/tools/perf/arch/powerpc/Makefile
@@ -11,7 +11,8 @@ PERF_HAVE_JITDUMP := 1
# Syscall table generation for perf
#
-out := $(OUTPUT)arch/powerpc/include/generated/asm
+generated := $(OUTPUT)arch/powerpc/include/generated
+out := $(generated)/asm
header32 := $(out)/syscalls_32.c
header64 := $(out)/syscalls_64.c
sysprf := $(srctree)/tools/perf/arch/powerpc/entry/syscalls
@@ -28,6 +29,6 @@ $(header32): $(sysdef) $(systbl)
$(Q)$(SHELL) '$(systbl)' '32' $(sysdef) > $@
clean::
- $(call QUIET_CLEAN, powerpc) $(RM) $(header32) $(header64)
+ $(call QUIET_CLEAN, powerpc) $(RM) -r $(header32) $(header64) $(generated)
archheaders: $(header32) $(header64)
diff --git a/tools/perf/arch/s390/Makefile b/tools/perf/arch/s390/Makefile
index 74bffbea03e2..27cf67f1cc78 100644
--- a/tools/perf/arch/s390/Makefile
+++ b/tools/perf/arch/s390/Makefile
@@ -10,7 +10,8 @@ PERF_HAVE_JITDUMP := 1
# Syscall table generation for perf
#
-out := $(OUTPUT)arch/s390/include/generated/asm
+generated := $(OUTPUT)arch/s390/include/generated
+out := $(generated)/asm
header := $(out)/syscalls_64.c
sysprf := $(srctree)/tools/perf/arch/s390/entry/syscalls
sysdef := $(sysprf)/syscall.tbl
@@ -23,6 +24,6 @@ $(header): $(sysdef) $(systbl)
$(Q)$(SHELL) '$(systbl)' $(sysdef) > $@
clean::
- $(call QUIET_CLEAN, s390) $(RM) $(header)
+ $(call QUIET_CLEAN, s390) $(RM) -r $(header) $(generted)
archheaders: $(header)
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-25 12:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 18:32 [PATCH 1/2] Perf: Clean generated directory, other archs Gon Solo
2021-03-06 19:28 ` Arnaldo Carvalho de Melo
2021-03-07 10:19 Gon Solo
2021-03-25 12:40 ` Will Deacon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).