* [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'
@ 2021-03-31 4:37 Dan Carpenter
2021-03-31 8:17 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-03-31 4:37 UTC (permalink / raw)
To: kbuild, Will Deacon
Cc: lkp, kbuild-all, linux-arm-kernel, Marc Zyngier, Steven Price,
Jianyong Wu
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git kvm-arm64/ptp
head: b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64: Probe for the presence of KVM hypervisor
config: arm64-randconfig-m031-20210330 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'
vim +46 drivers/firmware/smccc/kvm_guest.c
fa591eac2e1ffd Will Deacon 2020-12-09 43 bool kvm_arm_hyp_service_available(u32 func_id)
^^^^
fa591eac2e1ffd Will Deacon 2020-12-09 44 {
fa591eac2e1ffd Will Deacon 2020-12-09 45 if (func_id >= ARM_SMCCC_KVM_NUM_FUNCS)
fa591eac2e1ffd Will Deacon 2020-12-09 @46 return -EINVAL;
^^^^^^^^^^^^^^^
This counts as true.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31437 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)'
2021-03-31 4:37 [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)' Dan Carpenter
@ 2021-03-31 8:17 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2021-03-31 8:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: kbuild, Will Deacon, lkp, kbuild-all, linux-arm-kernel,
Steven Price, Jianyong Wu
On 2021-03-31 05:37, Dan Carpenter wrote:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
> kvm-arm64/ptp
> head: b44b5b769890e0e73e2f9fdf461fcbcf72f14ab2
> commit: fa591eac2e1ffdba4b7957fcc05b4d1f95246533 [1/7] arm/arm64:
> Probe for the presence of KVM hypervisor
> config: arm64-randconfig-m031-20210330 (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available()
> warn: signedness bug returning '(-22)'
>
> vim +46 drivers/firmware/smccc/kvm_guest.c
>
> fa591eac2e1ffd Will Deacon 2020-12-09 43 bool
> kvm_arm_hyp_service_available(u32 func_id)
> ^^^^
>
> fa591eac2e1ffd Will Deacon 2020-12-09 44 {
> fa591eac2e1ffd Will Deacon 2020-12-09 45 if (func_id >=
> ARM_SMCCC_KVM_NUM_FUNCS)
> fa591eac2e1ffd Will Deacon 2020-12-09 @46 return -EINVAL;
> ^^^^^^^^^^^^^^^
> This counts as true.
Nice catch. Now fixed. Thanks for the heads up.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-31 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-31 4:37 [arm-platforms:kvm-arm64/ptp 1/7] drivers/firmware/smccc/kvm_guest.c:46 kvm_arm_hyp_service_available() warn: signedness bug returning '(-22)' Dan Carpenter
2021-03-31 8:17 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).