From: Ralf Schlatterbeck <rsc@runtux.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Mirko Vogt <mirko-dev|linux@nanl.de>
Subject: Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug
Date: Fri, 21 May 2021 22:16:44 +0200 [thread overview]
Message-ID: <20210521201644.ksjgsjvdud2wblbe@runtux.com> (raw)
In-Reply-To: <20210521173011.1c602682@slackpad.fritz.box>
On Fri, May 21, 2021 at 05:30:11PM +0100, Andre Przywara wrote:
> On Thu, 20 May 2021 12:06:56 +0200
> Ralf Schlatterbeck <rsc@runtux.com> wrote:
> So if I get your last email correctly, your intention was to make this
> Mirko's patch, which you just send?
Yes.
> In this case the authorship should stay with him (git commit --amend
> --author "..."), and you add your S-o-b (his first, your's next).
> If you use git format-patch & git send-email, it will take care of
> formatting this correctly (inserting a "From" line into the body).
I was using format-patch but editing the result. Would a 'Date' line in
the body also be OK? The patch is really from 2019...
I have it correctly in my git but was unaware that additional header
lines in the body are ok.
> One formatting thing below:
> > sun6i_spi_write(sspi, SUN6I_CLK_CTL_REG, reg);
> > + /* Finally enable the bus - doing so before might raise SCK to HIGH */
> > + sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG,
> > + sun6i_spi_read(sspi, SUN6I_GBL_CTL_REG)
> > + | SUN6I_GBL_CTL_BUS_ENABLE);
>
> The "|" on the new line looks a bit odd. What about you utilise "reg"
> here, as the other access do, to make this more readable?
> reg = sun6i_spi_read(...);
> reg |= ...
> sun6i_spi_write(..., reg);
I've fixed this and will resubmit.
Thanks,
Ralf
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-21 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 10:06 [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug Ralf Schlatterbeck
2021-05-21 16:30 ` Andre Przywara
2021-05-21 20:16 ` Ralf Schlatterbeck [this message]
2021-05-21 20:19 ` Ralf Schlatterbeck
2021-05-24 12:33 ` Andre Przywara
2021-05-24 16:24 ` Ralf Schlatterbeck
2021-05-25 14:35 ` Mark Brown
2021-05-27 11:39 ` Ralf Schlatterbeck
2021-06-05 14:06 ` Mirko Vogt
2021-06-14 14:47 ` Ralf Schlatterbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521201644.ksjgsjvdud2wblbe@runtux.com \
--to=rsc@runtux.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mirko-dev|linux@nanl.de \
--cc=mripard@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).