From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Besar Wicaksono <bwicaksono@nvidia.com>
Cc: suzuki.poulose@arm.com, robin.murphy@arm.com,
catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
sudeep.holla@arm.com, thanu.rangarajan@arm.com,
Michael.Williams@arm.com, treding@nvidia.com,
jonathanh@nvidia.com, vsethi@nvidia.com, mike.leach@linaro.org,
leo.yan@linaro.org
Subject: Re: [RESEND PATCH v3 0/2] perf: ARM CoreSight PMU support
Date: Thu, 7 Jul 2022 10:37:01 -0600 [thread overview]
Message-ID: <20220707163701.GA2616901@p14s> (raw)
In-Reply-To: <20220621055035.31766-1-bwicaksono@nvidia.com>
I will look at this patchset next week.
Thanks,
Mathieu
On Tue, Jun 21, 2022 at 12:50:33AM -0500, Besar Wicaksono wrote:
> Add driver support for ARM CoreSight PMU device and event attributes for NVIDIA
> implementation. The code is based on ARM Coresight PMU architecture and ACPI ARM
> Performance Monitoring Unit table (APMT) specification below:
> * ARM Coresight PMU:
> https://developer.arm.com/documentation/ihi0091/latest
> * APMT: https://developer.arm.com/documentation/den0117/latest
>
> Notes:
> * There is a concern on the naming of the PMU device.
> Currently the driver is probing "arm-coresight-pmu" device, however the APMT
> spec supports different kinds of CoreSight PMU based implementation. So it is
> open for discussion if the name can stay or a "generic" name is required.
> Please see the following thread:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2022-May/740485.html
>
> The patchset applies on top of
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> master next-20220524
>
> Changes from v2:
> * Driver is now probing "arm-system-pmu" device.
> * Change default PMU naming to "arm_<APMT node type>_pmu".
> * Add implementor ops to generate custom name.
> Thanks to suzuki.poulose@arm.com for the review comments.
> v2: https://lore.kernel.org/all/20220515163044.50055-1-bwicaksono@nvidia.com/
>
> Changes from v1:
> * Remove CPU arch dependency.
> * Remove 32-bit read/write helper function and just use read/writel.
> * Add .is_visible into event attribute to filter out cycle counter event.
> * Update pmiidr matching.
> * Remove read-modify-write on PMCR since the driver only writes to PMCR.E.
> * Assign default cycle event outside the 32-bit PMEVTYPER range.
> * Rework the active event and used counter tracking.
> Thanks to robin.murphy@arm.com for the review comments.
> v1: https://lore.kernel.org/all/20220509002810.12412-1-bwicaksono@nvidia.com/
>
> Besar Wicaksono (2):
> perf: coresight_pmu: Add support for ARM CoreSight PMU driver
> perf: coresight_pmu: Add support for NVIDIA SCF and MCF attribute
>
> arch/arm64/configs/defconfig | 1 +
> drivers/perf/Kconfig | 2 +
> drivers/perf/Makefile | 1 +
> drivers/perf/coresight_pmu/Kconfig | 11 +
> drivers/perf/coresight_pmu/Makefile | 7 +
> .../perf/coresight_pmu/arm_coresight_pmu.c | 1316 +++++++++++++++++
> .../perf/coresight_pmu/arm_coresight_pmu.h | 177 +++
> .../coresight_pmu/arm_coresight_pmu_nvidia.c | 312 ++++
> .../coresight_pmu/arm_coresight_pmu_nvidia.h | 17 +
> 9 files changed, 1844 insertions(+)
> create mode 100644 drivers/perf/coresight_pmu/Kconfig
> create mode 100644 drivers/perf/coresight_pmu/Makefile
> create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu.c
> create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu.h
> create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.c
> create mode 100644 drivers/perf/coresight_pmu/arm_coresight_pmu_nvidia.h
>
>
> base-commit: 09ce5091ff971cdbfd67ad84dc561ea27f10d67a
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-07 16:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 5:50 [RESEND PATCH v3 0/2] perf: ARM CoreSight PMU support Besar Wicaksono
2022-06-21 5:50 ` [RESEND PATCH v3 1/2] perf: coresight_pmu: Add support for ARM CoreSight PMU driver Besar Wicaksono
2022-06-27 10:36 ` Will Deacon
2022-07-07 0:25 ` Besar Wicaksono
2022-07-07 11:07 ` Suzuki K Poulose
2022-07-08 10:46 ` Besar Wicaksono
2022-07-12 16:36 ` Mathieu Poirier
2022-07-12 20:13 ` Robin Murphy
2022-07-13 16:26 ` Mathieu Poirier
2022-07-14 4:47 ` Besar Wicaksono
2022-07-21 3:36 ` Besar Wicaksono
2022-07-21 9:19 ` Suzuki K Poulose
2022-07-21 15:35 ` Mathieu Poirier
2022-08-01 22:27 ` Besar Wicaksono
2022-08-02 9:38 ` Suzuki K Poulose
2022-08-02 23:04 ` Besar Wicaksono
2022-06-21 5:50 ` [RESEND PATCH v3 2/2] perf: coresight_pmu: Add support for NVIDIA SCF and MCF attribute Besar Wicaksono
2022-06-27 10:37 ` Will Deacon
2022-07-07 0:40 ` Besar Wicaksono
2022-07-07 11:07 ` Suzuki K Poulose
2022-07-08 13:35 ` Besar Wicaksono
2022-07-07 16:37 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707163701.GA2616901@p14s \
--to=mathieu.poirier@linaro.org \
--cc=Michael.Williams@arm.com \
--cc=bwicaksono@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=jonathanh@nvidia.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=robin.murphy@arm.com \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=thanu.rangarajan@arm.com \
--cc=treding@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).