From: Michal Simek <michal.simek@xilinx.com>
To: Colin King <colin.king@canonical.com>,
Michal Simek <michal.simek@xilinx.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next][V2] i2c: xiic: fix indentation issue
Date: Mon, 27 Jan 2020 12:03:02 +0100 [thread overview]
Message-ID: <2dd84ab2-a7a3-fdd8-6bd6-07f1b3d5cd00@xilinx.com> (raw)
In-Reply-To: <20200127102303.44133-1-colin.king@canonical.com>
On 27. 01. 20 11:23, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a statement that is indented one level too deeply, remove
> the extraneous tab.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> V2: fix type in commit message
> ---
> drivers/i2c/busses/i2c-xiic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index b17d30c9ab40..90c1c362394d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
> if (time_after(jiffies, timeout)) {
> dev_err(i2c->dev, "Failed to clear rx fifo\n");
> - return -ETIMEDOUT;
> + return -ETIMEDOUT;
> }
> }
>
>
As was suggested by Peter you should also add Fixes: <sha1> ("patch
subject")
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-27 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 10:23 [PATCH][next][V2] i2c: xiic: fix indentation issue Colin King
2020-01-27 11:03 ` Michal Simek [this message]
2020-01-27 11:11 ` Johan Hovold
2020-01-27 12:05 ` Dan Carpenter
2020-01-27 12:08 ` Colin Ian King
2020-01-27 12:11 ` Michal Simek
2020-01-28 21:45 ` Peter Rosin
2020-01-28 23:10 ` Colin Ian King
2020-01-28 23:48 ` Joe Perches
2020-01-29 9:31 ` Peter Rosin
2020-01-29 8:06 ` Peter Rosin
2020-01-27 11:17 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dd84ab2-a7a3-fdd8-6bd6-07f1b3d5cd00@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).